Github user thehuijb commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-camera/pull/97#discussion_r32921216
--- Diff: src/android/CameraLauncher.java ---
@@ -173,6 +181,20 @@ else if ((srcType == PHOTOLIBRARY) || (srcType ==
SAVEDPHOTOALBUM)) {
// LOCAL METHODS
//--------------------------------------------------------------------------
+ private void processConfiguration(JSONArray args) throws JSONException
{
+ if (args == null)
+ throw new JSONException("no configuration object passed");
+ this.mQuality = args.optInt(0, 80);
+ // args 1 and 2 (destType, srcType) are skipped because they have
no field representation in this class
+ this.targetWidth = args.optInt(3);
+ this.targetHeight = args.optInt(4);
+ this.encodingType = args.optInt(5, JPEG);
+ this.mediaType = args.optInt(6, PICTURE);
+ this.allowEdit = args.optBoolean(7);
+ this.correctOrientation = args.optBoolean(8);
+ this.saveToPhotoAlbum = args.optBoolean(9);
+ }
--- End diff --
this might be a little to much, optInt already defaults to 0 and optBoolean
to false.
no need to explicitly define these defaults.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org
