Github user omefire commented on the issue:
https://github.com/apache/cordova-cli/pull/255
@stevengill sure, plz review it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user omefire commented on the pull request:
https://github.com/apache/cordova-cli/pull/254#issuecomment-221936305
Opened another PR with these changes here:
https://github.com/apache/cordova-cli/pull/255
---
If your project is set up for it, you can reply to this email and
Github user omefire closed the pull request at:
https://github.com/apache/cordova-cli/pull/254
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
GitHub user omefire opened a pull request:
https://github.com/apache/cordova-cli/pull/255
CLI Refactor
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/omefire/cordova-cli CLI_Refactor
Alternatively you can review and apply
GitHub user omefire opened a pull request:
https://github.com/apache/cordova-cli/pull/254
Code Refactor & Cleanup
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/omefire/cordova-cli CB-11284
Alternatively you can review
GitHub user omefire opened a pull request:
https://github.com/apache/cordova-cli/pull/253
CB-11284 Telemetry: Track platforms/plugins subcommands(add/rm/etc...)
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/omefire/cordova-cli
Github user omefire commented on a diff in the pull request:
https://github.com/apache/cordova-coho/pull/122#discussion_r63578645
--- Diff: src/nightly.js ---
@@ -60,36 +62,26 @@ module.exports = function*(argv) {
}
// Clone and update Repos
-yield
Github user omefire commented on the pull request:
https://github.com/apache/cordova-docs/pull/603#issuecomment-219551255
LGTM!
Changes to CLI reference are effectively in this PR.
I'm OK with not making any changes related to my earlier comments as those
were separat
Github user omefire commented on the pull request:
https://github.com/apache/cordova-cli/pull/247#issuecomment-219530078
@purplecabbage , could you please file a JIRA issue for what you've
encountered ?
I just did the same for the issues I just mentioned:
Github user omefire commented on the pull request:
https://github.com/apache/cordova-docs/pull/603#issuecomment-219526115
However, I don't see the privacy policy changes:
```www/privacy/index.md```:
https://github.com/apache/cordova-docs/c
Github user omefire commented on the pull request:
https://github.com/apache/cordova-docs/pull/603#issuecomment-219525124
Changes related to telemetry are definitely part of this snapshot.
Thanks Raghav!
---
If your project is set up for it, you can reply to this email and have
Github user omefire commented on a diff in the pull request:
https://github.com/apache/cordova-docs/pull/603#discussion_r63411548
--- Diff: www/docs/en/6.x/config_ref/images.md ---
@@ -137,15 +140,17 @@ For Windows the recommended approach to define app
icons is to use `target
Github user omefire commented on a diff in the pull request:
https://github.com/apache/cordova-docs/pull/603#discussion_r63411414
--- Diff: www/docs/en/6.x/config_ref/images.md ---
@@ -137,15 +140,17 @@ For Windows the recommended approach to define app
icons is to use `target
Github user omefire commented on a diff in the pull request:
https://github.com/apache/cordova-docs/pull/603#discussion_r63410912
--- Diff: www/docs/en/6.x/config_ref/images.md ---
@@ -19,17 +19,17 @@ license: >
title: Customize app icons
--- End d
Github user omefire commented on the pull request:
https://github.com/apache/cordova-cli/pull/247#issuecomment-219521656
@purplecabbage , I can't repro this with git-bash shell on Win10 because
I'm running into another issue: https://github.com/nodejs/node/issues/3006
Github user omefire commented on the pull request:
https://github.com/apache/cordova-cli/pull/247#issuecomment-219495292
@purplecabbage, I didn't create a JIRA issue to track the telemetry work, I
should have. My bad.
I've tested this on MAC(El Capitan) and Windows10, bu
Github user omefire commented on a diff in the pull request:
https://github.com/apache/cordova-windows/pull/177#discussion_r63237158
--- Diff: bin/lib/check_reqs.js ---
@@ -362,6 +362,36 @@ module.exports.run = function () {
});
};
+/** Checks if Windows SDK
Github user omefire commented on a diff in the pull request:
https://github.com/apache/cordova-windows/pull/177#discussion_r63236780
--- Diff: bin/lib/check_reqs.js ---
@@ -362,6 +362,36 @@ module.exports.run = function () {
});
};
+/** Checks if Windows SDK
Github user omefire commented on the pull request:
https://github.com/apache/cordova-cli/pull/252#issuecomment-219109613
travis-ci failure is not related to this change, it's related to
cordova-fetch not being in npm.
I ran the tests locally and they do pass.
---
If your pr
Github user omefire commented on the pull request:
https://github.com/apache/cordova-cli/pull/252#issuecomment-219108920
@riknoll to review
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
GitHub user omefire opened a pull request:
https://github.com/apache/cordova-cli/pull/252
CB-11263: 'cordova telemetry help' should display help text
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/omefire/cordova-cl
Github user omefire commented on a diff in the pull request:
https://github.com/apache/cordova-cli/pull/247#discussion_r63068878
--- Diff: src/telemetry.js ---
@@ -0,0 +1,122 @@
+/**
+Licensed to the Apache Software Foundation (ASF) under one
+or more
Github user omefire commented on a diff in the pull request:
https://github.com/apache/cordova-cli/pull/247#discussion_r63066803
--- Diff: src/telemetry.js ---
@@ -0,0 +1,122 @@
+/**
+Licensed to the Apache Software Foundation (ASF) under one
+or more
Github user omefire commented on a diff in the pull request:
https://github.com/apache/cordova-cli/pull/247#discussion_r63066442
--- Diff: doc/cordova.txt ---
@@ -5,6 +5,7 @@ Synopsis
Global Commands
create . Create a project
help
Github user omefire commented on a diff in the pull request:
https://github.com/apache/cordova-cli/pull/247#discussion_r63065751
--- Diff: doc/cordova.txt ---
@@ -5,6 +5,7 @@ Synopsis
Global Commands
create . Create a project
help
Github user omefire commented on the pull request:
https://github.com/apache/cordova-cli/pull/247#issuecomment-218826259
I first wanted to go that route, but I then realized doing it in CLI
minimizes polluting LIB for a functionality that's not intended to be used by
downstream
Github user omefire commented on the pull request:
https://github.com/apache/cordova-cli/pull/247#issuecomment-218664005
ping ...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user omefire commented on a diff in the pull request:
https://github.com/apache/cordova-cli/pull/247#discussion_r62894363
--- Diff: src/cli.js ---
@@ -235,41 +317,58 @@ function cli(inputArgs) {
throw new CordovaError(msg
Github user omefire commented on a diff in the pull request:
https://github.com/apache/cordova-cli/pull/247#discussion_r62882068
--- Diff: src/cli.js ---
@@ -235,41 +317,58 @@ function cli(inputArgs) {
throw new CordovaError(msg
Github user omefire commented on a diff in the pull request:
https://github.com/apache/cordova-cli/pull/247#discussion_r62880886
--- Diff: src/cli.js ---
@@ -235,41 +317,58 @@ function cli(inputArgs) {
throw new CordovaError(msg
Github user omefire commented on a diff in the pull request:
https://github.com/apache/cordova-cli/pull/247#discussion_r62870553
--- Diff: src/cli.js ---
@@ -235,41 +317,58 @@ function cli(inputArgs) {
throw new CordovaError(msg
Github user omefire commented on a diff in the pull request:
https://github.com/apache/cordova-cli/pull/247#discussion_r62777073
--- Diff: src/telemetry.js ---
@@ -0,0 +1,132 @@
+/**
+Licensed to the Apache Software Foundation (ASF) under one
+or more
Github user omefire commented on the pull request:
https://github.com/apache/cordova-docs/pull/599#issuecomment-218331338
Thanks, comments addressed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user omefire commented on a diff in the pull request:
https://github.com/apache/cordova-docs/pull/599#discussion_r62776600
--- Diff: www/privacy/index.md ---
@@ -0,0 +1,22 @@
+---
+layout: page
+title: Privacy Policy
+---
+
+# Privacy Policy
Github user omefire commented on a diff in the pull request:
https://github.com/apache/cordova-cli/pull/247#discussion_r62759764
--- Diff: src/telemetry.js ---
@@ -0,0 +1,132 @@
+/**
+Licensed to the Apache Software Foundation (ASF) under one
+or more
Github user omefire commented on a diff in the pull request:
https://github.com/apache/cordova-cli/pull/247#discussion_r62758588
--- Diff: spec/cli.spec.js ---
@@ -50,19 +56,34 @@ describe("cordova cli", function () {
beforeEac
Github user omefire commented on a diff in the pull request:
https://github.com/apache/cordova-cli/pull/247#discussion_r62758273
--- Diff: doc/telemetry.txt ---
@@ -0,0 +1,24 @@
+Synopsis
+
+cordova-cli telemetry [STATE]
+
+ STATE: on|off
Github user omefire commented on the pull request:
https://github.com/apache/cordova-cli/pull/247#issuecomment-218299896
Related: https://github.com/apache/cordova-docs/pull/599
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user omefire commented on the pull request:
https://github.com/apache/cordova-docs/pull/599#issuecomment-218299426
What it looks like: http://imgur.com/FSDAifF
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user omefire commented on the pull request:
https://github.com/apache/cordova-docs/pull/599#issuecomment-218298615
http://imgur.com/FSDAifF
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user omefire commented on the pull request:
https://github.com/apache/cordova-docs/pull/599#issuecomment-218296850
@axemclion, @nikhilkh to review
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
GitHub user omefire opened a pull request:
https://github.com/apache/cordova-docs/pull/599
Telemetry: Privacy Policy
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/omefire/cordova-docs TelemetryPrivacyPolicy
Alternatively you
Github user omefire commented on the pull request:
https://github.com/apache/cordova-cli/pull/247#issuecomment-217747793
This code relies on the insight package:
https://www.npmjs.com/package/insight
However, due to a bug within insight, when the command prompt timeout
expires
Github user omefire commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-contacts/pull/125#discussion_r62398237
--- Diff: www/convertUtils.js ---
@@ -28,10 +28,19 @@ module.exports = {
*/
toCordovaFormat: function (contact
Github user omefire commented on the pull request:
https://github.com/apache/cordova-plugin-contacts/pull/125#issuecomment-217576715
LGTM!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user omefire commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-contacts/pull/125#discussion_r62397911
--- Diff: www/convertUtils.js ---
@@ -28,10 +28,19 @@ module.exports = {
*/
toCordovaFormat: function (contact
Github user omefire commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-contacts/pull/125#discussion_r62395371
--- Diff: www/convertUtils.js ---
@@ -28,10 +28,19 @@ module.exports = {
*/
toCordovaFormat: function (contact
Github user omefire commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-contacts/pull/125#discussion_r62395046
--- Diff: www/convertUtils.js ---
@@ -28,10 +28,19 @@ module.exports = {
*/
toCordovaFormat: function (contact
Github user omefire commented on the pull request:
https://github.com/apache/cordova-plugin-contacts/pull/125#issuecomment-217565470
Do you know why is iOS setting an 'Invalid Date' in the first place ? I
feel like this fix might end up just masking an issue on the n
Github user omefire commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-contacts/pull/125#discussion_r62393819
--- Diff: www/convertUtils.js ---
@@ -28,10 +28,19 @@ module.exports = {
*/
toCordovaFormat: function (contact
Github user omefire commented on the pull request:
https://github.com/apache/cordova-mobile-spec/pull/140#issuecomment-217527951
Haha, I just realized we should have updated the title to 'Fixing flaky XHR
Test' instead of 'Removing ...'.
Oh well, ...
---
If
Github user omefire commented on the pull request:
https://github.com/apache/cordova-mobile-spec/pull/140#issuecomment-217527093
LGTM!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user omefire commented on the pull request:
https://github.com/apache/cordova-lib/pull/436#issuecomment-217521367
Ok. I've created an issue to track it here:
https://issues.apache.org/jira/browse/CB-11219
---
If your project is set up for it, you can reply to this emai
Github user omefire commented on the pull request:
https://github.com/apache/cordova-lib/pull/436#issuecomment-217510255
(Though not related to this change) it seems like the ```--force``` flag
wouldn't work as advertised ?
---
If your project is set up for it, you can reply to
Github user omefire commented on the pull request:
https://github.com/apache/cordova-lib/pull/436#issuecomment-217510027
LGTM!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user omefire commented on the pull request:
https://github.com/apache/cordova-mobile-spec/pull/140#issuecomment-217509068
@rakatyal Is the flakiness related to the host we're XHR'ing to ? Would
switching from 'http://cordova-filetransfer.jitsu.com' t
Github user omefire commented on the pull request:
https://github.com/apache/cordova-mobile-spec/pull/140#issuecomment-217508257
Thanks @purplecabbage for confirming.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user omefire commented on the pull request:
https://github.com/apache/cordova-mobile-spec/pull/140#issuecomment-217334128
It seems like this whole test suite is only about checking browser/webview
functionality.
Do we still really need them ?
---
If your project is set
Github user omefire commented on the pull request:
https://github.com/apache/cordova-plugin-device-motion/pull/43#issuecomment-217259632
a comment would also be great
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user omefire commented on the pull request:
https://github.com/apache/cordova-plugin-device-motion/pull/43#issuecomment-217239510
Other than the minor stuff mentioned, LGTM!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user omefire commented on the pull request:
https://github.com/apache/cordova-plugin-device-motion/pull/43#issuecomment-217238656
+1 . Introducing a delta for this kind of comparisons is a good strategy
for this issue.
---
If your project is set up for it, you can reply to
Github user omefire commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-device-motion/pull/43#discussion_r62233809
--- Diff: tests/tests.js ---
@@ -122,6 +122,7 @@ exports.defineAutoTests = function () {
describe("watchAcceler
Github user omefire commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-splashscreen/pull/102#discussion_r62209585
--- Diff: src/android/SplashScreen.java ---
@@ -300,6 +304,23 @@ public void run() {
// Create and show the
GitHub user omefire opened a pull request:
https://github.com/apache/cordova-cli/pull/247
Telemetry
Work In Progress...
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/omefire/cordova-cli Telemetry
Alternatively you can review
Github user omefire commented on the pull request:
https://github.com/apache/cordova-medic/pull/101#issuecomment-215512291
Merging this without the suggested variable name changes, as we'll be
moving away from cordova-medic soon anyway.
---
If your project is set up for it, yo
Github user omefire commented on the pull request:
https://github.com/apache/cordova-medic/pull/101#issuecomment-215503182
@sarangan12 a quick search through the repo yields only 4 files with less
than 10 instances that would need to be updated.
I think it is worth the effort
Github user omefire commented on the pull request:
https://github.com/apache/cordova-medic/pull/101#issuecomment-215501596
Hmm, we've got a case of confusing naming here. I think we should rename
```argv.app``` to ```argv.appName```. That will make the intent clearer and
prevent
GitHub user omefire opened a pull request:
https://github.com/apache/cordova-medic/pull/98
CB-11135 If folder is pre-existent, don't error out
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/omefire/cordova-medic CB-
Github user omefire commented on a diff in the pull request:
https://github.com/apache/cordova-medic/pull/96#discussion_r60666920
--- Diff: lib/util.js ---
@@ -81,8 +92,8 @@ module.exports = (function() {
return numDevices;
}
-function getSimId
Github user omefire commented on the pull request:
https://github.com/apache/cordova-medic/pull/94#issuecomment-213118959
Related PR: https://github.com/apache/cordova-medic/pull/96
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
GitHub user omefire opened a pull request:
https://github.com/apache/cordova-medic/pull/96
CB-11135 iOS Contacts Perms: Handle case where 'cordova-cli' install â¦
â¦not global
You can merge this pull request into a Git repository by running:
$ git pull https://
Github user omefire commented on the pull request:
https://github.com/apache/cordova-plugin-test-framework/pull/20#issuecomment-212679043
LGTM!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user omefire commented on the pull request:
https://github.com/apache/cordova-medic/pull/94#issuecomment-212592382
Rebased on top of master and ready to be merged.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user omefire commented on a diff in the pull request:
https://github.com/apache/cordova-paramedic/pull/4#discussion_r60480780
--- Diff: lib/utils/utilities.js ---
@@ -0,0 +1,123 @@
+#!/usr/bin/env node
+
+var shelljs = require('shelljs');
+v
Github user omefire commented on a diff in the pull request:
https://github.com/apache/cordova-paramedic/pull/4#discussion_r60472155
--- Diff: lib/utils/utilities.js ---
@@ -0,0 +1,123 @@
+#!/usr/bin/env node
+
+var shelljs = require('shelljs');
+v
Github user omefire commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/429#discussion_r60314872
--- Diff: cordova-common/src/FileUpdater.js ---
@@ -0,0 +1,389 @@
+/**
+Licensed to the Apache Software Foundation (ASF) under one
Github user omefire commented on the pull request:
https://github.com/apache/cordova-medic/pull/94#issuecomment-212074252
@sarangan12 could you please review ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user omefire commented on the pull request:
https://github.com/apache/cordova-medic/pull/94#issuecomment-212074104
This PR ports part of the following paramedic PR to medic:
https://github.com/apache/cordova-paramedic/pull/4
---
If your project is set up for it, you can
GitHub user omefire opened a pull request:
https://github.com/apache/cordova-medic/pull/94
CB-10475 (cordova-plugin-contacts) Grant 'Contacts' permissions whileâ¦
⦠running on iOS simulator
You can merge this pull request into a Git repository by running:
$ git
Github user omefire commented on a diff in the pull request:
https://github.com/apache/cordova-paramedic/pull/4#discussion_r60128184
--- Diff: lib/ParamedicPermissions.js ---
@@ -0,0 +1,60 @@
+#!/usr/bin/env node
+
+/* jshint node: true */
+var path= require
Github user omefire commented on the pull request:
https://github.com/apache/cordova-plugin-media/pull/93#issuecomment-211529912
Should you instead use the ```readyPlayer(...)``` followed by seeking to
the end of the file in this case ? It seems like a pattern used by
Github user omefire commented on a diff in the pull request:
https://github.com/apache/cordova-paramedic/pull/4#discussion_r59903675
--- Diff: lib/ParamedicLog.js ---
@@ -0,0 +1,154 @@
+#!/usr/bin/env node
+
+/* jshint node: true */
+
+"use s
Github user omefire commented on a diff in the pull request:
https://github.com/apache/cordova-paramedic/pull/4#discussion_r59769584
--- Diff: lib/ParamedicKill.js ---
@@ -0,0 +1,95 @@
+#!/usr/bin/env node
+
+"use strict";
+
+var shelljs = requir
Github user omefire commented on a diff in the pull request:
https://github.com/apache/cordova-paramedic/pull/4#discussion_r59762195
--- Diff: lib/ParamedicKill.js ---
@@ -0,0 +1,95 @@
+#!/usr/bin/env node
+
+"use strict";
+
+var shelljs = requir
Github user omefire commented on a diff in the pull request:
https://github.com/apache/cordova-paramedic/pull/4#discussion_r59762070
--- Diff: lib/ParamedicKill.js ---
@@ -0,0 +1,95 @@
+#!/usr/bin/env node
+
+"use strict";
+
+var shelljs = requir
Github user omefire commented on the pull request:
https://github.com/apache/cordova-docs/pull/578#issuecomment-209993540
ACK!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user omefire commented on the pull request:
https://github.com/apache/cordova-cli/pull/244#issuecomment-209579313
ok, now I get it. apparently, the website content will be generated from
this readme.md, so we're fine.
---
If your project is set up for it, you can rep
Github user omefire commented on the pull request:
https://github.com/apache/cordova-cli/pull/244#issuecomment-209579344
LGTM!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user omefire commented on the pull request:
https://github.com/apache/cordova-cli/pull/244#issuecomment-209578035
@nikhilkh , if that's the case don't we need a JIRA to track updating the
docs website ?
---
If your project is set up for it, you can reply to this
Github user omefire commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-camera/pull/205#discussion_r59598321
--- Diff: src/ios/CDVCamera.m ---
@@ -358,6 +358,7 @@ - (NSData*)processImage:(UIImage*)image
info:(NSDictionary*)info options:(CDVPic
Github user omefire commented on the pull request:
https://github.com/apache/cordova-plugin-camera/pull/205#issuecomment-209575841
I agree on an appium test to cover this scenario, but I think it should go
further than just making sure no crash happens and also validate that the EXIF
Github user omefire commented on the pull request:
https://github.com/apache/cordova-cli/pull/244#issuecomment-209572705
It's located elsewhere, in the cordova-docs repo:
https://github.com/apache/cordova-docs/blob/1f35df99b7cf77aa5889c2ecb9a3c3ab71542ee6/www/docs/en/6.x/refe
Github user omefire commented on the pull request:
https://github.com/apache/cordova-cli/pull/244#issuecomment-209564718
@jasongin consider also updating the docs:
http://cordova.apache.org/docs/en/latest/reference/cordova-cli/index.html
---
If your project is set up for it, you can
Github user omefire commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/426#discussion_r59592544
--- Diff: cordova-lib/src/cordova/run.js ---
@@ -32,8 +32,10 @@ module.exports = function run(options) {
var hooksRunner = new HooksRunner
GitHub user omefire opened a pull request:
https://github.com/apache/cordova-medic/pull/88
CB-10898 Kill simulator Xcode6 style
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/omefire/cordova-medic CB-10898
Alternatively you
Github user omefire commented on the pull request:
https://github.com/apache/cordova-medic/pull/86#issuecomment-209170685
@dblotsky yeah, might be a good idea to add both, since the former string
handles Xcode 6 if someone were to be still using it.
---
If your project is set up for
Github user omefire commented on the pull request:
https://github.com/apache/cordova-plugin-camera/pull/205#issuecomment-209169845
For more details, see: https://issues.apache.org/jira/browse/CB-10873
---
If your project is set up for it, you can reply to this email and have your
Github user omefire commented on the pull request:
https://github.com/apache/cordova-plugin-camera/pull/205#issuecomment-209168919
What happens is that when trying to write the image source, we do it with a
null/nil variable ```self.data```:
https://github.com/omefire/cordova
GitHub user omefire opened a pull request:
https://github.com/apache/cordova-plugin-camera/pull/205
CB-10873 Avoid crash due to usage of uninitialized variable when writâ¦
â¦ing geolocation data to image destination
You can merge this pull request into a Git repository by running
Github user omefire commented on the pull request:
https://github.com/apache/cordova-ios/pull/214#issuecomment-209017316
@shazron I'm merging this in. I've addressed your CR notes.
---
If your project is set up for it, you can reply to this email and have your
reply appear
1 - 100 of 629 matches
Mail list logo
