Github user omefire commented on a diff in the pull request:
https://github.com/apache/cordova-windows/pull/177#discussion_r63236780
--- Diff: bin/lib/check_reqs.js ---
@@ -362,6 +362,36 @@ module.exports.run = function () {
});
};
+/** Checks if Windows SDK required to build the target_platform is present
+ * @param {String} target_platorm Target platform ('8.1' or '10.0')
+ * @return {Boolean} Whether the min SDK required to
build the platform is present
+ *
+ */
+module.exports.isWinSDKPresent = function (target_platform) {
+ return getInstalledWindowsSdks()
+ .then(function (installedSdks) {
+ var reqVersion =
Version.tryParse(REQUIRED_VERSIONS[target_platform].windowssdk);
+ var hasSdkInstalled = installedSdks.some(function (installedSdk) {
--- End diff --
It seems like ```getInstalledWindowsSdks()``` doesn't return an array in
all cases, i.e: when an exception occurs while running the registry query.
Maybe, modify it to return an empty array in such a case, otherwise we'll error
out here.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org
