[GitHub] cordova-plugin-inappbrowser issue #238: added cookies support for Android an...

2017-08-28 Thread denisx304
Github user denisx304 commented on the issue: https://github.com/apache/cordova-plugin-inappbrowser/pull/238 @janpio You can send any cookie as long as the server interprets it. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as w

Nightly build #468 for cordova has failed

2017-08-28 Thread Apache Jenkins Server
Nightly build #468 for cordova has failed. Please check failure details on build details page at https://builds.apache.org/job/cordova-nightly/468/ You can also take a look at build console: https://builds.apache.org/job/cordova-nightly/468/consoleFull - Jenkins for Apache Cordova

[GitHub] cordova-lib pull request #590: CB-13145: Create playservices version prefere...

2017-08-28 Thread stevengill
Github user stevengill commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/590#discussion_r135664127 --- Diff: src/cordova/plugin/util.js --- @@ -35,3 +40,39 @@ function saveToConfigXmlOn (config_json, options) { var autosave = config_json.au

[GitHub] cordova-lib pull request #590: CB-13145: Create playservices version prefere...

2017-08-28 Thread stevengill
Github user stevengill commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/590#discussion_r135664112 --- Diff: src/cordova/plugin/util.js --- @@ -35,3 +40,39 @@ function saveToConfigXmlOn (config_json, options) { var autosave = config_json.au

Re: [VOTE] cordova-browser@5 & cordova-serve@2 (attempt 2)

2017-08-28 Thread Jesse
I vote +1: * ran coho audit-license-headers over the relevant repos * ran coho check-license to ensure all dependencies have Apache-compatible licenses * created and ran a test project successfully * verified that the contents of NewProject/node_modules/cordova-browser/node_modules/cordova-serve m

Re: [DISCUSS] Browser 5.0.0 release

2017-08-28 Thread Jesse
This is not the vote thread Audrey, discuss only here. @purplecabbage risingj.com On Mon, Aug 28, 2017 at 1:59 PM, Audrey So wrote: > +1 > > I did the following: > 1. pulled the latest cordova-browser down locally > 2. updated cordova-browser package.json `cordova-serve` dependency to: > https

Re: [VOTE] cordova-browser@5 & cordova-serve@2 (attempt 2)

2017-08-28 Thread Audrey So
+1 I did the following: 1. pulled the latest cordova-browser down locally 2. updated cordova-browser package.json `cordova-serve` dependency to: https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fapache%2Fcordova-serve%232.0.0&data=02%7C01%7C%7C948615d0e2cd43b210e308d4e

Re: [DISCUSS] Browser 5.0.0 release

2017-08-28 Thread Audrey So
+1 I did the following: 1. pulled the latest cordova-browser down locally 2. updated cordova-browser package.json `cordova-serve` dependency to: https://github.com/apache/cordova-serve#2.0.0 3. added my local cordova-browser 4. ran npm test in cordova-browser (passed) 5. cordova run in sample pro

Re: [DISCUSS] Browser 5.0.0 release

2017-08-28 Thread Kerri Shotts
Tx for the reminder -- meant to do it this weekend and time got away from me. I'll see what I can do tonight. Best, ~ Kerri * Kerri shotts*, Developer Advocate @ Adobe Blog • @kerrishotts

Re: [DISCUSS] Browser 5.0.0 release

2017-08-28 Thread Steven Gill
Need some votes! On Wed, Aug 23, 2017 at 5:53 PM, Steven Gill wrote: > Okay. Sent PRs to fix browser [1] and cordova serve [2]. > > [1] https://github.com/apache/cordova-browser/pull/41 > [2] https://github.com/apache/cordova-serve/pull/4 > > I will plan to merge these in tomorrow and start a re