This is not the vote thread Audrey, discuss only here.
@purplecabbage risingj.com On Mon, Aug 28, 2017 at 1:59 PM, Audrey So <a...@adobe.com.invalid> wrote: > +1 > > I did the following: > 1. pulled the latest cordova-browser down locally > 2. updated cordova-browser package.json `cordova-serve` dependency to: > https://github.com/apache/cordova-serve#2.0.0 > 3. added my local cordova-browser > 4. ran npm test in cordova-browser (passed) > 5. cordova run in sample project (passed) > LGTM! > > > — Audrey > > > > > > On 8/28/17, 1:09 PM, "Steven Gill" <stevengil...@gmail.com> wrote: > > >Need some votes! > > > >On Wed, Aug 23, 2017 at 5:53 PM, Steven Gill <stevengil...@gmail.com> > wrote: > > > >> Okay. Sent PRs to fix browser [1] and cordova serve [2]. > >> > >> [1] https://na01.safelinks.protection.outlook.com/?url= > https%3A%2F%2Fgithub.com%2Fapache%2Fcordova-browser% > 2Fpull%2F41&data=02%7C01%7C%7Cf3a91dbe264f421fa8a808d4ee50c483% > 7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636395478065312029&sdata= > oOv7uEE4yl4wK%2Fl9SBkkVGbmHqYlQIkz0Szq3s9el1w%3D&reserved=0 > >> [2] https://na01.safelinks.protection.outlook.com/?url= > https%3A%2F%2Fgithub.com%2Fapache%2Fcordova-serve% > 2Fpull%2F4&data=02%7C01%7C%7Cf3a91dbe264f421fa8a808d4ee50c483% > 7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636395478065312029&sdata= > OexM9fhYXOrWO6gVftMW1iHLhmZsYgpu%2BE3OlwIykD0%3D&reserved=0 > >> > >> I will plan to merge these in tomorrow and start a release for both. > >> > >> On Thu, Aug 17, 2017 at 11:40 AM, Steven Gill <stevengil...@gmail.com> > >> wrote: > >> > >>> https://na01.safelinks.protection.outlook.com/?url= > https%3A%2F%2Fissues.apache.org%2Fjira%2Fbrowse%2FCB- > 13188&data=02%7C01%7C%7Cf3a91dbe264f421fa8a808d4ee50c483% > 7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636395478065312029&sdata= > Ndc1T8CqYJQMTRdIH7iss6d0crs4b92AXsd%2FsqhzDzE%3D&reserved=0 > >>> > >>> On Thu, Aug 17, 2017 at 11:35 AM, Steven Gill <stevengil...@gmail.com> > >>> wrote: > >>> > >>>> new project. Adding and removing browser doesn't help > >>>> > >>>> On Thu, Aug 17, 2017 at 11:32 AM, Jesse <purplecabb...@gmail.com> > wrote: > >>>> > >>>>> is this a new project? does adding and removing the browser platform > >>>>> help? > >>>>> > >>>>> > >>>>> > >>>>> @purplecabbage > >>>>> risingj.com > >>>>> > >>>>> On Thu, Aug 17, 2017 at 11:21 AM, Steven Gill < > stevengil...@gmail.com> > >>>>> wrote: > >>>>> > >>>>> > Ahh I'm seeing this too :(. I'll fix it and do some more tests > >>>>> > > >>>>> > On Wed, Aug 16, 2017 at 9:52 PM, <alsoro...@apache.org> wrote: > >>>>> > > >>>>> > > Well yeah... `cordova run browser` currently gives me this: > >>>>> > > https://na01.safelinks.protection.outlook.com/?url= > https%3A%2F%2Fgist.github.com%2Falsorokin%2F0c586acbfd560f50a908a9916909 > b220&data=02%7C01%7C%7Cf3a91dbe264f421fa8a808d4ee50c483% > 7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636395478065312029&sdata= > iFHMrf3E32nzwvanHZVVBj%2F%2FDGYlPgfQGSA9V%2ByNESI%3D&reserved=0 > >>>>> > > > >>>>> > > -----Original Message----- > >>>>> > > From: Steven Gill [mailto:stevengil...@gmail.com] > >>>>> > > Sent: Wednesday, August 16, 2017 8:09 PM > >>>>> > > To: dev@cordova.apache.org > >>>>> > > Subject: [DISCUSS] Browser 5.0.0 release > >>>>> > > > >>>>> > > Hey everyone! > >>>>> > > > >>>>> > > I want to start a new browser release. 5.0.0. It will be a major > >>>>> because > >>>>> > > browser has adopted the platformAPI & because it introduces the > >>>>> creation > >>>>> > of > >>>>> > > manifest.json (from config.xml) for basic PWA support. > >>>>> > > > >>>>> > > Any issues or concerns? > >>>>> > > > >>>>> > > > >>>>> > > ------------------------------------------------------------ > >>>>> --------- > >>>>> > > To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org > >>>>> > > For additional commands, e-mail: dev-h...@cordova.apache.org > >>>>> > > > >>>>> > > > >>>>> > > >>>>> > >>>> > >>>> > >>> > >> >
