garydgregory commented on a change in pull request #5: optimize map columns 2
properties code
URL: https://github.com/apache/commons-dbutils/pull/5#discussion_r261832711
##
File path: src/main/java/org/apache/commons/dbutils/BeanProcessor.java
##
@@ -465,9 +465,6 @@ protec
aherbert commented on a change in pull request #103: TEXT-126: Adding
Sorensen-Dice similarity algoritham
URL: https://github.com/apache/commons-text/pull/103#discussion_r261841223
##
File path:
src/main/java/org/apache/commons/text/similarity/SorensenDicesSimilarity.java
aherbert opened a new pull request #105: TEXT-151: Use StringUtils.equals to
test for CharSequence equality.
URL: https://github.com/apache/commons-text/pull/105
Comparing CharSequence using Object.equals will fail when the CharSequence
implementation does not support this.
--
coveralls commented on issue #105: TEXT-151: Use StringUtils.equals to test for
CharSequence equality.
URL: https://github.com/apache/commons-text/pull/105#issuecomment-468961411
[](https://coveralls.io/builds/21949966)
chtompki commented on issue #105: TEXT-151: Use StringUtils.equals to test for
CharSequence equality.
URL: https://github.com/apache/commons-text/pull/105#issuecomment-468962820
LGTM
This is an automated message from the Apac
garydgregory merged pull request #105: TEXT-151: Use StringUtils.equals to test
for CharSequence equality.
URL: https://github.com/apache/commons-text/pull/105
This is an automated message from the Apache Git Service.
To res
kinow edited a comment on issue #103: TEXT-126: Adding Sorensen-Dice similarity
algoritham
URL: https://github.com/apache/commons-text/pull/103#issuecomment-467606333
Hi @ameyjadiye ! A new metric! 🎉 Added a few comments, but only spent a
couple of minutes looking at the code. I will take
darkma773r opened a new pull request #1: GEOMETRY-1: Initial Code Commit
URL: https://github.com/apache/commons-geometry/pull/1
Moving over existing geometry code from commons-math.
This is an automated message from the Apach
darkma773r opened a new pull request #2: GEOMETRY-2: Points and Vectors API
Updates
URL: https://github.com/apache/commons-geometry/pull/2
The main driver behind these changes was to try to clean up the API as it
relates to points and vectors. The interfaces did not allow enough informatio
darkma773r opened a new pull request #3: GEOMETRY-6: Making CartesianXD fields
private
URL: https://github.com/apache/commons-geometry/pull/3
Changing protected fields to private.
This is an automated message from the Apache
asfgit closed pull request #3: GEOMETRY-6: Making CartesianXD fields private
URL: https://github.com/apache/commons-geometry/pull/3
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a fore
darkma773r opened a new pull request #4: Points/Vectors as VALJOs
URL: https://github.com/apache/commons-geometry/pull/4
Making all point and vector concrete classes meet the requirements for
VALJOs. Also, addressing the comment from GEOMETRY-2 about the placement of the
Serializable inter
darkma773r opened a new pull request #5: README files
URL: https://github.com/apache/commons-geometry/pull/5
Adding initial README files (as generated by mvn commons:readme-md).
This is an automated message from the Apache Git
asfgit closed pull request #5: README files
URL: https://github.com/apache/commons-geometry/pull/5
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), t
darkma773r commented on issue #4: Points/Vectors as VALJOs
URL: https://github.com/apache/commons-geometry/pull/4#issuecomment-406465161
I'm closing this pull request and making a new one that combines changes
from GEOMETRY-3 and GEOMETRY-4 so that we can have a clean CheckStyle report
(GE
darkma773r opened a new pull request #6: Points/Vectors as VALJOs with Cleanup
URL: https://github.com/apache/commons-geometry/pull/6
This combines the changes from GEOMETRY-3 (Points/Vectors and VALJOs) and
GEOMETRY-4 (Cleanup CheckStyle and SpotBugs Issues).
-
darkma773r opened a new pull request #7: Polar and Spherical Coordinates
URL: https://github.com/apache/commons-geometry/pull/7
Adds support for polar and spherical coordinates (GEOMETRY-7).
This is an automated message from t
asfgit closed pull request #7: Polar and Spherical Coordinates
URL: https://github.com/apache/commons-geometry/pull/7
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull reque
darkma773r opened a new pull request #8: Geometry 9
URL: https://github.com/apache/commons-geometry/pull/8
Additional vector/point methods and some cleanup.
This is an automated message from the Apache Git Service.
To respond
darkma773r opened a new pull request #9: Geometry 8
URL: https://github.com/apache/commons-geometry/pull/9
Updates to exception types and handling. Also updating norm handling to
check for NaN and infinite in addition to zero during normalization.
--
asfgit closed pull request #9: Geometry 8
URL: https://github.com/apache/commons-geometry/pull/9
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the
darkma773r opened a new pull request #10: Geometry 10
URL: https://github.com/apache/commons-geometry/pull/10
Vector normalize() optimizations
This is an automated message from the Apache Git Service.
To respond to the message
asfgit closed pull request #10: Geometry 10
URL: https://github.com/apache/commons-geometry/pull/10
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork),
darkma773r opened a new pull request #11: Geometry 17
URL: https://github.com/apache/commons-geometry/pull/11
Vector method follow-up task.
This is an automated message from the Apache Git Service.
To respond to the message, p
darkma773r opened a new pull request #12: Geometry 19
URL: https://github.com/apache/commons-geometry/pull/12
Build updates to support JDK 10.
This is an automated message from the Apache Git Service.
To respond to the message
darkma773r closed pull request #12: Geometry 19
URL: https://github.com/apache/commons-geometry/pull/12
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a for
darkma773r commented on issue #12: Geometry 19
URL: https://github.com/apache/commons-geometry/pull/12#issuecomment-423707558
Closing this pr based on the discussion here:
https://issues.apache.org/jira/projects/GEOMETRY/issues/GEOMETRY-19. In short,
the issue is not with commons-geometry
asfgit closed pull request #11: Geometry 17
URL: https://github.com/apache/commons-geometry/pull/11
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork),
darkma773r opened a new pull request #13: GEOMETRY-20
URL: https://github.com/apache/commons-geometry/pull/13
Removing getNorm1(), getNormInf(), distance1(), and distanceInf() Vector
methods to simplify and streamline API
Thi
asfgit closed pull request #13: GEOMETRY-20
URL: https://github.com/apache/commons-geometry/pull/13
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork),
darkma773r opened a new pull request #14: GEOMETRY-14: Initial
AffineTransform3D class
URL: https://github.com/apache/commons-geometry/pull/14
This is an initial merge request for the work on GEOMETRY-14, primarily to
gain feedback on the new transform architecture in 3D space before imple
darkma773r closed pull request #14: GEOMETRY-14: Initial AffineTransform3D class
URL: https://github.com/apache/commons-geometry/pull/14
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a
darkma773r opened a new pull request #15: GEOMETRY-23: Remove Point?D
URL: https://github.com/apache/commons-geometry/pull/15
Removing Euclidean point classes and making Vector?D implement Point.
This is an automated message f
darkma773r opened a new pull request #16: GEOMETRY-14: Adding Transform Classes
URL: https://github.com/apache/commons-geometry/pull/16
Adding AffineTransformMatrix?D, QuaternionRotation, and AxisAngleSequence
classes. Removing previous Rotation class.
-
ossdev07 opened a new pull request #91: run time support is added for openssl
1.0 and 1.1 for UNIX
URL: https://github.com/apache/commons-crypto/pull/91
This patch will check for both libcrypto library in system and will create
libcommons-crypto.so using those. In this patch absolute name
coveralls commented on issue #91: run time support is added for openssl 1.0 and
1.1 for UNIX
URL: https://github.com/apache/commons-crypto/pull/91#issuecomment-448120136
[](https://coveralls.io/builds/20689145)
Covera
coveralls edited a comment on issue #91: run time support is added for openssl
1.0 and 1.1 for UNIX
URL: https://github.com/apache/commons-crypto/pull/91#issuecomment-448120136
[](https://coveralls.io/builds/20689468)
KrzychuJedi commented on issue #35: Turn CSVRecord into a List
URL: https://github.com/apache/commons-csv/pull/35#issuecomment-448933216
If I may add something from developer perspective. I recently used
commons-csv and this feature would be very desire change. It will allow to use
stream
PascalSchumacher opened a new pull request #98: Enable jacoco on java 11+
URL: https://github.com/apache/commons-text/pull/98
This is an automated message from the Apache Git Service.
To respond to the message, please log on
coveralls commented on issue #98: Enable jacoco on java 11+
URL: https://github.com/apache/commons-text/pull/98#issuecomment-449002179
[](https://coveralls.io/builds/20739101)
Coverage remained the same at 97.878% when
asfgit closed pull request #98: Enable jacoco on java 11+
URL: https://github.com/apache/commons-text/pull/98
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from
PascalSchumacher opened a new pull request #99: Spotbugs java 12
URL: https://github.com/apache/commons-text/pull/99
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub an
asfgit closed pull request #99: Spotbugs java 12
URL: https://github.com/apache/commons-text/pull/99
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork),
coveralls commented on issue #99: Spotbugs java 12
URL: https://github.com/apache/commons-text/pull/99#issuecomment-449017556
[](https://coveralls.io/builds/20740061)
Coverage remained the same at 97.878% when pulling
darkma773r opened a new pull request #17: Minor Cleanup
URL: https://github.com/apache/commons-geometry/pull/17
- Removing unused internal methods
- Using better test names
- Adding javadocs
This is an automated message
mina86 commented on issue #35: Turn CSVRecord into a List
URL: https://github.com/apache/commons-csv/pull/35#issuecomment-449403846
FYI, you can do `StreamSupport.stream(record.splitterator(), false)` to
convert CSVRecord into a stream though it’s less efficient in some cases (since
the st
darkma773r commented on issue #17: Minor Cleanup
URL: https://github.com/apache/commons-geometry/pull/17#issuecomment-449592466
I'm closing this. The changes here will be part of another PR that has a
JIRA issue associated with it. This one does not.
---
darkma773r closed pull request #17: Minor Cleanup
URL: https://github.com/apache/commons-geometry/pull/17
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a f
darkma773r opened a new pull request #18: Geometry 31: Standardize Method Names
URL: https://github.com/apache/commons-geometry/pull/18
Standardizing method names with commons-numbers and shortening names where
possible. This also includes some minor cleanup.
--
asfgit closed pull request #18: Geometry 31: Standardize Method Names
URL: https://github.com/apache/commons-geometry/pull/18
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pu
aremily opened a new pull request #92: OpenSSL 1.1.0 updates with backward
compatibility for OpenSSL 1.0.2
URL: https://github.com/apache/commons-crypto/pull/92
Commons Crypto Dev Team,
Please consider this submission for incorporation into the master. I
believe it meets the criter
aremily commented on issue #92: OpenSSL 1.1.0 updates with backward
compatibility for OpenSSL 1.0.2
URL: https://github.com/apache/commons-crypto/pull/92#issuecomment-449669500
The CI build is on Ubuntu 14.04 with OpenSSL 1.0.1. I had to loosen the
version checking to support the 1.0.1 ve
coveralls commented on issue #92: OpenSSL 1.1.0 updates with backward
compatibility for OpenSSL 1.0.2 and 1.0.1
URL: https://github.com/apache/commons-crypto/pull/92#issuecomment-449676652
[](https://coveralls.io/builds/2078
jvz opened a new pull request #72: [IO-596] Add DeleteFiles utility class
URL: https://github.com/apache/commons-io/pull/72
This class provides configurable strategies to delete files and directories.
Signed-off-by: Matt Sicker
@reviewbybees @garydgregory @jeffret-b
-
jvz commented on issue #72: [IO-596] Add DeleteFiles utility class
URL: https://github.com/apache/commons-io/pull/72#issuecomment-450040762
Note that the build is failing as there is currently an existing unit test
that tests a non-existent method.
-
asciborek commented on a change in pull request #72: [IO-596] Add DeleteFiles
utility class
URL: https://github.com/apache/commons-io/pull/72#discussion_r244072727
##
File path: src/main/java/org/apache/commons/io/DeleteFiles.java
##
@@ -0,0 +1,339 @@
+/*
+ * Licensed to t
jvz commented on a change in pull request #72: [IO-596] Add DeleteFiles utility
class
URL: https://github.com/apache/commons-io/pull/72#discussion_r244167531
##
File path: src/main/java/org/apache/commons/io/DeleteFiles.java
##
@@ -0,0 +1,339 @@
+/*
+ * Licensed to the Apa
paroxayte opened a new pull request #28: add support priority based iteration
over options supplied to CommandLine
URL: https://github.com/apache/commons-cli/pull/28
CommandLine stores the options parsed as ArrayList. I changed this to what
is essentially an iterable priority queue. I twea
ossdev07 commented on issue #92: OpenSSL 1.1.0 updates with backward
compatibility for OpenSSL 1.0.2 and 1.0.1
URL: https://github.com/apache/commons-crypto/pull/92#issuecomment-450281751
can any maintainer have a look on this PR ..
-
emopers opened a new pull request #28: Close ObjectOutputStream before calling
toByteArray on underlying ByteArrayOutputStream
URL: https://github.com/apache/commons-dbcp/pull/28
When an `ObjectOutputStream` instance wraps an underlying
`ByteArrayOutputStream` instance,
it is recommende
ajs6f opened a new pull request #53: COMMONSRDF-80: Bumping Jena version 3.5.0
=> 3.9.0
URL: https://github.com/apache/commons-rdf/pull/53
This is an automated message from the Apache Git Service.
To respond to the message,
acoburn commented on issue #53: COMMONSRDF-80: Bumping Jena version 3.5.0 =>
3.9.0
URL: https://github.com/apache/commons-rdf/pull/53#issuecomment-450525975
The jena dependency is currently tied to the `jena-osgi` artifact. I think
it would be much better to set the dependency to `jena-arq
kinow opened a new pull request #65: Fix simple Checkstyle and PMD issues
introduced in 4.3
URL: https://github.com/apache/commons-collections/pull/65
Fixes new issues found while voting on 4.3 RC2.
Re-created site locally to confirm that the issues are gone. All tests
passing OK.
ajs6f edited a comment on issue #53: COMMONSRDF-80: Bumping Jena version 3.5.0
=> 3.9.0
URL: https://github.com/apache/commons-rdf/pull/53#issuecomment-450557976
As another Jena committer, I'd be happier with that too. Thoughts? @stain?
@wikier? Others?
---
ajs6f commented on issue #53: COMMONSRDF-80: Bumping Jena version 3.5.0 => 3.9.0
URL: https://github.com/apache/commons-rdf/pull/53#issuecomment-450557976
As another Jena committer, I'd be happier with that too. Thoughts? @stain ?
@wikier? Others?
--
saschaszott opened a new pull request #100: TEXT-104: Jaro Winkler Distance
refers to similarity
URL: https://github.com/apache/commons-text/pull/100
Provide class `JaroWinklerSimilarity` to compute JW similarity (reuses
protected methods of `JaroWinklerDistance`). Changed the implementati
saschaszott commented on issue #100: TEXT-104: Jaro Winkler Distance refers to
similarity
URL: https://github.com/apache/commons-text/pull/100#issuecomment-450560249
Travis is complaining about two changes breaking downward compatibility:
* field `INDEX_NOT_FOUND` was removed (this f
kinow opened a new pull request #39: IMAGING-219: prevent infinite loop when
decompressing RGBE input file
URL: https://github.com/apache/commons-imaging/pull/39
The `decompress` method has an input stream. It compares if the value
returned by `.read()` is greater than 128, otherwise tries
kinow opened a new pull request #40: IMAGING-220: replace while by if in the
JPEG decoder extend method
URL: https://github.com/apache/commons-imaging/pull/40
Looking at the specification and other implementations (see JIRA ticket for
links), it appears to me that the `while` in the `exten
vanzin commented on a change in pull request #92: OpenSSL 1.1.0 updates with
backward compatibility for OpenSSL 1.0.2 and 1.0.1
URL: https://github.com/apache/commons-crypto/pull/92#discussion_r244819839
##
File path: src/main/native/org/apache/commons/crypto/OpenSslInfoNative.c
##
vanzin commented on a change in pull request #92: OpenSSL 1.1.0 updates with
backward compatibility for OpenSSL 1.0.2 and 1.0.1
URL: https://github.com/apache/commons-crypto/pull/92#discussion_r244811499
##
File path: src/main/java/org/apache/commons/crypto/jna/OpenSsl102NativeJna.j
vanzin commented on a change in pull request #92: OpenSSL 1.1.0 updates with
backward compatibility for OpenSSL 1.0.2 and 1.0.1
URL: https://github.com/apache/commons-crypto/pull/92#discussion_r244817116
##
File path: src/main/java/org/apache/commons/crypto/jna/OpenSsl110NativeJna.j
vanzin commented on a change in pull request #92: OpenSSL 1.1.0 updates with
backward compatibility for OpenSSL 1.0.2 and 1.0.1
URL: https://github.com/apache/commons-crypto/pull/92#discussion_r244810868
##
File path: src/main/java/org/apache/commons/crypto/OpenSslInfoNative.java
#
vanzin commented on a change in pull request #92: OpenSSL 1.1.0 updates with
backward compatibility for OpenSSL 1.0.2 and 1.0.1
URL: https://github.com/apache/commons-crypto/pull/92#discussion_r244810433
##
File path: Makefile.common
##
@@ -179,11 +179,11 @@ Mac-x86_LIBNAM
vanzin commented on a change in pull request #92: OpenSSL 1.1.0 updates with
backward compatibility for OpenSSL 1.0.2 and 1.0.1
URL: https://github.com/apache/commons-crypto/pull/92#discussion_r244810053
##
File path: .gitignore
##
@@ -1,37 +0,0 @@
-*~
Review comment:
vanzin commented on a change in pull request #92: OpenSSL 1.1.0 updates with
backward compatibility for OpenSSL 1.0.2 and 1.0.1
URL: https://github.com/apache/commons-crypto/pull/92#discussion_r244810551
##
File path: pom.xml
##
@@ -1,33 +1,29 @@
-
-http://maven.apache.o
vanzin commented on a change in pull request #92: OpenSSL 1.1.0 updates with
backward compatibility for OpenSSL 1.0.2 and 1.0.1
URL: https://github.com/apache/commons-crypto/pull/92#discussion_r244819798
##
File path: src/main/native/org/apache/commons/crypto/OpenSslInfoNative.c
##
vanzin commented on a change in pull request #92: OpenSSL 1.1.0 updates with
backward compatibility for OpenSSL 1.0.2 and 1.0.1
URL: https://github.com/apache/commons-crypto/pull/92#discussion_r244818921
##
File path: src/main/native/org/apache/commons/crypto/OpenSslInfoNative.c
##
vanzin commented on a change in pull request #92: OpenSSL 1.1.0 updates with
backward compatibility for OpenSSL 1.0.2 and 1.0.1
URL: https://github.com/apache/commons-crypto/pull/92#discussion_r244817093
##
File path: src/main/java/org/apache/commons/crypto/jna/OpenSsl110NativeJna.j
vanzin commented on a change in pull request #92: OpenSSL 1.1.0 updates with
backward compatibility for OpenSSL 1.0.2 and 1.0.1
URL: https://github.com/apache/commons-crypto/pull/92#discussion_r244818314
##
File path: src/main/java/org/apache/commons/crypto/jna/OpenSslNativeJna.java
vanzin commented on a change in pull request #92: OpenSSL 1.1.0 updates with
backward compatibility for OpenSSL 1.0.2 and 1.0.1
URL: https://github.com/apache/commons-crypto/pull/92#discussion_r244817688
##
File path:
src/main/java/org/apache/commons/crypto/jna/OpenSslJnaCryptoRand
vanzin commented on a change in pull request #92: OpenSSL 1.1.0 updates with
backward compatibility for OpenSSL 1.0.2 and 1.0.1
URL: https://github.com/apache/commons-crypto/pull/92#discussion_r244810727
##
File path: src/main/java/org/apache/commons/crypto/OpenSslInfoNative.java
#
vanzin commented on a change in pull request #92: OpenSSL 1.1.0 updates with
backward compatibility for OpenSSL 1.0.2 and 1.0.1
URL: https://github.com/apache/commons-crypto/pull/92#discussion_r244812689
##
File path: src/main/java/org/apache/commons/crypto/jna/OpenSsl102NativeJna.j
vanzin commented on a change in pull request #92: OpenSSL 1.1.0 updates with
backward compatibility for OpenSSL 1.0.2 and 1.0.1
URL: https://github.com/apache/commons-crypto/pull/92#discussion_r244817779
##
File path:
src/main/java/org/apache/commons/crypto/jna/OpenSslJnaCryptoRand
vanzin commented on a change in pull request #92: OpenSSL 1.1.0 updates with
backward compatibility for OpenSSL 1.0.2 and 1.0.1
URL: https://github.com/apache/commons-crypto/pull/92#discussion_r244816990
##
File path: src/main/java/org/apache/commons/crypto/jna/OpenSsl110NativeJna.j
vanzin commented on a change in pull request #92: OpenSSL 1.1.0 updates with
backward compatibility for OpenSSL 1.0.2 and 1.0.1
URL: https://github.com/apache/commons-crypto/pull/92#discussion_r244817494
##
File path:
src/main/java/org/apache/commons/crypto/jna/OpenSslJnaCryptoRand
vanzin commented on a change in pull request #92: OpenSSL 1.1.0 updates with
backward compatibility for OpenSSL 1.0.2 and 1.0.1
URL: https://github.com/apache/commons-crypto/pull/92#discussion_r244817423
##
File path: src/main/java/org/apache/commons/crypto/jna/OpenSslJnaCipher.java
vanzin commented on a change in pull request #92: OpenSSL 1.1.0 updates with
backward compatibility for OpenSSL 1.0.2 and 1.0.1
URL: https://github.com/apache/commons-crypto/pull/92#discussion_r244820275
##
File path: src/main/native/org/apache/commons/crypto/cipher/OpenSslNative.c
vanzin commented on a change in pull request #92: OpenSSL 1.1.0 updates with
backward compatibility for OpenSSL 1.0.2 and 1.0.1
URL: https://github.com/apache/commons-crypto/pull/92#discussion_r244817987
##
File path: src/main/java/org/apache/commons/crypto/jna/OpenSslNativeJna.java
vanzin commented on a change in pull request #92: OpenSSL 1.1.0 updates with
backward compatibility for OpenSSL 1.0.2 and 1.0.1
URL: https://github.com/apache/commons-crypto/pull/92#discussion_r244812522
##
File path: src/main/java/org/apache/commons/crypto/jna/OpenSsl102NativeJna.j
vanzin commented on a change in pull request #92: OpenSSL 1.1.0 updates with
backward compatibility for OpenSSL 1.0.2 and 1.0.1
URL: https://github.com/apache/commons-crypto/pull/92#discussion_r244817336
##
File path: src/main/java/org/apache/commons/crypto/jna/OpenSslJna.java
vanzin commented on a change in pull request #92: OpenSSL 1.1.0 updates with
backward compatibility for OpenSSL 1.0.2 and 1.0.1
URL: https://github.com/apache/commons-crypto/pull/92#discussion_r244812584
##
File path: src/main/java/org/apache/commons/crypto/jna/OpenSsl102NativeJna.j
vanzin commented on a change in pull request #92: OpenSSL 1.1.0 updates with
backward compatibility for OpenSSL 1.0.2 and 1.0.1
URL: https://github.com/apache/commons-crypto/pull/92#discussion_r244819457
##
File path: src/main/native/org/apache/commons/crypto/OpenSslInfoNative.c
##
vanzin commented on a change in pull request #92: OpenSSL 1.1.0 updates with
backward compatibility for OpenSSL 1.0.2 and 1.0.1
URL: https://github.com/apache/commons-crypto/pull/92#discussion_r244812371
##
File path: src/main/java/org/apache/commons/crypto/jna/OpenSsl102NativeJna.j
vanzin commented on a change in pull request #92: OpenSSL 1.1.0 updates with
backward compatibility for OpenSSL 1.0.2 and 1.0.1
URL: https://github.com/apache/commons-crypto/pull/92#discussion_r244818064
##
File path: src/main/java/org/apache/commons/crypto/jna/OpenSslNativeJna.java
vanzin commented on a change in pull request #92: OpenSSL 1.1.0 updates with
backward compatibility for OpenSSL 1.0.2 and 1.0.1
URL: https://github.com/apache/commons-crypto/pull/92#discussion_r244820498
##
File path: src/main/native/org/apache/commons/crypto/cipher/OpenSslNative.c
aremily commented on issue #92: OpenSSL 1.1.0 updates with backward
compatibility for OpenSSL 1.0.2 and 1.0.1
URL: https://github.com/apache/commons-crypto/pull/92#issuecomment-451248384
Thanks for the feedback. Let me think on it a bit more and I'll take it up
again once I've come up w
vanzin commented on issue #92: OpenSSL 1.1.0 updates with backward
compatibility for OpenSSL 1.0.2 and 1.0.1
URL: https://github.com/apache/commons-crypto/pull/92#issuecomment-451249633
It really should not be hard. The concept is the same you're using on the
JNA side: check things at runt
aremily commented on issue #92: OpenSSL 1.1.0 updates with backward
compatibility for OpenSSL 1.0.2 and 1.0.1
URL: https://github.com/apache/commons-crypto/pull/92#issuecomment-451253240
It's building the JNI library or libraries that I'll have to work out. I
don't routinely code in C,
vanzin commented on issue #92: OpenSSL 1.1.0 updates with backward
compatibility for OpenSSL 1.0.2 and 1.0.1
URL: https://github.com/apache/commons-crypto/pull/92#issuecomment-451254190
If you use runtime checks, you don't need to touch the build at all. The
same JNI library should work ev
1 - 100 of 394 matches
Mail list logo
