vanzin commented on a change in pull request #92: OpenSSL 1.1.0 updates with backward compatibility for OpenSSL 1.0.2 and 1.0.1 URL: https://github.com/apache/commons-crypto/pull/92#discussion_r244818921
########## File path: src/main/native/org/apache/commons/crypto/OpenSslInfoNative.c ########## @@ -39,38 +39,24 @@ #include "OpenSslInfoNative.h" #ifdef UNIX -static unsigned long (*dlsym_SSLeay) (void); -static char * (*dlsym_SSLeay_version) (int); +static unsigned long (*dlsym_OpenSSL_version_num) (void); +static char * (*dlsym_OpenSSL_version) (int); Review comment: nit: this function returns `const char *`. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
