[Text, Lang] Matching two CharSequence instances

2019-03-02 Thread Alex Herbert
I am helping with the PR for TEXT-126 to add to the similarity package. Part of the new algorithm requires identifying if two CharSequences are identical. Is there a utility in Text to do something like this: public static boolean CharSequenceUtils.equals(CharSequence, CharSequence); I cannot f

Re: [Text, Lang] Matching two CharSequence instances

2019-03-02 Thread Alex Herbert
’ll do a PR to fix that one. > > On Sat, Mar 2, 2019 at 11:53 AM Alex Herbert > wrote: > >> I am helping with the PR for TEXT-126 to add to the similarity package. >> >> Part of the new algorithm requires identifying if two CharSequences are >> identical. Is th

Re: [Text, Lang] Matching two CharSequence instances

2019-03-02 Thread Alex Herbert
the CharSequence interface and works only if inputting 2 > objects that support equals correctly, like String or StringBuilder. > > I’ve just has a look for .equals() in all of [text] and this is actually a > bug that is in the newly submitted JaroWinklerSimilarity too. > >

Re: [Text, Lang] Matching two CharSequence instances

2019-03-02 Thread Alex Herbert
rs (e.g. > GEORGIAN LETTER AN and GEORGIAN CAPITAL LETTER AN are false for equals and > equals ignore case). But this is an edge case that we can ignore for now I > believe. I’ve tested it locally and all units tests are fine. So I’ll PR when I have time. > CheersBruno > >

[Rng] Sonar 'bugs'

2019-03-03 Thread Alex Herbert
I noted that the Sonar job is no longer failing on Jenkins. Well done for fixing it. I looked at the report and it has two bugs for testing floating point equality using ‘==‘. These are not bugs. I have added unit tests to demonstrate that the math implemented in the samplers should work when u

Re: [numbers-fraction] Maven surefire plugin error

2019-03-04 Thread Alex Herbert
I just did a fresh clone of commons-numbers and it runs ‘mvn test’ ok. Apache Maven 3.5.0 (ff8f5e7444045639af65f6095c62210b5713f426; 2017-04-03T20:39:06+01:00) Maven home: /usr/local/Cellar/maven/3.5.0/libexec Java version: 1.8.0_131, vendor: Oracle Corporation Java home: /Library/Java/JavaVirtua

Re: [numbers-fraction] Maven surefire plugin error

2019-03-04 Thread Alex Herbert
> On 4 Mar 2019, at 23:10, Gilles Sadowski wrote: > > Hi. > > Le lun. 4 mars 2019 à 23:21, Eric Barnhill a écrit : >> >> I am getting a maven error for the surefire plugin, but don't see it listed >> as a dependency in numbers-fraction or numbers-core. I see it listed in >> numbers-parent, b

Re: [DRAFT][REPORT] Board report for March 2019

2019-03-06 Thread Alex Herbert
Hi Rob, I was added as a committer on 2019-01-31 (date of first commit). Regards, Alex Herbert > On 6 Mar 2019, at 13:51, thc...@gmail.com wrote: > > There are some typos: > weclomed > imporove > > Best regards. > > On 06/03/2019 13:28, Gary Gregory wro

[Rng] New XoShiRo generators

2019-03-06 Thread Alex Herbert
I would like to merge this PR introducing the new XoShiRo generators: https://github.com/apache/commons-rng/pull/20 Can I get a review to check that nothing is obviously bad. Thanks, Alex

Re: [Rng] New XoShiRo generators

2019-03-06 Thread Alex Herbert
> On 6 Mar 2019, at 16:22, Gilles Sadowski wrote: > > Hi Alex. > > Le mer. 6 mars 2019 à 16:50, Alex Herbert a écrit : >> >> I would like to merge this PR introducing the new XoShiRo generators: >> >> https://github.com/apache/commons-rng/pull/20 &g

Re: [Rng] New XoShiRo generators

2019-03-06 Thread Alex Herbert
> On 6 Mar 2019, at 17:13, Gilles Sadowski wrote: > > Le mer. 6 mars 2019 à 16:50, Alex Herbert a écrit : >> >> I would like to merge this PR introducing the new XoShiRo generators: >> >> https://github.com/apache/commons-rng/pull/20 >> <htt

Re: [Rng] New XoShiRo generators

2019-03-06 Thread Alex Herbert
> On 6 Mar 2019, at 17:11, Gilles Sadowski wrote: > > Do the two variants produce uncorrelated sequences? I will test this when I branch a new PR for just this code.

Re: [Rng] New XoShiRo generators

2019-03-06 Thread Alex Herbert
> On 6 Mar 2019, at 21:24, Gilles Sadowski wrote: > > Hello. > > Le mer. 6 mars 2019 à 21:49, Alex Herbert a écrit : >> >> >> >>> On 6 Mar 2019, at 17:11, Gilles Sadowski wrote: >>> >>> Do the two variants produce uncorrelat

Re: [Rng] New XoShiRo generators

2019-03-06 Thread Alex Herbert
> > On 6 Mar 2019, at 21:42, Alex Herbert wrote: > > > >> On 6 Mar 2019, at 21:24, Gilles Sadowski wrote: >> >> Hello. >> >> Le mer. 6 mars 2019 à 21:49, Alex Herbert a écrit >> : >>> >>> >>> >>>&g

Re: [Rng] New XoShiRo generators

2019-03-06 Thread Alex Herbert
> On 6 Mar 2019, at 22:57, Gilles Sadowski wrote: > >>> >>> However I will test if XorShift1024Star and XorShift1024StarPhi are >>> correlated just for completeness. >>> >> >> Did a test of 100 repeats of a correlation of 50 longs from the >> XorShift1024Star and XorShift1024StarPhi, new s

[Text] JaccardSimilarity

2019-03-07 Thread Alex Herbert
A quick question about the JaccardSimilarity class: Q. Why does it round the similarity to 2 decimal places? This is not documented. It is also done in the complimentary JaccardDistance class. Looking at the history in git it seems to have always been that way. First commit was 2016-11-27.

Re: [Text] JaccardSimilarity

2019-03-07 Thread Alex Herbert
for Text-155. So changing the test is simple. It’s just the decision on whether to do it. Alex > CheersBruno > >On Friday, 8 March 2019, 4:49:52 am NZDT, Alex Herbert > wrote: > > A quick question about the JaccardSimilarity class: > > Q. Why does it round the sim

Re: [Text] JaccardSimilarity

2019-03-07 Thread Alex Herbert
.7 (which from the looks of it > will have several bug fixes & improvements!). > CheersBruno I'll put the changes into a Jira and PR. Alex > > >On Friday, 8 March 2019, 10:54:32 am NZDT, Alex Herbert > wrote: > > Hi Bruno, > >> On 7 Mar 20

[Rng] Merge outstanding PRs for construction speed baseline

2019-03-08 Thread Alex Herbert
Hi, I'd like to start on improving the methods in rng-simple to create the RandomSource. There are a few PRs outstanding but I think the discussion on this list was that the new XoShiRo generators are OK. So I would like to merge the following PRs: RNG-82: Add XorShift1024StarPhi generator

Re: [apache/commons-text] TEXT-155: Add a generic IntersectionSimilarity measure (#109)

2019-03-09 Thread Alex Herbert
wrote: >> >> We should be a tad careful with our naming conventions here. In the >> combinatorics on words space, an “overlap” is a specific repeated pattern, >> namely cXcXc where c is a letter from an alphabet and X is string (allowed >> to be empty). >> &g

Re: [Rng] New XoShiRo generators

2019-03-12 Thread Alex Herbert
[Replying to the list ML.] FYI. I have set up a composite (XorShift1024Star ^ XorShift1024StarPhi) test using DieHarder to run overnight with 100 seeds. If this passes then I'll find more resources and run BigCrush with the composite. Alex On 12/03/2019 14:39, Alex Herbert wrote:

Re: [Rng] New XoShiRo generators

2019-03-12 Thread Alex Herbert
> On 12 Mar 2019, at 17:12, Gilles Sadowski wrote: > > [Replying to list.] > > Le mar. 12 mars 2019 à 15:39, Alex Herbert <mailto:alex.d.herb...@gmail.com>> a écrit : >> >> >> On 12/03/2019 15:33, Gilles Sadowski wrote: >> >> Hi Alex

Re: [Rng] Merge outstanding PRs for construction speed baseline

2019-03-12 Thread Alex Herbert
> On 12 Mar 2019, at 16:58, Gilles Sadowski wrote: > > [Replying to the ML.] > > Le mar. 12 mars 2019 à 13:00, Alex Herbert <mailto:alex.d.herb...@gmail.com>> a écrit : >> >> >> On 11/03/2019 23:54, Gilles Sadowski wrote: >>> Le v

Re: [Rng] New XoShiRo generators

2019-03-13 Thread Alex Herbert
On 13/03/2019 02:20, Gilles Sadowski wrote: Le mar. 12 mars 2019 à 22:34, Alex Herbert a écrit : On 12 Mar 2019, at 17:12, Gilles Sadowski wrote: [Replying to list.] Le mar. 12 mars 2019 à 15:39, Alex Herbert mailto:alex.d.herb...@gmail.com>> a écrit : On 12/03/2019 15:33,

[Rng] User Guide Quality section

2019-03-14 Thread Alex Herbert
I've just added a Jira task to add the new XorShiRo generaters to the user guide. I note that the order of the RNGs in the *Quality* section does not match the order of the RandomSource enum, nor is it alphabetical. The list order is defined in org.apache.commons.rng.examples.stress.Generator

Re: [Rng] New XoShiRo generators

2019-03-14 Thread Alex Herbert
On 13/03/2019 18:31, Gilles Sadowski wrote: Dieharder did eventually finish the first 8 runs. Perhaps the test took a long time to determine if it was a pass/fail since it was borderline. Anyway they all eventually failed that test. I tried the following: XorComposite: A composite of two rngs

Re: [Rng] New XoShiRo generators

2019-03-14 Thread Alex Herbert
Sorry, my earlier message was truncated. On 13/03/2019 18:31, Gilles Sadowski wrote: I ran: XorShiftXorComposite: XorComposite using XorShift1024Star + XorShift1024StarPhi with the same seed XorShiftSerialComposite: SerialComposite using XorShift1024Star + XorShift1024StarPhi with the same s

Re: [Rng] User Guide Quality section

2019-03-14 Thread Alex Herbert
> On 14 Mar 2019, at 18:22, Gilles Sadowski wrote: > > Hello. > > Le jeu. 14 mars 2019 à 12:58, Alex Herbert a écrit > : >> >> I've just added a Jira task to add the new XorShiRo generaters to the >> user guide. >> >> I note that th

Re: [Rng] New XoShiRo generators

2019-03-15 Thread Alex Herbert
> On 14 Mar 2019, at 14:10, Alex Herbert wrote: > > Sorry, my earlier message was truncated. > > On 13/03/2019 18:31, Gilles Sadowski wrote: >> >>> I ran: >>> >>> XorShiftXorComposite: XorComposite using XorShift1024S

Re: [Rng] Merge outstanding PRs for construction speed baseline

2019-03-15 Thread Alex Herbert
I think the summary of this thread on outstanding PRs is: > RNG-82: Add XorShift1024StarPhi generator > RNG-70: Add new XoShiRo generators Merge but: - Ensure those generators with more than one constructor build the same sequence if the seed data is the same. This is to satisfy package require

Re: [Rng] New XoShiRo generators

2019-03-15 Thread Alex Herbert
FYI. > I am going to update stdin2testu01.c so that it passes all the input bits to > TestU01 and try again. > > I’ve read some of the code and manual of TestU01 and the values that are > returned from the unif01_Gen->GetBits method (unsigned long) are assumed to > be 32-bit unsigned. So I thi

Re: [Rng] New XoShiRo generators

2019-03-15 Thread Alex Herbert
> On 15 Mar 2019, at 17:37, Gilles Sadowski wrote: > > Hi Alex. > > Le ven. 15 mars 2019 à 14:08, Alex Herbert a écrit > : >> >> FYI. >> >>> I am going to update stdin2testu01.c so that it passes all the input bits >>> to TestU01

Re: [Rng] New XoShiRo generators

2019-03-15 Thread Alex Herbert
PS. Did you try this test program to check the size of the unsigned long? > > > The c standard for long states that it can be 32-bits or more! So to check > what happens on my 64-bit test machine: > > #include > #include > #include > > int main(void){ > printf("sizeof(int) = %d\n", (in

Re: [Rng] New XoShiRo generators

2019-03-16 Thread Alex Herbert
> On 16 Mar 2019, at 02:54, Gilles Sadowski wrote: >> This is read by dieharder which directly reads from stdin. This worked to >> collect all the generated bits and the serial and xor composites failed the >> test suite. >> >> It is also read by the stdin2testu01.c program to pass to TestU01

Re: [Rng] New XoShiRo generators

2019-03-16 Thread Alex Herbert
> On 16 Mar 2019, at 23:10, Alex Herbert wrote: > > > >> On 16 Mar 2019, at 02:54, Gilles Sadowski > <mailto:gillese...@gmail.com>> wrote: >>> This is read by dieharder which directly reads from stdin. This worked to >>> collect all the

Re: [Rng] New XoShiRo generators

2019-03-18 Thread Alex Herbert
> On 18 Mar 2019, at 10:20, Gilles Sadowski wrote: > > Le dim. 17 mars 2019 à 01:01, Alex Herbert <mailto:alex.d.herb...@gmail.com>> a écrit : >> >> >> >>> On 16 Mar 2019, at 23:10, Alex Herbert >> <mailto:alex.d.herb...@gmail.com

Re: [Rng] New XoShiRo generators

2019-03-18 Thread Alex Herbert
On 18/03/2019 14:12, Gilles Sadowski wrote: Hi. [...] One actual issue is that we are testing long providers using the long to create 2 int values. Should we test using a series of the upper 32 bits and then a series of the lower 32 bits? Is that useful since the test now sees the integer

Re: [Rng] New XoShiRo generators

2019-03-18 Thread Alex Herbert
> On 18 Mar 2019, at 19:27, Gilles Sadowski wrote: > > Le lun. 18 mars 2019 à 16:49, Alex Herbert <mailto:alex.d.herb...@gmail.com>> a écrit : >> >> >> On 18/03/2019 14:12, Gilles Sadowski wrote: >>> Hi. >>> >>>>>> [..

Re: [Rng] New XoShiRo generators

2019-03-19 Thread Alex Herbert
> On 19 Mar 2019, at 10:35, Gilles Sadowski wrote: > >>> [...] So leave the testing to just ints and document on the user guide that is what we are testing. >>> >>> +1 >> >> OK. That seems simplest. >> >> Given all the stress tests will be rerun shall I go ahead and reorder the >>

Re: [Rng] New XoShiRo generators

2019-03-19 Thread Alex Herbert
On 19/03/2019 11:38, Gilles Sadowski wrote: Le mar. 19 mars 2019 à 10:26, Alex Herbert a écrit : On 19 Mar 2019, at 10:35, Gilles Sadowski wrote: [...] Given all the stress tests will be rerun shall I go ahead and reorder the existing files, user guide .apt file and the

Re: [Rng] New XoShiRo generators

2019-03-19 Thread Alex Herbert
Forwarded to mailing list. Forwarded Message Subject:Re: [Rng] New XoShiRo generators Date: Tue, 19 Mar 2019 16:20:23 + From: Alex Herbert To: Gilles Sadowski On 19/03/2019 15:24, Gilles Sadowski wrote: Hello. [...] Given all the stress tests will

Re: [Rng] New XoShiRo generators

2019-03-19 Thread Alex Herbert
> On 19 Mar 2019, at 15:24, Gilles Sadowski wrote: >> >> I am currently rerunning the dieharder test for the XorShift1024Star >> composites since that requires a little endian format on my machine. So >> far there are not as many failures when the byte order is reversed. >> >> Once that is don

Re: [Rng] New XoShiRo generators

2019-03-20 Thread Alex Herbert
On 20/03/2019 13:08, Gilles Sadowski wrote: - Perhaps there is another place for them? I am happy to not clutter the source repo and keep them somewhere for devs. But where? You tell me. Maybe in the examples-stress module they are OK as that one is not officially part of the library. Unles

Re: [Rng] New XoShiRo generators

2019-03-20 Thread Alex Herbert
On 20/03/2019 11:14, Gilles Sadowski wrote: I have updated the PR for the XorShift1024 variant to deprecate the old XOR_SHIFT_1024_S enum. Please take a look to see if the wording is OK: https://github.com/apache/commons-rng/pull/30/files#diff-630495e26d73fa22ada841dabde0ab47

Re: [Rng] New XoShiRo generators

2019-03-20 Thread Alex Herbert
On 20/03/2019 16:13, Gilles Sadowski wrote: Le mer. 20 mars 2019 à 15:04, Alex Herbert a écrit : On 20/03/2019 13:08, Gilles Sadowski wrote: - Perhaps there is another place for them? I am happy to not clutter the source repo and keep them somewhere for devs. But where? You tell me. Maybe

Re: [Rng] New XoShiRo generators

2019-03-20 Thread Alex Herbert
> On 20 Mar 2019, at 18:22, Gilles Sadowski wrote: > >>> [...] >>> Perhaps the "RandomStressTester" should be made more flexible >>> and, instead of a hard-coded "GeneratorsList", accept a list of "enum" >>> identifiers. e.g. a list (ASCII file) like: >>> MT 3 >>> MT_64 3 >>> SPLIT_MIX_64 3 >>>

Re: [Rng] New XoShiRo generators

2019-03-21 Thread Alex Herbert
On 21/03/2019 02:08, Gilles Sadowski wrote: undefined Le mer. 20 mars 2019 à 21:39, Alex Herbert a écrit : On 20 Mar 2019, at 18:22, Gilles Sadowski wrote: [...] Perhaps the "RandomStressTester" should be made more flexible and, instead of a hard-coded "GeneratorsList&quo

Re: [VOTE] Release Apache Commons BCEL 6.3.1 based on RC1

2019-03-21 Thread Alex Herbert
+1 (non-binding) (Note: A few Spotbugs errors should be addressed/looked at soon, see below). mvn -v Apache Maven 3.6.0 (97c98ec64a1fdfee7767ce5ffb20918da4f719f3; 2018-10-24T19:41:47+01:00) Maven home: /usr/local/apache-maven-3.6.0 Java version: 1.8.0_191, vendor: Oracle Corporation, runtime

Re: [Rng] New XoShiRo generators

2019-03-21 Thread Alex Herbert
On 21/03/2019 13:45, Gilles Sadowski wrote: Hello. [...] If the user forgets to supply one, the program outputs one, and stops; then the user reissues the command? Yes: > java -jar examples-stress.jar -h Print something helpful > java -jar examples-stress.jar --template Print a templ

Re: [Rng] New XoShiRo generators

2019-03-21 Thread Alex Herbert
On 21/03/2019 15:13, Gilles Sadowski wrote: [...] If the user forgets to supply one, the program outputs one, and stops; then the user reissues the command? Yes: > java -jar examples-stress.jar -h Print something helpful > java -jar examples-stress.jar --template Print a template ge

Re: GSoC 19: Information pertaining to 'Lagged Fibonacci Generators'

2019-03-23 Thread Alex Herbert
> On 23 Mar 2019, at 17:34, Gilles Sadowski wrote: > > Hi. > > I see that you use Java 11. > Can you try with a different version? > We only know that the build should work with Java 6, 7, 8, and 9. > > Actually, it would be a nice "micro-task" to figure out how to fix > that issue (confirmed

Re: GSoC 19: Information pertaining to 'Lagged Fibonacci Generators'

2019-03-24 Thread Alex Herbert
> On 24 Mar 2019, at 14:47, Gilles Sadowski wrote: > > Hi Abhishek. > > Overall it looks good to me (but I'm not used to laying out GSoC proposals > so it might be good to have additional comments). > > I've added a few remarks in the text (see below). > > Le dim. 24 mars 2019 à 13:09, Abhis

[Rng] PractRand

2019-03-24 Thread Alex Herbert
Has this testing suite been investigated: PractRand http://pracrand.sourceforge.net/ It may provide a useful alternative to Dieharder or TestU01. I supports direct calls to the test suite using an API or piped data from stdin. Alex

Re: GSoC 19: Information pertaining to 'Lagged Fibonacci Generators'

2019-03-24 Thread Alex Herbert
> On 24 Mar 2019, at 17:51, Abhishek Dhadwal wrote: > > > Dear Sir, > This all looks good. I would reemphasise that you should find a reference > implementation of any new generator so that you can run it to produce numbers > given a known seed. This can be used to test the Java version you

Re: [Rng] User Guide Quality section

2019-03-24 Thread Alex Herbert
> On 24 Mar 2019, at 23:57, Gilles Sadowski wrote: > >> [...] > > I think that we mostly agreed in another thread. > >> >> Summary of my proposals: >> >> - Keep the order in the user guide as is but move MT next to MT_64 >> - Auto generate the GeneratorsList from the RandomSource enum >> -

Re: [Rng] PractRand

2019-03-25 Thread Alex Herbert
On 25/03/2019 11:34, Gilles Sadowski wrote: JIRA report created: https://issues.apache.org/jira/projects/RNG/issues/RNG-86 This should be easy to run with the new command-line application for stress testing. It accepts stdin so can be run without modification as per dieharder. Alex

[Rng] JDK 11 javadoc support for JPMS modules

2019-03-25 Thread Alex Herbert
I managed to get the build working for the site on JDK 11. https://github.com/apache/commons-rng/pull/32 However left as-is it does not work for the java 9 modules that use JPMS due to the javadoc tool in JDK 11.0.2. Note: This works on the original JDK 11. The latest 11.0.2 introduced stric

Re: [commons-rng] 01/04: RNG-82: Add XorShift1024StarPhi generator

2019-03-25 Thread Alex Herbert
On 25/03/2019 13:13, Gilles Sadowski wrote: Hi. Nit-pick: Order of constructor arguments (see below). Wouldn't it be more consistent to put the seed first? [Cf. "TwoCmres" constructor.] Yes. Sorry I will fix master. Alex

[GSoC] Agile approach to project mentoring

2019-03-28 Thread Alex Herbert
The GSoC guidelines for students writing a proposal [1] is to use the guidelines or templates of the organization. It then states that certain elements will improve chances of a proposal including in Deliverables: "a brief, clear work breakdown structure with milestones and deadlines. ... star

Re: GSoC 19: Information pertaining to 'Lagged Fibonacci Generators'

2019-03-28 Thread Alex Herbert
Hi, The proposal is good. It sets out the areas you wish to work on and an initial timeframe. This will probably change due to the nature of discovery as your work proceeds but everyone understands this and the starting plan is sound. Here are some areas for revision: Qualify this statement:

[Rng] New stress test application

2019-04-03 Thread Alex Herbert
I have decided to demonstrate where I am with the stress test application. A small project to add command-line support using Picocli ballooned into a lot of new code. Here's a PR with the new code: https://github.com/apache/commons-rng/pull/34 Everything is still in the examples-stress module.

Re: [Rng] New stress test application

2019-04-04 Thread Alex Herbert
> On 4 Apr 2019, at 20:11, Gilles Sadowski wrote: > > Hi Alex. > > Le mer. 3 avr. 2019 à 17:55, Alex Herbert <mailto:alex.d.herb...@gmail.com>> a écrit : >> >> I have decided to demonstrate where I am with the stress test >> application. A small

Re: [all] Should we use MathJaX in Javadoc on all repos? (Was: Re: [jira] [Commented] (NUMBERS-58) Javadoc: Use MathJaX)

2019-04-05 Thread Alex Herbert
On 05/04/2019 09:27, sebb wrote: On Tue, 12 Mar 2019 at 12:28, Rob Tompkins wrote: For those unfamiliar with MathJaX, is the javascript mechanism for accommodating for LaTeX (the math typesetting language, written by Donald Knuth) in html. It could be convenient to use mathematical notation

Re: [all] Should we use MathJaX in Javadoc on all repos? (Was: Re: [jira] [Commented] (NUMBERS-58) Javadoc: Use MathJaX)

2019-04-05 Thread Alex Herbert
On 05/04/2019 12:06, Gilles Sadowski wrote: On 05/04/2019 09:27, sebb wrote: On Tue, 12 Mar 2019 at 12:28, Rob Tompkins wrote: For those unfamiliar with MathJaX, is the javascript mechanism for accommodating for LaTeX (the math typesetting language, written by Donald Knuth) in html. It coul

[rng] Split and Jump functions

2019-04-08 Thread Alex Herbert
This is a starter for a discussion on the split and jump functionality for a random generator. Split: To create a new instance of the generator that is deterministically based on the state of the current instance but the probability that the sequence generated by the new instance and the curr

Re: [rng] Split and Jump functions

2019-04-08 Thread Alex Herbert
Hi Gilles, You ask some good questions which I may have been vague about due to familiarity with the possibilities. I hope to clarify a bit below. On 08/04/2019 16:05, Gilles Sadowski wrote: Hi Alex. Le lun. 8 avr. 2019 à 14:36, Alex Herbert a écrit : This is a starter for a discussion on

Re: [rng] Split and Jump functions

2019-04-09 Thread Alex Herbert
08/04/2019 16:05, Gilles Sadowski wrote: Hi Alex. Le lun. 8 avr. 2019 à 14:36, Alex Herbert a écrit : This is a starter for a discussion on the split and jump functionality for a random generator. Split: To create a new instance of the generator that is deterministically based on the state o

Re: [rng] Split and Jump functions

2019-04-09 Thread Alex Herbert
On 09/04/2019 17:36, Gilles Sadowski wrote: Hello. Le mar. 9 avr. 2019 à 16:42, Alex Herbert a écrit : Hi Gilles, Lots of sensible discussion here. I'll just put all replies at the end. On 09/04/2019 13:28, Gilles Sadowski wrote: Hello. Hi Gilles, You ask some good questions wh

Re: [RNG] Re: [commons-rng] 02/02: Disable redundant JMH benchmarks and mark as deprecated.

2019-04-10 Thread Alex Herbert
On 10/04/2019 13:02, Gilles Sadowski wrote: Hello Alex. [...] commit 431a51b8211a40e5e8d9df0406563d4873eb4eb6 Author: aherbert AuthorDate: Wed Apr 10 11:01:05 2019 +0100 Disable redundant JMH benchmarks and mark as deprecated. Is there and advantage to keeping disabled code? [Usually,

[rng] nextInt(int) and nextLong(long) can be improved

2019-04-10 Thread Alex Herbert
The code for nextInt(int) checks the range number n is a power of two and if so it computes a fast solution:     return (int) ((n * (long) (nextInt() >>> 1)) >> 31); This scales a 31 bit positive number by a power of 2 (i.e. n) then discards bits. So this is effectively just a left shift follo

Re: [rng] nextInt(int) and nextLong(long) can be improved

2019-04-10 Thread Alex Herbert
On 10/04/2019 13:46, Alex Herbert wrote: The code for nextInt(int) checks the range number n is a power of two and if so it computes a fast solution:     return (int) ((n * (long) (nextInt() >>> 1)) >> 31); This scales a 31 bit positive number by a power of 2 (i.e. n) then di

Re: [rng] nextInt(int) and nextLong(long) can be improved

2019-04-10 Thread Alex Herbert
On 10/04/2019 15:59, Gilles Sadowski wrote: Hello. Le mer. 10 avr. 2019 à 15:22, Alex Herbert a écrit : On 10/04/2019 13:46, Alex Herbert wrote: The code for nextInt(int) checks the range number n is a power of two and if so it computes a fast solution: return (int) ((n * (long

Fwd: Re: [rng] Split and Jump functions

2019-04-10 Thread Alex Herbert
Resending to list. Forwarded Message Subject:Re: [rng] Split and Jump functions Date: Wed, 10 Apr 2019 18:00:54 +0100 From: Alex Herbert To: Gilles Sadowski On 10/04/2019 18:58, Gilles Sadowski wrote: Hi. [... long quote skipped where I think we largely

Re: [rng] Split and Jump functions

2019-04-10 Thread Alex Herbert
> On 10 Apr 2019, at 18:52, Gilles Sadowski wrote: > > Hi. > >> >> On 10/04/2019 18:58, Gilles Sadowski wrote: >>> Hi. >>> [... long quote skipped where I think we largely agree on the conclusions ...] So do we have a working idea to: - Add interface 'JumpableUnifo

Re: [rng] Information Pertaining to Running Benchmarks

2019-04-11 Thread Alex Herbert
Note: I have changed the subject line to prefix using [rng] since this is not related to [GSoC] but to the [rng] component. On 11/04/2019 08:15, Abhishek Dhadwal wrote: Dear Sir, I have applied for the Apache ICLA, and built the project using - mvn clean package I have already used maven to

Re: [rng] Split and Jump functions

2019-04-11 Thread Alex Herbert
On 11/04/2019 13:22, Gilles Sadowski wrote: [...] Not adding a dedicated method would mean everyone has to do this: JumpableUniformRandomProvider rng = (JumpableUniformRandomProvider) RandomSource.create(…) But adding a mirror methods: JumpableUniformRandomProvider RandomSource::createJump

[rng] upgrading commons parent 47 to 48

2019-04-14 Thread Alex Herbert
Is there anything in particular to look out for when upgrading the parent? Currently there are some version overrides that can be removed if updated to CP 48. I was just going to try it and inspect reports in a full site build. Alex

Re: [rng] Split and Jump functions

2019-04-14 Thread Alex Herbert
> On 14 Apr 2019, at 01:31, Gilles Sadowski wrote: > > Hello. > >> On 11/04/2019 13:22, Gilles Sadowski wrote: > [...] Not adding a dedicated method would mean everyone has to do this: JumpableUniformRandomProvider rng = (JumpableUniformRandomProvider) RandomSource.cr

Re: [rng] Split and Jump functions

2019-04-17 Thread Alex Herbert
On 17/04/2019 16:43, Gilles Sadowski wrote: Hello. Le lun. 15 avr. 2019 à 01:03, Alex Herbert a écrit : On 14 Apr 2019, at 01:31, Gilles Sadowski wrote: Hello. On 11/04/2019 13:22, Gilles Sadowski wrote: [...] Not adding a dedicated method would mean everyone has to do this

Re: [rng] Split and Jump functions

2019-04-18 Thread Alex Herbert
> On 18 Apr 2019, at 14:12, Gilles Sadowski wrote: > > Hello Alex. > [...] >> >> OK so this results in: >> >> /** >> * Some summary. >> */ >> public interface JumpableUniformRandomProvider extends >> UniformRandomProvider { >> /** >> * Creates a copy of the UniformRandomProv

Re: [rng] Split and Jump functions

2019-04-19 Thread Alex Herbert
> On 19 Apr 2019, at 15:30, Gilles Sadowski wrote: > > Le jeu. 18 avr. 2019 à 21:53, Alex Herbert <mailto:alex.d.herb...@gmail.com>> a écrit : >> >> >> >>> On 18 Apr 2019, at 14:12, Gilles Sadowski wrote: >>> >>>

Re: [rng] Split and Jump functions

2019-04-27 Thread Alex Herbert
I have created RNG-97 and RNG-98 for Jump and LongJump. Please take a look and comment. The documentation highlights the implementation detail that a jump or long jump creates a copy that is far ahead. The original generator is not effected. The use case is thus: rng1 = …; rng2 = rng1.jump();

Re: [rng] Split and Jump functions

2019-04-27 Thread Alex Herbert
> On 27 Apr 2019, at 14:49, Gilles Sadowski wrote: > > Hi. > > Le sam. 27 avr. 2019 à 15:05, Alex Herbert <mailto:alex.d.herb...@gmail.com>> a écrit : >> >> I have created RNG-97 and RNG-98 for Jump and LongJump. >> >> Please take a look and

Re: [rng] Split and Jump functions

2019-04-28 Thread Alex Herbert
> > -- > http://bernd.eckenfels.net > > > Von: Gilles Sadowski > Gesendet: Sonntag, April 28, 2019 12:34 AM > An: Commons Developers List > Betreff: Re: [rng] Split and Jump functions > > Hello. > >> >> >

Re: [rng] Split and Jump functions

2019-04-29 Thread Alex Herbert
On 28/04/2019 19:11, Gilles Sadowski wrote: Le dim. 28 avr. 2019 à 17:02, Alex Herbert a écrit : On 28 Apr 2019, at 00:59, Bernd Eckenfels wrote: Hello, Just a question, I am unclear on the terminology, is „jump“ (did I miss the discussion leading toot?) something invented here? It

Re: [rng] Split and Jump functions

2019-04-30 Thread Alex Herbert
On 29/04/2019 22:14, Gilles Sadowski wrote: Hello. Le lun. 29 avr. 2019 à 19:09, Alex Herbert a écrit : On 28/04/2019 19:11, Gilles Sadowski wrote: Le dim. 28 avr. 2019 à 17:02, Alex Herbert a écrit : On 28 Apr 2019, at 00:59, Bernd Eckenfels wrote: Hello, Just a question, I am

Re: [rng] Split and Jump functions

2019-05-01 Thread Alex Herbert
> On 1 May 2019, at 16:05, Gilles Sadowski wrote: > > Hi. > > Le mar. 30 avr. 2019 à 17:08, Alex Herbert <mailto:alex.d.herb...@gmail.com>> a écrit : >> >> On 29/04/2019 22:14, Gilles Sadowski wrote: >>> Hello. >>> >>> Le lun

Re: [All] Help with GitHub "support"

2019-05-02 Thread Alex Herbert
Hi Gilles, I saw the PR for Statistics and noted that it was a trivial change that may not be warranted, or at least not in the form provided. I'll make more time to watch PRs for those projects you mentioned. Alex On 02/05/2019 12:32, Bruno P. Kinoshita wrote: Commented on the two PRs li

Re: [rng] Split and Jump functions

2019-05-02 Thread Alex Herbert
> On 1 May 2019, at 23:15, Gilles Sadowski wrote: > > Hi. > >>> [...] >> >> So do we do: >> >> UniformRandomProvider restrict(JumpableUniformRandomProvider); >> JumpableUniformRandomProvider restrict(LongJumpableUniformRandomProvider); >> UniformRandomProvider restrict(RestorableUniformRand

Re: [rng] Split and Jump functions

2019-05-03 Thread Alex Herbert
On 03/05/2019 13:04, Gilles Sadowski wrote: Hello. Le jeu. 2 mai 2019 à 23:49, Alex Herbert a écrit : On 1 May 2019, at 23:15, Gilles Sadowski wrote: Hi. [...] So do we do: UniformRandomProvider restrict(JumpableUniformRandomProvider); JumpableUniformRandomProvider restrict

[rng] Copying samplers

2019-05-03 Thread Alex Herbert
Most of the samplers in the library have very small states that are easy to compute. Some have computations that are more expensive, such as the LargeMeanPoissonSampler or the DiscreteProbabilityCollectionSampler. However once the state is computed the only part of the state that changes is th

Re: [commons-parent] branch master updated: - Add properties commons.javadoc6.java.link through commons.javadoc12.java.link - Add properties commons.javadoc.javaee5.link through commons.javadoc.javaee

2019-05-04 Thread Alex Herbert
The javadoc9 link points to Java 8. > On 4 May 2019, at 14:56, ggreg...@apache.org wrote: > > This is an automated email from the ASF dual-hosted git repository. > > ggregory pushed a commit to branch master > in repository https://gitbox.apache.org/repos/asf/commons-parent.git > > > The fol

Re: [rng] Copying samplers

2019-05-04 Thread Alex Herbert
> On 4 May 2019, at 14:46, Gilles Sadowski wrote: > > Hello. > > Le ven. 3 mai 2019 à 16:57, Alex Herbert <mailto:alex.d.herb...@gmail.com>> a écrit : >> >> Most of the samplers in the library have very small states that are easy >> to compute. Some

Re: [rng] Copying samplers

2019-05-04 Thread Alex Herbert
> On 4 May 2019, at 22:34, Gilles Sadowski wrote: > > Hi. > > Le sam. 4 mai 2019 à 21:31, Alex Herbert a écrit : >> >> >> >>> On 4 May 2019, at 14:46, Gilles Sadowski wrote: >>> >>> Hello. >>> >>> Le ven.

Re: [commons-codec] branch master updated: Javadoc tweaks.

2019-05-05 Thread Alex Herbert
All comments indicate that the bit raised is index 0. This should be updated for each constant to use the appropriate index from 0-7: Mask with bit zero-based index [0-7] raised. > On 5 May 2019, at 22:21, ggreg...@apache.org wrote: > > This is an automated email from the ASF dual-hosted git r

Re: [commons-rng] branch master updated: Update pom.xml

2019-05-08 Thread Alex Herbert
> On 8 May 2019, at 23:34, Gilles Sadowski wrote: > > Le jeu. 9 mai 2019 à 00:25, a écrit : >> >> This is an automated email from the ASF dual-hosted git repository. >> >> aherbert pushed a commit to branch master >> in repository https://gitbox.apache.org/repos/asf/commons-rng.git >> >> >

Re: [rng] Information Pertaining to Running Benchmarks

2019-05-08 Thread Alex Herbert
> On 8 May 2019, at 20:02, Abhishek Dhadwal wrote: > > Dear Sir, > If you want to look at the Javadocs then you can build them locally from > the commons-rng-examples/examples-jmh directory by running: > > mvn javadoc:javadoc > > The output will be in: > > target/site/apidocs/index.html >

[rng] Utility for creating permutations of hex digits

2019-05-09 Thread Alex Herbert
The Middle Square Weyl Sequence (MSWS) generator uses an internal Weyl sequence [1] to create randomness. This is basically a linear increment added to a sum that will eventually wrap (due to overflow) to restart at the beginning. The MSWS paper recommends an increment with a high number of diff

Re: [rng] Utility for creating permutations of hex digits

2019-05-09 Thread Alex Herbert
> On 9 May 2019, at 12:58, Gilles Sadowski wrote: > > Hi. > > Le jeu. 9 mai 2019 à 13:31, Alex Herbert <mailto:alex.d.herb...@gmail.com>> a écrit : >> >> The Middle Square Weyl Sequence (MSWS) generator uses an internal Weyl >> sequence [1] to cre

Re: [rng] Copying samplers

2019-05-09 Thread Alex Herbert
On Sat, 4 May 2019 at 23:52, Alex Herbert wrote: > > > > On 4 May 2019, at 22:34, Gilles Sadowski wrote: > > > > Hi. > > > > Le sam. 4 mai 2019 à 21:31, Alex Herbert a > écrit : > >> > >> > >> > >>> On 4 May 2019,

  1   2   3   4   5   6   7   8   9   10   >