[MATH][NUMBERS] Method to convert unsigned long to BigInteger

2023-12-24 Thread sebb
Both Numbers and Statistics have implementations of BigInteger toUnsignedBigInteger(long treatedAsUnsigned) But these methods are in test classes. Seems to me it would be useful to provide a public version of the method, but where does it belong? Sebb --

Re: [MATH][NUMBERS] Method to convert unsigned long to BigInteger

2023-12-24 Thread Elliotte Rusty Harold
On Sun, Dec 24, 2023 at 9:59 AM sebb wrote: > > Both Numbers and Statistics have implementations of > > BigInteger toUnsignedBigInteger(long treatedAsUnsigned) > Can you describe a use case for this? That might help decide where it belongs. I wouldn't be surprised if this is more suitable for lan

Re: [MATH] MultiStartMultivariateOptimizerTest.testCircleFitting flaky test

2023-12-24 Thread Gilles Sadowski
Le sam. 23 déc. 2023 à 23:50, sebb a écrit : > > On Sat, 23 Dec 2023 at 15:44, Gilles Sadowski wrote: > > > > Hello. > > > > Le sam. 23 déc. 2023 à 16:30, sebb a écrit : > > > > > > The test MultiStartMultivariateOptimizerTest.testCircleFitting [1] > > > seems to be flaky. > > > > > > It often f

Re: [MATH][NUMBERS] Method to convert unsigned long to BigInteger

2023-12-24 Thread Alex Herbert
On Sun, 24 Dec 2023 at 11:45, Elliotte Rusty Harold wrote: > > On Sun, Dec 24, 2023 at 9:59 AM sebb wrote: > > > > Both Numbers and Statistics have implementations of > > > > BigInteger toUnsignedBigInteger(long treatedAsUnsigned) > > > > Can you describe a use case for this? That might help deci

Re: (commons-numbers) branch java8-simplify created (now 2f60d424)

2023-12-24 Thread Alex Herbert
On Sun, 24 Dec 2023 at 13:20, wrote: > > This is an automated email from the ASF dual-hosted git repository. > > sebb pushed a change to branch java8-simplify > in repository https://gitbox.apache.org/repos/asf/commons-numbers.git > > > at 2f60d424 Use Java 1.8 methods to simplify the Arithm

Re: (commons-numbers) 01/01: Use Java 1.8 methods to simplify the ArithmeticUtils methods remainderUnsigned and divideUnsigned (both int and long)

2023-12-24 Thread Alex Herbert
I would be wary of this simplification without a performance test. In the Numbers class the int methods do not use long arithmetic. The long methods do not use BigInteger. This is unlike those methods in my JDK 8 source code which do and are likely much slower. A quick check in JDK 21 finds this i

Re: [MATH][NUMBERS] Method to convert unsigned long to BigInteger

2023-12-24 Thread sebb
On Sun, 24 Dec 2023 at 13:16, Alex Herbert wrote: > > On Sun, 24 Dec 2023 at 11:45, Elliotte Rusty Harold > wrote: > > > > On Sun, Dec 24, 2023 at 9:59 AM sebb wrote: > > > > > > Both Numbers and Statistics have implementations of > > > > > > BigInteger toUnsignedBigInteger(long treatedAsUnsign

[IO][ALL?] PRs should NOT deploy snapshots

2023-12-24 Thread Gary Gregory
It seems that [IO] tries and fails to deploy snapshots for PRs. That should not happen, the deploying, that is. PR log: ... [INFO] --- maven-deploy-plugin:3.1.1:deploy (default-deploy) @ commons-io --- 189[INFO] 190[INFO] BU

[ALL] Issue with compiler plugin 3.12.0 (fixed in 3.12.1)

2023-12-24 Thread sebb
FTR, in case compiles fail with an unexpected error: There was a regression in 3.12.0: https://issues.apache.org/jira/browse/MCOMPILER-567 Should be fixed in 3.12.1, which has just been released. Sebb - To unsubscribe, e-mail:

Re: [MATH][NUMBERS] Method to convert unsigned long to BigInteger

2023-12-24 Thread Alex Herbert
On Sun, 24 Dec 2023 at 13:58, sebb wrote: > > On Sun, 24 Dec 2023 at 13:16, Alex Herbert wrote: > > > > On Sun, 24 Dec 2023 at 11:45, Elliotte Rusty Harold > > wrote: > > > > > > On Sun, Dec 24, 2023 at 9:59 AM sebb wrote: > > > > > > > > Both Numbers and Statistics have implementations of > >

Re: [IO][ALL?] PRs should NOT deploy snapshots

2023-12-24 Thread sebb
Oops; fixed On Sun, 24 Dec 2023 at 15:49, Gary Gregory wrote: > > It seems that [IO] tries and fails to deploy snapshots for PRs. That > should not happen, the deploying, that is. > > PR log: > ... > [INFO] --- maven-deploy-plugin:3.1.1:deploy (default-deploy) @ commons-io --- > 189[INFO] >

Re: [MATH][NUMBERS] Method to convert unsigned long to BigInteger

2023-12-24 Thread sebb
On Sun, 24 Dec 2023 at 16:14, Alex Herbert wrote: > > On Sun, 24 Dec 2023 at 13:58, sebb wrote: > > > > On Sun, 24 Dec 2023 at 13:16, Alex Herbert wrote: > > > > > > On Sun, 24 Dec 2023 at 11:45, Elliotte Rusty Harold > > > wrote: > > > > > > > > On Sun, Dec 24, 2023 at 9:59 AM sebb wrote: >

Re: [IO][ALL?] PRs should NOT deploy snapshots

2023-12-24 Thread Gary Gregory
TY Sebb! Gary On Sun, Dec 24, 2023 at 11:18 AM sebb wrote: > > Oops; fixed > > On Sun, 24 Dec 2023 at 15:49, Gary Gregory wrote: > > > > It seems that [IO] tries and fails to deploy snapshots for PRs. That > > should not happen, the deploying, that is. > > > > PR log: > > ... > > [INFO] --- mav

Re: [MATH][NUMBERS] Method to convert unsigned long to BigInteger

2023-12-24 Thread Alex Herbert
On Sun, 24 Dec 2023 at 16:31, sebb wrote: > > On Sun, 24 Dec 2023 at 16:14, Alex Herbert wrote: > > > > On Sun, 24 Dec 2023 at 13:58, sebb wrote: > > > > > > On Sun, 24 Dec 2023 at 13:16, Alex Herbert > > > wrote: > > > > > > > > On Sun, 24 Dec 2023 at 11:45, Elliotte Rusty Harold > > > > wr

Re: (commons-numbers) branch master updated: Simplify conversion of numbers to unsigned

2023-12-24 Thread sebb
On Sun, 24 Dec 2023 at 16:58, wrote: > > This is an automated email from the ASF dual-hosted git repository. > > aherbert pushed a commit to branch master > in repository https://gitbox.apache.org/repos/asf/commons-numbers.git > > > The following commit(s) were added to refs/heads/master by this p

Re: (commons-numbers) branch master updated: Simplify conversion of numbers to unsigned

2023-12-24 Thread Alex Herbert
On Sun, 24 Dec 2023 at 17:51, sebb wrote: > > On Sun, 24 Dec 2023 at 16:58, wrote: > > > > This is an automated email from the ASF dual-hosted git repository. > > > > aherbert pushed a commit to branch master > > in repository https://gitbox.apache.org/repos/asf/commons-numbers.git > > > > > > Th

[VOTE] Release Apache Commons FileUpload 2.0.0-M2 based on RC1

2023-12-24 Thread Gary Gregory
We have fixed a few bugs and added some enhancements since Apache Commons FileUpload 2.0.0-M1 was released, so I would like to release Apache Commons FileUpload 2.0.0-M2. Apache Commons FileUpload 2.0.0-M2 RC1 is available for review here: https://dist.apache.org/repos/dist/dev/commons/fileupl

Re: [VOTE] Release Apache Commons FileUpload 2.0.0-M2 based on RC1

2023-12-24 Thread Bruno Kinoshita
Building passing fine. Reports look good (checkstyle is duplicated? But still OK). Thanks! +1 Apache Maven 3.8.5 (3599d3414f046de2324203b78ddcf9b5e4388aa0) Maven home: /opt/apache-maven-3.8.5 Java version: 17.0.9, vendor: Private Build, runtime: /usr/lib/jvm/java-17-openjdk-amd64 Default locale: