[ANNOUNCE] Apache Commons Numbers Version 1.1 Released

2022-11-02 Thread Alex Herbert
The Apache Commons Team is pleased to announce the availability of version 1.1 of "Apache Commons Numbers". Apache Commons Numbers provides number types and utilities. Changes in this version include: New features: o NUMBERS-70: Add a user guide. o NUMBERS-190: Add a Bill of Materials (BOM) t

Re: [commons-geometry] branch master updated: Update commons-numbers 1.0 to 1.1

2022-11-02 Thread Gilles Sadowski
Hi Alex. Do I understand correctly that the change below may introduce dependencies on modules that are not actually used in the [Geometry] code? Regards, Gilles Le mer. 2 nov. 2022 à 12:21, a écrit : > > This is an automated email from the ASF dual-hosted git repository. > > aherbert pushed a

Re: [commons-geometry] branch master updated: Update commons-numbers 1.0 to 1.1

2022-11-02 Thread Alex Herbert
On Wed, 2 Nov 2022 at 11:31, Gilles Sadowski wrote: > > Hi Alex. > > Do I understand correctly that the change below may introduce dependencies > on modules that are not actually used in the [Geometry] code? > > Regards, > Gilles The git diff does not show that this change is in the dependencyMan

Re: [commons-geometry] branch master updated: Update commons-numbers 1.0 to 1.1

2022-11-02 Thread sebb
On Wed, 2 Nov 2022 at 11:44, Alex Herbert wrote: > > On Wed, 2 Nov 2022 at 11:31, Gilles Sadowski wrote: > > > > Hi Alex. > > > > Do I understand correctly that the change below may introduce dependencies > > on modules that are not actually used in the [Geometry] code? > > > > Regards, > > Gille

Re: [commons-geometry] branch master updated: Update commons-numbers 1.0 to 1.1

2022-11-02 Thread Alex Herbert
On Wed, 2 Nov 2022 at 11:54, sebb wrote: > > On Wed, 2 Nov 2022 at 11:44, Alex Herbert wrote: > > > > On Wed, 2 Nov 2022 at 11:31, Gilles Sadowski wrote: > > > > > > Hi Alex. > > > > > > Do I understand correctly that the change below may introduce dependencies > > > on modules that are not actu

Re: [VOTE] Release Apache Commons BCEL 6.6.1 based on RC2

2022-11-02 Thread Gary D. Gregory
pong? On 2022/11/01 17:16:57 "Gary D. Gregory" wrote: > ping :-) > > On 2022/10/29 16:35:28 Gary Gregory wrote: > > We have fixed a regression bug since Apache Commons BCEL 6.6.0 was > > released, so I would like to release Apache Commons BCEL 6.6.1. > > > > Apache Commons BCEL 6.6.1 RC2 is avai

Re: [VOTE] Release Apache Commons BCEL 6.6.1 based on RC2

2022-11-02 Thread Alex Herbert
Validated signatures using svn co https://dist.apache.org/repos/dist/dev/commons/bcel/6.6.1-RC2 cd 6.6.1-RC2/ chmod +x signature-validator.sh ./signature-validator.sh https://repository.apache.org/content/repositories/orgapachecommons-1605/org/apache/bcel/bcel/6.6.1/ Built from the source tar usi

Re: [VOTE] Release Apache Commons BCEL 6.6.1 based on RC2

2022-11-02 Thread Gary D. Gregory
Thank you for the review, my comments are inline below. On 2022/11/02 14:15:44 Alex Herbert wrote: > Validated signatures using > > svn co https://dist.apache.org/repos/dist/dev/commons/bcel/6.6.1-RC2 > cd 6.6.1-RC2/ > chmod +x signature-validator.sh > ./signature-validator.sh > https://repositor

Re: [VOTE] Release Apache Commons BCEL 6.6.1 based on RC2

2022-11-02 Thread Gary D. Gregory
Note that https://commons.apache.org/bcel redirects to https://commons.apache.org/proper/commons-bcel On 2022/11/02 14:15:44 Alex Herbert wrote: > Validated signatures using > > svn co https://dist.apache.org/repos/dist/dev/commons/bcel/6.6.1-RC2 > cd 6.6.1-RC2/ > chmod +x signature-validator.sh

Re: [VOTE] Release Apache Commons BCEL 6.6.1 based on RC2

2022-11-02 Thread Gary D. Gregory
I updated git master for consistency to use the URL that does not redirect. On 2022/11/02 14:42:05 "Gary D. Gregory" wrote: > Note that https://commons.apache.org/bcel redirects to > https://commons.apache.org/proper/commons-bcel > > On 2022/11/02 14:15:44 Alex Herbert wrote: > > Validated signa

Re: [VOTE] Release Apache Commons BCEL 6.6.1 based on RC2

2022-11-02 Thread Alex Herbert
On Wed, 2 Nov 2022 at 14:36, Gary D. Gregory wrote: > > JApiCmp > > > > New method: org.apache.bcel.verifier.PassVerifier.getMessageList() has > > no @Since tag and no documented @return tag. > > > > A recent change to remove all the initialisation in the inner class > > org.apache.bcel.generic.In

RE: [VOTE] Release Apache Commons BCEL 6.6.1 based on RC2

2022-11-02 Thread Mark Roberts
In the constructor of /src/main/java/org/apache/bcel/verifier/structurals/ExceptionHandlers.java - the 'computeIfAbsent' line is duplicated. Is this correct? Mark -Original Message- From: Gary D. Gregory [mailto:ggreg...@apache.org] Sent: Tuesday, November 1, 2022 10:17 AM To: dev@common

RE: [VOTE] Release Apache Commons BCEL 6.6.1 based on RC2

2022-11-02 Thread Gary D. Gregory
On 2022/11/02 16:41:30 Mark Roberts wrote: > In the constructor of > /src/main/java/org/apache/bcel/verifier/structurals/ExceptionHandlers.java - > the 'computeIfAbsent' line is duplicated. Is this correct? Good spot, luckily the semantics are the same (the key will be present on the 2nd invocat

RE: [VOTE] Release Apache Commons BCEL 6.6.1 based on RC2

2022-11-02 Thread Gary D. Gregory
My +1 Gary On 2022/11/02 18:58:26 "Gary D. Gregory" wrote: > On 2022/11/02 16:41:30 Mark Roberts wrote: > > In the constructor of > > /src/main/java/org/apache/bcel/verifier/structurals/ExceptionHandlers.java - > > the 'computeIfAbsent' line is duplicated. Is this correct? > > Good spot, luckil

Re: [VOTE] Release Apache Commons BCEL 6.6.1 based on RC2

2022-11-02 Thread Gary Gregory
This voting thread passes with the following +1 binding votes: - Bruno Kinoshita - Alex Herbert - Gary Gregory No other votes were cast. Gary On Wed, Nov 2, 2022 at 6:27 PM Gary D. Gregory wrote: > My +1 > > Gary > > On 2022/11/02 18:58:26 "Gary D. Gregory" wrote: > > On 2022/11/02 16:41:30 M

[VOTE][RESULT] Release Apache Commons BCEL 6.6.1 based on RC2

2022-11-02 Thread Gary Gregory
With a better subject. > This voting thread passes with the following +1 binding votes: > > - Bruno Kinoshita > - Alex Herbert > - Gary Gregory > > No other votes were cast. > > Gary > > On Wed, Nov 2, 2022 at 6:27 PM Gary D. Gregory > wrote: > >> My +1 >> >> Gary >> >> On 2022/11/02 18:58:26 "G