On Wed, 2 Nov 2022 at 14:36, Gary D. Gregory <ggreg...@apache.org> wrote:
> > JApiCmp
> >
> > New method: org.apache.bcel.verifier.PassVerifier.getMessageList() has
> > no @Since tag and no documented @return tag.
> >
> > A recent change to remove all the initialisation in the inner class
> > org.apache.bcel.generic.InstructionConstants$Clinit constructor has
> > removed the formally package-private constructor. The default
> > constructor is now public. This is not a breaking change but I do not
> > think it was intended to expose this. I think it should have been left
> > as:
> >
> > class Clinit {
> > Clinit() {
> > // Intentionally empty
> > }
> > }
>
> Good find indeed. Do you think this requires another release candidate since
> this new public item is in a deprecated class? And does nothing.
I don't think the new public constructor does any harm other than
making a BCEL novice (like me) wonder what that class is doing there
in the first place. I had to look at the change history to see why the
class was there and that its previous functionality is now delegated
to InstructionConst. Note: That new "class" has copied the javadoc
from the "interface" InstructionConstants, including the word
interface despite being a class, but did not copy the <p> tags.
Something to fix post release.
+1
Alex
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org
