Dear all,
I have an application where it would be useful to be able to get the
leading comments (ie. before the first record) from a CSV file.
I asked a question on StackOverflow[1] but I got no replies and as far as I
can see it's not possible.
I looked into implementing this myself and it appeare
Hi Peter,
I think not keeping comments may help with memory management in cases where
you have an enormous amount of comments, or maybe speed up processing if
you discard them? Not sure.
But in any case, if you already have the patch working, I'd suggest 1)
taking a look at the JIRA of CSV and se
Hi Bruno,
Thanks for the swift reply! I have created CSV-304. I attached a patch to
the ticket but I don't know how to submit a pull request, please could you
advise?
Peter
On Tue, 6 Sept 2022 at 11:37, Bruno Kinoshita wrote:
> Hi Peter,
>
> I think not keeping comments may help with memory mana
Please see
https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/proposing-changes-to-your-work-with-pull-requests/creating-a-pull-request
Gary
On Tue, Sep 6, 2022, 06:05 Peter Hull wrote:
> Hi Bruno,
> Thanks for the swift reply! I have created CSV-304. I attached a patch t
Hi Gary,
Thanks for that, I've done it now. I didn't really mean to ask "how" to
submit a pull request, more "where" to submit it, as the Apache page just
mentions a repo at gitbox.apache.org and the Contributing page describes
attaching a patch file derived from SVN. I assumed the github repo was
Hi Peter,
Yes, the GitHub repos are all mirrors, and the most convenient way to
collaborate IMO, say, compared to our "plain" gitbox.
Gary
On Tue, Sep 6, 2022, 07:37 Peter Hull wrote:
> Hi Gary,
> Thanks for that, I've done it now. I didn't really mean to ask "how" to
> submit a pull request,
Hello.
Le mar. 6 sept. 2022 à 16:37, Peter Hull a écrit :
>
> Hi Gary,
> Thanks for that, I've done it now. I didn't really mean to ask "how" to
> submit a pull request, more "where" to submit it, as the Apache page just
> mentions a repo at gitbox.apache.org and the Contributing page describes
>
On Tue, 6 Sept 2022 at 15:56, Gilles Sadowski wrote:
>
> About your patch: It is preferable to have a separate test method for
> each test case. If there is no better description, it is fine to append
> a "counter" to the "common" test name. i.e.
>
> Hi Gilles,
I have done this, partly, and ther
