Re: [crypto] Help Releasing new Commons Crypto

2020-04-15 Thread Geoffrey Blake
So, I built commons-crypto against SSL 1.0.2n on Ubuntu 18.04LTS and all the tests pass. The code coverage bumps to 72%, I'm guessing if I did Mac we'd see the 73% coverage seen from Travis CI. @Gary, what should a reasonable coverage target be? 73% is not great, but not sure how much higher thi

Re: [crypto] Help Releasing new Commons Crypto

2020-04-15 Thread Alex Remily
I've seen the expected exception error, but rarely and I've never been able to reproduce it. I'm surprised it's come up on Travis because it's only come up a few times for me in the hundreds of builds I've done. Maybe we log it as a bug just to document it, but like I said, I don't know how to re

Re: [crypto] Help Releasing new Commons Crypto

2020-04-15 Thread Gary Gregory
On Wed, Apr 15, 2020 at 7:01 PM Alex Remily wrote: > I've seen the expected exception error, but rarely and I've never been able > to reproduce it. I'm surprised it's come up on Travis because it's only > come up a few times for me in the hundreds of builds I've done. Maybe we > log it as a bug

Re: [crypto] Help Releasing new Commons Crypto

2020-04-15 Thread Gary Gregory
On Wed, Apr 15, 2020 at 5:46 PM Geoffrey Blake wrote: > So, I built commons-crypto against SSL 1.0.2n on Ubuntu 18.04LTS and > all the tests pass. The code coverage bumps to 72%, I'm guessing if I > did Mac we'd see the 73% coverage seen from Travis CI. > > @Gary, what should a reasonable covera