Looks like a good idea but wonder if it fits commons. I kind of see a lot
of modules already so maybe incubator?
Ps: if interesting I m happy to give
https://github.com/rmannibucau/rule-them-all and help integrating it with
junit5 too
Le 4 nov. 2017 05:45, "Bruno P. Kinoshita"
a écrit :
> +1 f
+1.
But when we want to support JUnit4, JUnit5 and AssertJ maybe we could call that
"Apache Commons Test" with three components.
Jan
> -Ursprüngliche Nachricht-
> Von: Romain Manni-Bucau [mailto:rmannibu...@gmail.com]
> Gesendet: Samstag, 4. November 2017 08:45
> An: Bruno P. Kinoshita;
GitHub user Abrasha opened a pull request:
https://github.com/apache/commons-text/pull/74
Use non-deprecated method.
@PascalSchumacher.
See:
- https://github.com/apache/commons-text/pull/69
-
https://github.com/apache/commons-text/commit/804e4599bd63e4bb14c90561371
Github user coveralls commented on the issue:
https://github.com/apache/commons-text/pull/74
[](https://coveralls.io/builds/14037270)
Coverage remained the same at 98.298% when pulling
**e241bd6d361391092c7ad3
Github user PascalSchumacher commented on the issue:
https://github.com/apache/commons-text/pull/74
Thanks! ð
---
-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-
GitHub user Abrasha opened a pull request:
https://github.com/apache/commons-text/pull/75
Minor refactorings
- remove unnecessary (un)boxing
- replace `for: add` with bulk add `Collections.addAll`
- replace iterator with `for each` where possible
You can merge this pull requ
Github user PascalSchumacher commented on the issue:
https://github.com/apache/commons-text/pull/75
Thanks! ð
It would be nice if you could fix the check-style violations, see:
https://travis-ci.org/apache/commons-text/jobs/297158450
Run `mvn checkstyle:check` (o
Github user Abrasha commented on the issue:
https://github.com/apache/commons-text/pull/75
Sure. Will be done in an hour)
---
-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-ma
Github user asfgit closed the pull request at:
https://github.com/apache/commons-text/pull/74
---
-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org
Github user PascalSchumacher commented on the issue:
https://github.com/apache/commons-text/pull/73
patch has some check-style violations, see:
https://travis-ci.org/apache/commons-text/jobs/294087452
---
-
To unsub
I guess you forgot to push, as I do not see this change?
-Pascal
Am 04.11.2017 um 00:27 schrieb Gary Gregory:
Done!
Gary
On Nov 3, 2017 12:04, "Stephen Colebourne" wrote:
You'd need https://github.com/apache/commons-lang/pull/304 too for Java 9
Stephen
On 3 November 2017 at 17:36, Gary G
Github user ben12 commented on the issue:
https://github.com/apache/commons-text/pull/73
I have corrected my patch https://github.com/kinow/commons-text/pull/1
It is my first pull request, so if I have understand the worlflow, kinow
must accept it to re-pull it here.
---
--
Github user coveralls commented on the issue:
https://github.com/apache/commons-text/pull/73
[](https://coveralls.io/builds/14037929)
Coverage increased (+0.1%) to 98.417% when pulling
**3554c40a09288ba8531321
Github user coveralls commented on the issue:
https://github.com/apache/commons-text/pull/73
[](https://coveralls.io/builds/14037929)
Coverage increased (+0.1%) to 98.417% when pulling
**3554c40a09288ba8531321
Github user kinow commented on the issue:
https://github.com/apache/commons-text/pull/73
Already done @ben12! Hope first pull request of many :-)
---
-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For a
On 03/11/17 23:11, Gary Gregory wrote:
> Hi All,
>
> I'd propose we start a new component called "Apache Commons JUnit".
-1 on the name. It is infringing.
"Apache Commons Tools for JUnit" would be fine. As would any similar
construction.
> The goal would be to gather useful and reusable code l
+1. Seems like a good plan.
> On Nov 4, 2017, at 3:44 AM, Romain Manni-Bucau wrote:
>
> Looks like a good idea but wonder if it fits commons. I kind of see a lot
> of modules already so maybe incubator?
>
> Ps: if interesting I m happy to give
> https://github.com/rmannibucau/rule-them-all and
Github user Abrasha commented on the issue:
https://github.com/apache/commons-text/pull/75
@PascalSchumacher done. Force pushed this PR.
---
-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional
Github user coveralls commented on the issue:
https://github.com/apache/commons-text/pull/75
[](https://coveralls.io/builds/14037992)
Coverage decreased (-0.003%) to 98.295% when pulling
**58f0f3e6a7f730eb6cb7
Github user asfgit closed the pull request at:
https://github.com/apache/commons-text/pull/75
---
-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org
GitHub user zhangminglei opened a pull request:
https://github.com/apache/commons-bcel/pull/19
[BCEL-298] Add some files to .gitignore
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/zhangminglei/commons-bcel BCEL-298
Alternativ
GitHub user zhangminglei opened a pull request:
https://github.com/apache/commons-bcel/pull/20
[BCEL-297] Fix NPE in BCELComparator concrete implementations.
This PR fix the potential NPE.
You can merge this pull request into a Git repository by running:
$ git pull https://gith
GitHub user Abrasha opened a pull request:
https://github.com/apache/commons-text/pull/76
Align sample in JavaDoc
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/Abrasha/commons-text
feature/align-samples-in-javadoc
Alternative
Github user coveralls commented on the issue:
https://github.com/apache/commons-text/pull/76
[](https://coveralls.io/builds/14038379)
Coverage remained the same at 98.295% when pulling
**3b3cb910e50f0f9d7d390b
GitHub user zhangminglei opened a pull request:
https://github.com/apache/commons-bcel/pull/21
[BCEL-299] Fix resolve symbol error
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/zhangminglei/commons-bcel BCEL-299
Alternatively
+1, there are also some bugfixes for that it would be nice to have a release
Am 03.11.2017 um 18:36 schrieb Gary Gregory:
Hi All:
I propose we release 3.7 principally to pick up
https://issues.apache.org/jira/browse/LANG-1365 to support those brave
souls trying out Java 10 EA.
Gary
---
Right now, I am just looking at what is in git master. Feel free to patch
away ;-)
Gary
On Sat, Nov 4, 2017 at 8:22 AM, Pascal Schumacher
wrote:
> +1, there are also some bugfixes for that it would be nice to have a
> release
>
> Am 03.11.2017 um 18:36 schrieb Gary Gregory:
>
>> Hi All:
>>
>> I
On Sat, Nov 4, 2017 at 5:35 AM, Mark Thomas wrote:
> On 03/11/17 23:11, Gary Gregory wrote:
> > Hi All,
> >
> > I'd propose we start a new component called "Apache Commons JUnit".
>
> -1 on the name. It is infringing.
>
> "Apache Commons Tools for JUnit" would be fine. As would any similar
> cons
I am assuming that JUnit 5 will be backward compatible with JUnit 4, I
might be wrong. I'd like to focus on a single dependency for now (JUnit)
and not do a multi-module project. If someone want to do the same for
TestNG, then have at it. KISS and small for 1.0.
Gary
On Fri, Nov 3, 2017 at 10:41
JUnit 5 is not backwards compatible (Package/Annotation-Names have
changed, Rules were replaced by a new extension model), but it can run
JUnit 3 and JUnit 4 Tests if you add an additional dependency. See
http://junit.org/junit5/docs/current/user-guide/#migrating-from-junit4
for details.
Am 0
Sorry if I haven't made myself clear. I was speaking of already commited
fixes (I'm not currently planning/working on any new ones.)
Am 04.11.2017 um 15:40 schrieb Gary Gregory:
Right now, I am just looking at what is in git master. Feel free to patch
away ;-)
Gary
On Sat, Nov 4, 2017 at 8:22
Github user asfgit closed the pull request at:
https://github.com/apache/commons-text/pull/76
---
-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org
Github user PascalSchumacher commented on the issue:
https://github.com/apache/commons-text/pull/76
Thanks!
---
-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@c
On Sat, Nov 4, 2017 at 9:32 AM, Pascal Schumacher
wrote:
> JUnit 5 is not backwards compatible (Package/Annotation-Names have
> changed, Rules were replaced by a new extension model), but it can run
> JUnit 3 and JUnit 4 Tests if you add an additional dependency. See
> http://junit.org/junit5/doc
How about "Apache Commons Testing"? -- H
On 4 November 2017 at 09:10, Gary Gregory wrote:
> On Sat, Nov 4, 2017 at 9:32 AM, Pascal Schumacher <
> pascalschumac...@gmx.net>
> wrote:
>
> > JUnit 5 is not backwards compatible (Package/Annotation-Names have
> > changed, Rules were replaced by a new
I like the idea (and prefer Commons Testing), for example a method to list all
non-daemon threads after a test run (to see there is no resource leak) can be
used independent of the Unit Test Framework.
Gruss
Bernd
--
http://bernd.eckenfels.net
From: Hasan Diwan
On 04.11.2017 17:58, Bernd Eckenfels wrote:
> I like the idea (and prefer Commons Testing), for example a method to list
> all non-daemon threads after a test run (to see there is no resource leak)
> can be used independent of the Unit Test Framework.
We already had a Commons Test project. It
+1 for a name like Commons Testing
On 4 November 2017 at 11:58, Bernd Eckenfels wrote:
> I like the idea (and prefer Commons Testing), for example a method to list
> all non-daemon threads after a test run (to see there is no resource leak)
> can be used independent of the Unit Test Framework.
>
So are you advocating for a multi-module project?
- commons-testing
- commons-testing-junit4
- commons-testing-junit5
?
Gary
On Sat, Nov 4, 2017 at 10:58 AM, Bernd Eckenfels
wrote:
> I like the idea (and prefer Commons Testing), for example a method to list
> all non-daemon threads after a t
Sergio,
Are you now able to place the RC (both bin AND src zip/gz files) on
https://dist.apache.org/repos/dist/dev/commons/rdf (which is under SVN)
instead of your home folder?
Gary
On Wed, Nov 1, 2017 at 9:46 PM, Sergio Fernández wrote:
> Hi,
>
> I am pleased to be calling this vote for relea
+ commons-testing-testng probably
Romain Manni-Bucau
@rmannibucau | Blog | Old Blog | Github | LinkedIn
2017-11-04 18:12 GMT+01:00 Gary Gregory :
> So are you advocating for a multi-module project?
>
> - commons-testing
> - commons-testing-junit4
> - commons-testing-junit5
>
> ?
>
> Gary
>
>
>
We have fixed a few bugs since Apache Commons Lang 3.6 was released, so I
would like to release Apache Commons Lang 3.7.
Apache Commons Lang 3.7 RC1 is available for review here:
https://dist.apache.org/repos/dist/dev/commons/lang at revision: 22853
Get it like this: svn co
https://dist.ap
Hello,
I would try to stick with a single artifact with optional dependencies to the
Frameworks supported. If the Project becomes too specific/cumbersome in Terms
of dependencies we might turn it into a Multi module build with a common and
Framework specific part.
But my comment was more abou
[ X ] +1 Release these artifacts
Build from 425d8085cfcaab5a78bf0632f9ae77b7e9127cf8 passing on
Apache Maven 3.3.9 (bb52d8502b132ec0a5a3f4c09453c07478323dc5;
2015-11-11T05:41:47+13:00)
Maven home: /opt/maven
Java version: 1.8.0_151, vendor: Oracle Corporation
Java home: /usr/lib/jvm/java-8-orac
44 matches
Mail list logo
