[GitHub] commons-text issue #44: [TEXT-80]: Fixed confusing StrLookup API

Github user britter commented on the issue: https://github.com/apache/commons-text/pull/44 @ameyjadiye the best would be to rebase your branch against master an dann do a force push. You can do it like this (if you have configured this repository as remote with name upstream):

[VOTE] Release Apache Commons Lang 3.6 based on RC3

Hello, we have fixed quite a few bugs and added some nice new features since Commons Lang 3.5 was released, so I would like to release Commons Lang 3.6 based on RC3. The following issues have been fixed since RC2: - Site build now works from source distribution - IBM JDK test failures have been

Re: [CANCEL][VOTE] Release Commons Fileupload 1.3.3 based on RC5

On 8 June 2017 at 01:36, Rob Tompkins wrote: > > >> On Jun 7, 2017, at 8:31 PM, Gary Gregory wrote: >> >>> On Wed, Jun 7, 2017 at 5:30 PM, Gary Gregory wrote: >>> >>> >>> On Wed, Jun 7, 2017 at 5:27 PM, Rob Tompkins wrote: > On Jun 7, 2017, at 8:20 PM, Gary Gregory

Re: [VOTE] Release Apache Commons Lang 3.6 based on RC3

[ X ] +1 Release these artifacts Build passing for Oracle JDK 7, Oracle JDK 8, and IBM JDK 8. Thanks a lot for preparing the release, Bruno From: Benedikt Ritter To: Commons Developers List Sent: Thursday, 8 June 2017 8:48 PM Subject: [VOTE] Release Apache Com

Re: NUMBERS-40: Review exception usage in package "o.a.c.numbers.gamma"

Hi. On Wed, 7 Jun 2017 17:00:46 -0500, Tharaka De Silva wrote: Hello everyone, I am new to the ASF community Welcome. and decided to grab something easy to attempt. I decided to take a shot at: https://issues.apache.org/jira/browse/NUMBERS-40. Easy to change is not always similar to easy

Re: [CANCEL][VOTE] Release Commons Fileupload 1.3.3 based on RC5

> On Jun 8, 2017, at 5:46 AM, sebb wrote: > > On 8 June 2017 at 01:36, Rob Tompkins > wrote: >> >> >>> On Jun 7, 2017, at 8:31 PM, Gary Gregory wrote: >>> On Wed, Jun 7, 2017 at 5:30 PM, Gary Gregory wrote: > On Wed, Jun 7, 2017 a

[GitHub] commons-text issue #44: [TEXT-80]: Fixed confusing StrLookup API

Github user chtompki commented on the issue: https://github.com/apache/commons-text/pull/44 @britter if I declare a class ```java package com.rt; import org.apache.commons.text.StrLookup; public class TextTester extends StrLookup { public String lo

[GitHub] commons-text issue #44: [TEXT-80]: Fixed confusing StrLookup API

Github user britter commented on the issue: https://github.com/apache/commons-text/pull/44 @chtompki this indicates a source incompatible release. Binary compatible means that you can swap out the 1.1 jar with the 1.2 jar without a recompile. Would that work? I can't recall o

[GitHub] commons-text issue #44: [TEXT-80]: Fixed confusing StrLookup API

Github user chtompki commented on the issue: https://github.com/apache/commons-text/pull/44 @britter - I would have to test it out, but fair point. It feels like we should always maintain source and binary backwards compatibility for minor version updates. But, if the policy

Re: [VOTE] Release Commons Fileupload 1.3.3 based on RC5

On 8 June 2017 at 01:20, Gary Gregory wrote: > The ASC does not seem to have a public key.: > > gpg --verify commons-fileupload-1.3.3-source-release.zip.asc That is not the recommended way to check a sig; you also need the target file $ gpg --verify downloaded_file.asc downloaded_file > gpg: as

Re: [VOTE] Release Commons Fileupload 1.3.3 based on RC5

> On Jun 8, 2017, at 8:09 AM, sebb wrote: > >> On 8 June 2017 at 01:20, Gary Gregory wrote: >> The ASC does not seem to have a public key.: >> >> gpg --verify commons-fileupload-1.3.3-source-release.zip.asc > > That is not the recommended way to check a sig; you also need the target file >

Re: [VOTE] Release Apache Commons Lang 3.6 based on RC3

[A Note, not a vote :) ] 1. Clirr is generally considered obsolete, as it hadn't been worked on for about ten years. japicmp is a good replacement, especially for report generation, and is used in other commons projects. 2. Are the "changes" to the values in CharEncoding really necessary[1] (Th

[RESULT][VOTE][LAZY] Migrate Apache Commons CLI to git

Hi, > Am 05.06.2017 um 13:20 schrieb Benedikt Ritter : > > Hi, > > I’d like to call a vote by lazy consensus for migrating the code base of > Apache Commons CLI to git. > > This vote is successful if nobody raises objections within the next 72 hours, > e.g. until June-08-2017, 13:30 MESZ. Th

Re: [VOTE] Release Commons Fileupload 1.3.3 based on RC5

Adding the appropriate key to the KEYS file after the fact should still work. It would have the same cryptographic reliability as being added beforehand as you can't exactly imitate a key. On 8 June 2017 at 07:17, Rob Tompkins wrote: > > > > On Jun 8, 2017, at 8:09 AM, sebb wrote: > > > >> On 8

[GitHub] commons-text issue #44: [TEXT-80]: Fixed confusing StrLookup API

Github user coveralls commented on the issue: https://github.com/apache/commons-text/pull/44 [](https://coveralls.io/builds/11887530) Coverage remained the same at 96.653% when pulling **fff3f43d27ed831986b366

Re: [LANG] Fix date related test failures on IBM JDKs (Was: Re: [CANCEL][VOTE] Release Apache Commons Lang 3.6 based on RC2)

Hi All/Gary/Benedikt/Bruno, May be i'm late in this discussion, just had thought around ibmjdk8 that can we add ibm-jdk8 in our travis.yml file for checking builds against it ? might be helpful to avoid problem we fixed with LANG-1337 I was looking at the way we can do that because the fact that

Re: [VOTE] Release Commons Fileupload 1.3.3 based on RC5

On Thu, Jun 8, 2017 at 5:17 AM, Rob Tompkins wrote: > > > > On Jun 8, 2017, at 8:09 AM, sebb wrote: > > > >> On 8 June 2017 at 01:20, Gary Gregory wrote: > >> The ASC does not seem to have a public key.: > >> > >> gpg --verify commons-fileupload-1.3.3-source-release.zip.asc > > > > That is not

Re: [VOTE] Release Commons Fileupload 1.3.3 based on RC5

+1 >From src zip: ASC, MD5, SHA1 OK. Build passes with 'mvn clean site'. Tests, CLIRR, RAT and reports OK. Used: Apache Maven 3.5.0 (ff8f5e7444045639af65f6095c62210b5713f426; 2017-04-03T12:39:06-07:00) Maven home: C:\Java\apache-maven-3.5.0\bin\.. Java version: 1.7.0_80, vendor: Oracle Corpora

Re: [VOTE] Release Apache Commons Lang 3.6 based on RC3

On Thu, Jun 8, 2017 at 5:38 AM, Simon Spero wrote: > [A Note, not a vote :) ] > > 1. Clirr is generally considered obsolete, as it hadn't been worked on for > about ten years. japicmp is a good replacement, especially for report > generation, and is used in other commons projects. > IIRC, we'v

Re: [VOTE] Release Commons Fileupload 1.3.3 based on RC5

> On Jun 8, 2017, at 11:02 AM, Matt Sicker wrote: > > Adding the appropriate key to the KEYS file after the fact should still > work. It would have the same cryptographic reliability as being added > beforehand as you can't exactly imitate a key. Yes (mine has been up there since February actu

Re: [VOTE] Release Apache Commons Lang 3.6 based on RC3

On 8 June 2017 at 17:19, Gary Gregory wrote: > On Thu, Jun 8, 2017 at 5:38 AM, Simon Spero wrote: > >> [A Note, not a vote :) ] >> >> 1. Clirr is generally considered obsolete, as it hadn't been worked on for >> about ten years. japicmp is a good replacement, especially for report >> generation

Re: [VOTE] Release Apache Commons Lang 3.6 based on RC3

+1. >From src zip: ASC, MD5, SHA1 OK. RAT and Clirr OK. Clirr does have the warnings discussed on this thread. Running 'mvn clean site' passes with: Apache Maven 3.5.0 (ff8f5e7444045639af65f6095c62210b5713f426; 2017-04-03T12:39:06-07:00) Maven home: C:\Java\apache-maven-3.5.0\bin\.. Java version:

Re: [VOTE] Release Apache Commons Lang 3.6 based on RC3

On Thu, Jun 8, 2017 at 9:57 AM, sebb wrote: > On 8 June 2017 at 17:19, Gary Gregory wrote: > > On Thu, Jun 8, 2017 at 5:38 AM, Simon Spero wrote: > > > >> [A Note, not a vote :) ] > >> > >> 1. Clirr is generally considered obsolete, as it hadn't been worked on > for > >> about ten years. japi

[Commons Wiki] Update of "MovingToGit" by BenediktRitter

Dear Wiki user, You have subscribed to a wiki page or wiki category on "Commons Wiki" for change notification. The "MovingToGit" page has been changed by BenediktRitter: https://wiki.apache.org/commons/MovingToGit?action=diff&rev1=4&rev2=5 Comment: Document how to request git repositories No

[Commons Wiki] Update of "MovingToGit" by BenediktRitter

Dear Wiki user, You have subscribed to a wiki page or wiki category on "Commons Wiki" for change notification. The "MovingToGit" page has been changed by BenediktRitter: https://wiki.apache.org/commons/MovingToGit?action=diff&rev1=5&rev2=6 Comment: Describe what to do in order to migrate code f

Re: [VOTE] Release Apache Commons Lang 3.6 based on RC3

+1 (non-binding) Signatures ok mvn clean site works in distro. > On Jun 8, 2017, at 1:09 PM, Gary Gregory wrote: > >> On Thu, Jun 8, 2017 at 9:57 AM, sebb wrote: >> >>> On 8 June 2017 at 17:19, Gary Gregory wrote: On Thu, Jun 8, 2017 at 5:38 AM, Simon Spero wrote: [A Note, n

[Commons Wiki] Update of "MovingToGit" by BenediktRitter

Dear Wiki user, You have subscribed to a wiki page or wiki category on "Commons Wiki" for change notification. The "MovingToGit" page has been changed by BenediktRitter: https://wiki.apache.org/commons/MovingToGit?action=diff&rev1=6&rev2=7 Comment: Better formatting == Migrate code to new

Re: [LANG] Fix date related test failures on IBM JDKs (Was: Re: [CANCEL][VOTE] Release Apache Commons Lang 3.6 based on RC2)

On Thu, Jun 8, 2017 at 8:55 AM, Amey Jadiye wrote: > Hi All/Gary/Benedikt/Bruno, > > May be i'm late in this discussion, just had thought around ibmjdk8 that > can we add ibm-jdk8 in our travis.yml file for checking builds against it ? > might be helpful to avoid problem we fixed with LANG-1337 >

[ANNOUNCE] Apache Commons CLI moved to git

Hello, the Apache Commons CLI component has been moved to git. The new source repository location is: https://git-wip-us.apache.org/repos/asf/commons-cli.git The old SVN source tree has been moved to an archive location at: https://svn.apache.org/repos/asf/commons/_moved_to_git/cli Have f

Re: [LANG] Fix date related test failures on IBM JDKs (Was: Re: [CANCEL][VOTE] Release Apache Commons Lang 3.6 based on RC2)

*Glad to setup this, I will submit PR soon.* *I'm taking commons-text as test mice, once it's successfully running we can replicate same setup to other components.* *Regards,* *Amey* On Thu, Jun 8, 2017 at 11:31 PM, Gary Gregory wrote: > On Thu, Jun 8, 2017 at 8:55 AM, Amey Jadiye wrote: > >

[GitHub] commons-text pull request #45: Added IBM Jdk8 build support to travis-ci con...

GitHub user ameyjadiye opened a pull request: https://github.com/apache/commons-text/pull/45 Added IBM Jdk8 build support to travis-ci configuration You can merge this pull request into a Git repository by running: $ git pull https://github.com/ameyjadiye/commons-text travis-i

Re: [ANNOUNCE] Apache Commons CLI moved to git

Good idea to announce! :-) Gary On Jun 8, 2017 11:19 AM, "Benedikt Ritter" wrote: > Hello, > > the Apache Commons CLI component has been moved to git. The new source > repository location is: > > https://git-wip-us.apache.org/repos/asf/commons-cli.git > > The old SVN source tree has been move

[GitHub] commons-text issue #45: Added IBM Jdk8 build support to travis-ci configurat...

Github user coveralls commented on the issue: https://github.com/apache/commons-text/pull/45 [](https://coveralls.io/builds/11892865) Coverage remained the same at 96.653% when pulling **90b5426b33476d091b19eb

[GitHub] commons-text issue #45: Added IBM Jdk8 build support to travis-ci configurat...

Github user coveralls commented on the issue: https://github.com/apache/commons-text/pull/45 [](https://coveralls.io/builds/11892865) Coverage remained the same at 96.653% when pulling **90b5426b33476d091b19eb

Re: [LANG] Fix date related test failures on IBM JDKs (Was: Re: [CANCEL][VOTE] Release Apache Commons Lang 3.6 based on RC2)

Hi Gary, I have raised PR[1] for this please review, I have already tested on forked repo [2], works like a charm, now each commit will be tested against. - openjdk7 - oraclejdk7 - oraclejdk8 - ibmjdk8 [1] https://github.com/apache/commons-text/pull/45 [2] https://travis-ci.org/ameyjadiye/commo

Re: [VOTE] Release Apache Commons Lang 3.6 based on RC3

On 8 June 2017 at 18:09, Gary Gregory wrote: > On Thu, Jun 8, 2017 at 9:57 AM, sebb wrote: > >> On 8 June 2017 at 17:19, Gary Gregory wrote: >> > On Thu, Jun 8, 2017 at 5:38 AM, Simon Spero wrote: >> > >> >> [A Note, not a vote :) ] >> >> >> >> 1. Clirr is generally considered obsolete, as it h

[GitHub] commons-cli pull request #10: [CLI-274] implement EXISTING_FILE_VALUE type h...

Github user asfgit closed the pull request at: https://github.com/apache/commons-cli/pull/10 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] commons-cli pull request #3: [CLI-253] Prevent "Unrecognized option: --null"...

Github user asfgit closed the pull request at: https://github.com/apache/commons-cli/pull/3 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is e

Re: NUMBERS-40: Review exception usage in package "o.a.c.numbers.gamma"

Thank you for the response! On Thu, Jun 8, 2017 at 5:13 AM, Gilles wrote: > Hi. > > On Wed, 7 Jun 2017 17:00:46 -0500, Tharaka De Silva wrote: > >> Hello everyone, >> >> I am new to the ASF community >> > > Welcome. Thank you! > > > and decided to grab something easy to >> attempt. I decided

Re: [VOTE] Release Apache Commons Lang 3.6 based on RC3

There is a one other compatibility issue, which can be seen in the attached code: import java.nio.charset.StandardCharsets; public class Weasel { private static final String US_ASCII = "US-ASCII"; private static final String UTF_8 = "UTF-8"; private static final String STANDARD_US_AS

Re: [VOTE] Release Apache Commons Lang 3.6 based on RC3

On Thu, Jun 8, 2017 at 6:29 PM, Simon Spero wrote: > There is a one other compatibility issue, which can be seen in the attached > code: > > import java.nio.charset.StandardCharsets; > > public class Weasel { > > private static final String US_ASCII = "US-ASCII"; > private static final St

Re: [VOTE] Release Apache Commons Lang 3.6 based on RC3

Hi, > Am 09.06.2017 um 03:34 schrieb Gary Gregory : > > On Thu, Jun 8, 2017 at 6:29 PM, Simon Spero wrote: > >> There is a one other compatibility issue, which can be seen in the attached >> code: >> >> import java.nio.charset.StandardCharsets; >> >> public class Weasel { >> >>private st

[CANCEL][VOTE] Release Apache Commons Lang 3.6 based on RC3

> Am 08.06.2017 um 10:48 schrieb Benedikt Ritter : > > Hello, > > we have fixed quite a few bugs and added some nice new features since Commons > Lang 3.5 was released, so I would like to release Commons Lang 3.6 based on > RC3. > The following issues have been fixed since RC2: > > - Site bui

[GitHub] commons-cli issue #10: [CLI-274] implement EXISTING_FILE_VALUE type handler

Github user britter commented on the issue: https://github.com/apache/commons-cli/pull/10 @schaumb we had a change in our Git infrastructure which caused the asfgit bot to close this PR. can you please reopen it? Thank you! --- If your project is set up for it, you can reply to this

[GitHub] commons-cli issue #3: [CLI-253] Prevent "Unrecognized option: --null" when h...

Github user britter commented on the issue: https://github.com/apache/commons-cli/pull/3 @msrb we hat a change in our git infrastructure. Can you please reopen this PR? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] commons-text pull request #45: Added IBM Jdk8 build support to travis-ci con...

Github user britter commented on a diff in the pull request: https://github.com/apache/commons-text/pull/45#discussion_r121055613 --- Diff: .travis.yml --- @@ -21,8 +21,15 @@ jdk: - oraclejdk7 - oraclejdk8 +services: + - docker + +before_install:

Re: [VOTE] Release Apache Commons Lang 3.6 based on RC3

On Fri, 9 Jun 2017 at 02:35, Gary Gregory wrote: > On Thu, Jun 8, 2017 at 6:29 PM, Simon Spero wrote: > > > There is a one other compatibility issue, which can be seen in the > attached > > code: > > > > import java.nio.charset.StandardCharsets; > > > > public class Weasel { > > > > private