Re: [lang] Use of "Review Patch"

2015-04-16 Thread Benedikt Ritter
Hello, I usually mark tickets as "Review Patch" when code has been suggested. I've used "Discuss" to indicate that I'm not sure whether we should dive into implementation at all. If a ticket has code but it looks like the wrong approach, I use both versions. Duncan: feel free to modify tickets the

Re: [lang] Use of "Review Patch"

2015-04-15 Thread Gary Gregory
I've never like using versions like this :-( Gary On Wed, Apr 15, 2015 at 1:19 PM, Paul Benedict wrote: > Odd way to use versions, imo. Sounds like "discussion" and "review patch" > and "patch needed" tags would be the better tool. > > > Cheers, > Paul > > On Wed, Apr 15, 2015 at 3:18 PM, Dunca

Re: [lang] Use of "Review Patch"

2015-04-15 Thread Duncan Jones
On 15 April 2015 at 21:19, Paul Benedict wrote: > Odd way to use versions, imo. Sounds like "discussion" and "review patch" > and "patch needed" tags would be the better tool. I completely agree. But this has how it's been done historically in Lang, so I wasn't trying to rock the boat too much wi

Re: [lang] Use of "Review Patch"

2015-04-15 Thread Paul Benedict
Odd way to use versions, imo. Sounds like "discussion" and "review patch" and "patch needed" tags would be the better tool. Cheers, Paul On Wed, Apr 15, 2015 at 3:18 PM, Duncan Jones wrote: > Hi folks, > > Currently the "Review Patch" fix version seems to be applied whenever > code has been su