Re: [VOTE] Release Commons Compress 1.2 Based on 1.2RC2

2011-07-30 Thread Henri Yandell
On Fri, Jul 29, 2011 at 8:02 AM, Gary Gregory wrote: > Do we require license headers on test fixtures? If not, +1. Not required. Hen - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail:

Re: [VOTE] Release Commons Compress 1.2 Based on 1.2RC2

2011-07-29 Thread Stefan Bodewig
just realized I haven't voted myself, yet. On 2011-07-28, Stefan Bodewig wrote: > Tag: > https://svn.apache.org/repos/asf/commons/proper/compress/tags/COMPRESS_1.2_RC2/ > Site: > http://people.apache.org/~bodewig/commons-compress-1.2RC2/site/ > Tarballs/ZIPs: > http://people.apache.org/~bode

Re: [VOTE] Release Commons Compress 1.2 Based on 1.2RC2

2011-07-29 Thread Phil Steitz
On 7/29/11 11:05 AM, Jörg Schaible wrote: > Stefan Bodewig wrote: > >> Tag: >> >> > https://svn.apache.org/repos/asf/commons/proper/compress/tags/COMPRESS_1.2_RC2/ >> Site: >> >> http://people.apache.org/~bodewig/commons-compress-1.2RC2/site/ >> >> Tarballs/ZIPs: >> >> http://people.apache.org/~bod

Re: [VOTE] Release Commons Compress 1.2 Based on 1.2RC2

2011-07-29 Thread Jörg Schaible
Stefan Bodewig wrote: > Tag: > > https://svn.apache.org/repos/asf/commons/proper/compress/tags/COMPRESS_1.2_RC2/ > > Site: > > http://people.apache.org/~bodewig/commons-compress-1.2RC2/site/ > > Tarballs/ZIPs: > > http://people.apache.org/~bodewig/commons-compress-1.2RC2/ > > Maven artifact

Re: [VOTE] Release Commons Compress 1.2 Based on 1.2RC2

2011-07-29 Thread Phil Steitz
On 7/29/11 9:36 AM, Jörg Schaible wrote: > Hi Phil, > > Phil Steitz wrote: > >> On 7/28/11 11:18 PM, Jörg Schaible wrote: >>> Jörg Schaible wrote: > [snip] > Use the java-1.4 profile (look into the commons parent) and define its home in your settings.xml:

Re: [VOTE] Release Commons Compress 1.2 Based on 1.2RC2

2011-07-29 Thread Jörg Schaible
Hi Phil, Phil Steitz wrote: > On 7/28/11 11:18 PM, Jörg Schaible wrote: >> Jörg Schaible wrote: [snip] >>> Use the java-1.4 profile (look into the commons parent) and define its >>> home in your settings.xml: >>> >>> >>> java-1.4 >>> >>>

Re: [VOTE] Release Commons Compress 1.2 Based on 1.2RC2

2011-07-29 Thread Phil Steitz
On 7/28/11 11:18 PM, Jörg Schaible wrote: > Jörg Schaible wrote: > >> Phil Steitz wrote: >> >>> On 7/27/11 9:47 PM, Stefan Bodewig wrote: Tag: > https://svn.apache.org/repos/asf/commons/proper/compress/tags/COMPRESS_1.2_RC2/ Site: http://people.apache.org/~bodewig/comm

Re: [VOTE] Release Commons Compress 1.2 Based on 1.2RC2

2011-07-29 Thread Gary Gregory
Do we require license headers on test fixtures? If not, +1. If so, this needs needs to be fixed (see RAT report): !? src/test/resources/archives/files.txt !? src/test/resources/test with spaces.txt !? src/test/resources/test.txt !? src/test/resources/test1.xml !? src/test

Re: [VOTE] Release Commons Compress 1.2 Based on 1.2RC2

2011-07-29 Thread Christian Grobmeier
+1 sigs, hashes are fine, site looks good and zip/gz etc unpack and run on mac os x10.6.8 with java 1.6.0_26 Thanks Stefan! On Thu, Jul 28, 2011 at 6:47 AM, Stefan Bodewig wrote: > Tag: > > https://svn.apache.org/repos/asf/commons/proper/compress/tags/COMPRESS_1.2_RC2/ > > Site: > > http://peop

Re: [VOTE] Release Commons Compress 1.2 Based on 1.2RC2

2011-07-28 Thread Jörg Schaible
Jörg Schaible wrote: > Phil Steitz wrote: > >> On 7/27/11 9:47 PM, Stefan Bodewig wrote: >>> Tag: >>> >>> > https://svn.apache.org/repos/asf/commons/proper/compress/tags/COMPRESS_1.2_RC2/ >>> >>> Site: >>> >>> http://people.apache.org/~bodewig/commons-compress-1.2RC2/site/ >>> >>> Tarballs/ZIPs

Re: [VOTE] Release Commons Compress 1.2 Based on 1.2RC2

2011-07-28 Thread Stefan Bodewig
On 2011-07-28, Oliver Heger wrote: > Minor nit: The RAT report on the site contains a bunch of files which > should not probably be there. When I build the site locally, it looks > cleaner. This - again - seems to be because I ran the site:stage-deploy with stagingDirectory set to src/site as the

Re: [VOTE] Release Commons Compress 1.2 Based on 1.2RC2

2011-07-28 Thread Stefan Bodewig
On 2011-07-29, Phil Steitz wrote: > I had to hack the pom to get it to work under jdk 1.4 (remove > assembly plugin, back rev surefire to 2.0) with maven 2.0.10; but > all code and tests compile and succeed for the jdks above. Given > that the maven build will not work for jdk 1.4, it might have

Re: [VOTE] Release Commons Compress 1.2 Based on 1.2RC2

2011-07-28 Thread Jörg Schaible
Phil Steitz wrote: > On 7/27/11 9:47 PM, Stefan Bodewig wrote: >> Tag: >> >> https://svn.apache.org/repos/asf/commons/proper/compress/tags/COMPRESS_1.2_RC2/ >> >> Site: >> >> http://people.apache.org/~bodewig/commons-compress-1.2RC2/site/ >> >> Tarballs/ZIPs: >> >> http://people.apache.org/~bodew

Re: [VOTE] Release Commons Compress 1.2 Based on 1.2RC2

2011-07-28 Thread Torsten Curdt
Tested on OSX 10.6.8 with java 1.6.0_26 and mvn 2.2.1 +1 from me cheers, Torsten - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org

Re: [VOTE] Release Commons Compress 1.2 Based on 1.2RC2

2011-07-28 Thread Phil Steitz
On 7/27/11 9:47 PM, Stefan Bodewig wrote: > Tag: > > https://svn.apache.org/repos/asf/commons/proper/compress/tags/COMPRESS_1.2_RC2/ > > Site: > > http://people.apache.org/~bodewig/commons-compress-1.2RC2/site/ > > Tarballs/ZIPs: > > http://people.apache.org/~bodewig/commons-compress-1.2RC2/ > > Ma

Re: [VOTE] Release Commons Compress 1.2 Based on 1.2RC2

2011-07-28 Thread Oliver Heger
Build works fine on Windows 7 with JDK 1.5 and 1.6. Artifacts and site look good. Minor nit: The RAT report on the site contains a bunch of files which should not probably be there. When I build the site locally, it looks cleaner. So +1. Oliver Am 28.07.2011 06:47, schrieb Stefan Bodewig: