Re: [VOTE] Release Apache Commons DbUtils 1.7 based on RC1

2017-07-16 Thread Carl Hall
Thank you very much for giving this RC a keen review. Being my first release, I appreciate the help in getting this right. I'll incorporate the suggested fixes (thanks, Gary!) to the release branch and prep RC2. On Sun, Jul 16, 2017 at 12:46 PM, Gary Gregory wrote: > Hi All, > > Thank you for

Re: [VOTE] Release Apache Commons DbUtils 1.7 based on RC1

2017-07-16 Thread Gary Gregory
Hi All, Thank you for performing RM duties for this release. -1: This RC introduces resource leaks as found by FindBugs which are not present in 1.6: org.apache.commons.dbutils.AbstractQueryRunner BugCategoryDetailsLinePriority org.apache.commons.dbutils.AbstractQueryRunner.prepareStatement(Conn

Re: [VOTE] Release Apache Commons DbUtils 1.7 based on RC1

2017-07-16 Thread Amey Jadiye
Build and Tests are passing clean, clirr and rat looks good. there are few of bugs in findbug and checkstyle report but they are non-blocker to release. hashes looks good. site looks fine. Here is my +1 to release (non-binding) Checked on :- Apache Maven 3.3.9 (bb52d8502b132ec0a5a3f4c09453c074783