Thank you very much for giving this RC a keen review.  Being my first
release, I appreciate the help in getting this right.  I'll incorporate the
suggested fixes (thanks, Gary!) to the release branch and prep RC2.

On Sun, Jul 16, 2017 at 12:46 PM, Gary Gregory <garydgreg...@gmail.com>
wrote:

> Hi All,
>
> Thank you for performing RM duties for this release.
>
> -1: This RC introduces resource leaks as found by FindBugs which are not
> present in 1.6:
>
> org.apache.commons.dbutils.AbstractQueryRunner
> BugCategoryDetailsLinePriority
> org.apache.commons.dbutils.AbstractQueryRunner.
> prepareStatement(Connection,
> String) may fail to clean up java.sql.Statement on checked exception
> EXPERIMENTAL OBL_UNSATISFIED_OBLIGATION_EXCEPTION_EDGE
> <http://findbugs.sourceforge.net/bugDescriptions.html#OBL_
> UNSATISFIED_OBLIGATION_EXCEPTION_EDGE>
> 207 Medium
> org.apache.commons.dbutils.AbstractQueryRunner.
> prepareStatement(Connection,
> String, int) may fail to clean up java.sql.Statement on checked exception
> EXPERIMENTAL OBL_UNSATISFIED_OBLIGATION_EXCEPTION_EDGE
> <http://findbugs.sourceforge.net/bugDescriptions.html#OBL_
> UNSATISFIED_OBLIGATION_EXCEPTION_EDGE>
> 238 Medium
>
> Gary
>
> These need to be fixed IMO, which I did in git master.
>
> Gary
>
> On Sat, Jul 15, 2017 at 10:16 PM, Carl Hall <carl.h...@gmail.com> wrote:
>
> > Hi,
> >
> > It's been almost 3 years to the day since we've had a DbUtils release.
> > We've fixed several important bugs and added some new features, so I
> would
> > like to release DbUtils 1.7.
> >
> > DbUtils 1.7 RC1 is available for review here:
> >    https://dist.apache.org/repos/dist/dev/commons/dbutils/
> DBUTILS_1_7_RC1/
> > (svn revision 20453)
> >
> > The tag is here:
> >
> > https://git-wip-us.apache.org/repos/asf?p=commons-dbutils.gi
> > t;a=tag;h=5cac6914f8c41c0a3a7daa524b581e2bb991475c
> >
> > Maven artifacts are here:
> >    https://repository.apache.org/content/repositories/orgap
> > achecommons-1253
> >
> > These are the Maven Artifacts and their hashes:
> >
> > commons-dbutils-1.7-javadoc.jar
> > (SHA: e22dd333bf755f89c0a12d8fe8e9f9791f4d584d)
> > commons-dbutils-1.7-javadoc.jar.asc
> > (SHA: dca6226d3474a3cdfbf0981cd77fd6eca98d423c)
> > commons-dbutils-1.7-javadoc.jar.md5
> > (SHA: 8b5918304c84a8bc3d91bff24450350c8a21cdd6)
> > commons-dbutils-1.7-javadoc.jar.sha1
> > (SHA: 7b652e50d72f1df3258e2b1def4811bc2c990414)
> > commons-dbutils-1.7-sources.jar
> > (SHA: b8046fc31bad05ceac0b239813490e7318cf6688)
> > commons-dbutils-1.7-sources.jar.asc
> > (SHA: b8254614b870b3e603649051622ff6e973c8877e)
> > commons-dbutils-1.7-sources.jar.md5
> > (SHA: 86874a2f66ba9c6990a364a156fbc96490221808)
> > commons-dbutils-1.7-sources.jar.sha1
> > (SHA: f055e9526b0d6452179025413ea2a232e8edaec5)
> > commons-dbutils-1.7-test-sources.jar
> > (SHA: 1fd6447ed463463b4f5a8bc22197716d3ec7e03c)
> > commons-dbutils-1.7-test-sources.jar.asc
> > (SHA: 46e7e98a6a08ae7656e71b0e1bfe95ff8fa7233b)
> > commons-dbutils-1.7-test-sources.jar.md5
> > (SHA: cc31e5341d12a0c0ac4b5ebe8449b2318033ec6a)
> > commons-dbutils-1.7-test-sources.jar.sha1
> > (SHA: 5a3623034caf69ade14962e1d68259c8781129d0)
> > commons-dbutils-1.7-tests.jar
> > (SHA: d0ecec11d46f69e4e4a13be5086b6e3ca40d83d6)
> > commons-dbutils-1.7-tests.jar.asc
> > (SHA: a3c72df421a5281a71b83dcb1c555775f11c2669)
> > commons-dbutils-1.7-tests.jar.md5
> > (SHA: efd95070aabcab80b6c1dccb598d9defea838964)
> > commons-dbutils-1.7-tests.jar.sha1
> > (SHA: 14663f80390bf0f1019e7b66579b79cb6abe5609)
> > commons-dbutils-1.7.jar
> > (SHA: c7e3e0fafc8960018f7a8604072ba8966021b8cd)
> > commons-dbutils-1.7.jar.asc
> > (SHA: f01c0750400d95a7c2bbe12745297f35cf3fde6c)
> > commons-dbutils-1.7.jar.md5
> > (SHA: 5ad0e7594828d40ba91f162fe7a9992f321cc6b9)
> > commons-dbutils-1.7.jar.sha1
> > (SHA: cc8f04f4ef3d9e651ebac7bdadf97c66f3598a19)
> > commons-dbutils-1.7.pom
> > (SHA: cc034176a8f7c78eda5aeec467756d87913d80ec)
> > commons-dbutils-1.7.pom.asc
> > (SHA: 436a8f12de783feb5c0a37eeb68bd93f19fc567d)
> > commons-dbutils-1.7.pom.md5
> > (SHA: 4b24897d385d2f6ba8c88dbe3d2c0e9afd89247a)
> > commons-dbutils-1.7.pom.sha1
> > (SHA: a3365107285401b8f37352ea013b54f4d052b7c2)
> >
> > Details of changes since 1.6 are in the release notes:
> >
> > https://dist.apache.org/repos/dist/dev/commons/dbutils/DBUTI
> > LS_1_7_RC1/RELEASE-NOTES.txt
> >   https://home.apache.org/~thecarlhall/dbutils-1.7-RC1/
> changes-report.html
> >
> > Site:
> >   https://home.apache.org/~thecarlhall/dbutils-1.7-RC1/
> >
> > Clirr Report (compared to 1.6):
> >   https://home.apache.org/~thecarlhall/dbutils-1.7-RC1/clirr-report.html
> >
> >   All changes are additions and do not represent any fundamental or
> > breaking changes in how to use the library, so not revving the version.
> >
> > RAT Report:
> >   https://home.apache.org/~thecarlhall/dbutils-1.7-RC1/rat-report.html
> >
> > KEYS:
> >   https://www.apache.org/dist/commons/KEYS
> >
> > Please review the release candidate and vote.
> > This vote will close no sooner that 72 hours from now,
> > i.e. sometime after 06:00 UTC 19-July-2017
> >
> >   [ ] +1 Release these artifacts
> >   [ ] +0 OK, but...
> >   [ ] -0 OK, but really should fix...
> >   [ ] -1 I oppose this release because...
> >
> > Thanks!
> >
> > Carl
> >
>

Reply via email to