Re: [crypto] The standard indentation is 4 spaces per indent

2016-04-29 Thread Gangumalla, Uma
>This is Commons, AND this is brand new code, so in my mind there is no "original" formatting style to respect. 4 spaces per indent like the rest of the project please. Remember that Commons is a SINGLE project. Hopefully we won't have to argue about too much about this... [Uma] Thanks Gary for you

RE: [crypto] The standard indentation is 4 spaces per indent

2016-04-28 Thread Chen, Haifeng
OK. Let's use 4 spaces indent. Thanks folks for sharing your opinion. -Original Message- From: Gary Gregory [mailto:garydgreg...@gmail.com] Sent: Friday, April 29, 2016 1:18 PM To: Commons Developers List Subject: Re: [crypto] The standard indentation is 4 spaces per indent Th

Re: [crypto] The standard indentation is 4 spaces per indent

2016-04-28 Thread Gary Gregory
--- > > From: Matt Sicker [mailto:boa...@gmail.com] > > Sent: Friday, April 29, 2016 9:00 AM > > To: Commons Developers List > > Subject: Re: [crypto] The standard indentation is 4 spaces per indent > > > > If you want to prevent mixed whitespace styles and whatnot, you c

Re: [crypto] The standard indentation is 4 spaces per indent

2016-04-28 Thread Dan Tran
ange impacts on how easy it is to see where/when changes > > >were made. > > >(This is more intrusive than a package name change at least as far as > > >history is concerned since every line may be changed) Also it ideally > > >needs to be co-ordinated with other

RE: [crypto] The standard indentation is 4 spaces per indent

2016-04-28 Thread Chen, Haifeng
] Sent: Friday, April 29, 2016 9:00 AM To: Commons Developers List Subject: Re: [crypto] The standard indentation is 4 spaces per indent If you want to prevent mixed whitespace styles and whatnot, you can use EditorConfig <http://editorconfig.org/>. On 28 April 2016 at 19:06, Gangumall

Re: [crypto] The standard indentation is 4 spaces per indent

2016-04-28 Thread Matt Sicker
sive than a package name change at least as far as > >history is concerned since every line may be changed) > >Also it ideally needs to be co-ordinated with other changes. > > > >So I think it would be wrong to commit the change without some prior > >notification. > >Thi

Re: [crypto] The standard indentation is 4 spaces per indent

2016-04-28 Thread Gangumalla, Uma
s. > >So I think it would be wrong to commit the change without some prior >notification. >This can either be a JIRA or agreement on the dev list. > >> Regards, >> Haifeng >> >> -Original Message- >> From: Gary Gregory [mailto:garydgreg...@gmail.com] &g

Re: [crypto] The standard indentation is 4 spaces per indent

2016-04-26 Thread sebb
> From: Gary Gregory [mailto:garydgreg...@gmail.com] > Sent: Tuesday, April 26, 2016 9:53 AM > To: Commons Developers List > Subject: RE: [crypto] The standard indentation is 4 spaces per indent > > Hi, > > Do you really want this level of Jira tracking? It seems over the

RE: [crypto] The standard indentation is 4 spaces per indent

2016-04-25 Thread Chen, Haifeng
ommons Developers List Subject: RE: [crypto] The standard indentation is 4 spaces per indent Hi, Do you really want this level of Jira tracking? It seems over the top to me. Is this process style for this component? In this case I would just do it and not Jira it. Then for detailed history, you just

RE: [crypto] The standard indentation is 4 spaces per indent

2016-04-25 Thread Gary Gregory
Hi, Do you really want this level of Jira tracking? It seems over the top to me. Is this process style for this component? In this case I would just do it and not Jira it. Then for detailed history, you just look at the commit history. Or are you just using Jira as a to-do list in the early days o

RE: [crypto] The standard indentation is 4 spaces per indent

2016-04-25 Thread Chen, Haifeng
>>In our coding guidelines [1] we say that "The standard indentation is 4 >>spaces per indent - but respect the number of spaces used by the original." >>The [crypto] Java code I've seen to far is all 2 spaces per indent. >>I think now is the time to do this, most IDEs can do a one-shot format of