Hi Gary, >> Do you really want this level of Jira tracking? It seems over the top to me. >> Is this process style for this component? In this case I would just do it >> and not Jira it. Then for detailed history, you just look at the commit >> history. Or are you just using Jira as a to-do list in the early days of >> this component in its new home in Apache Commons? As when we are working in Hadoop projects, we need a JIRA to start a work and communicate with the community. I am not sure whether Apache Commons allows commit of code without JIRA at this project stage. So I just try to do it in a safe way in a new family:) If Apache Commons folks thinks it's OK to do it without JIRA, I am OK with it.
Regards, Haifeng -----Original Message----- From: Gary Gregory [mailto:garydgreg...@gmail.com] Sent: Tuesday, April 26, 2016 9:53 AM To: Commons Developers List <dev@commons.apache.org> Subject: RE: [crypto] The standard indentation is 4 spaces per indent Hi, Do you really want this level of Jira tracking? It seems over the top to me. Is this process style for this component? In this case I would just do it and not Jira it. Then for detailed history, you just look at the commit history. Or are you just using Jira as a to-do list in the early days of this component in its new home in Apache Commons? Gary On Apr 25, 2016 6:47 PM, "Chen, Haifeng" <haifeng.c...@intel.com> wrote: >>In our coding guidelines [1] we say that "The standard indentation is >>4 spaces per indent - but respect the number of spaces used by the original." >>The [crypto] Java code I've seen to far is all 2 spaces per indent. >>I think now is the time to do this, most IDEs can do a one-shot format >>of a whole source tree. Good catch, Gary. The original code was based on Hadoop format style which is 2 spaces indent. I will fire a JIRA to format that. Thanks, Haifeng -----Original Message----- From: Gary Gregory [mailto:garydgreg...@gmail.com] Sent: Tuesday, April 26, 2016 6:25 AM To: Commons Developers List <dev@commons.apache.org> Subject: [crypto] The standard indentation is 4 spaces per indent Hi all, In our coding guidelines [1] we say that "The standard indentation is 4 spaces per indent - but respect the number of spaces used by the original." The [crypto] Java code I've seen to far is all 2 spaces per indent. I think now is the time to do this, most IDEs can do a one-shot format of a whole source tree. Gary [1] https://commons.apache.org/patches.html -- E-Mail: garydgreg...@gmail.com | ggreg...@apache.org Java Persistence with Hibernate, Second Edition <http://www.manning.com/bauer3/> JUnit in Action, Second Edition <http://www.manning.com/tahchiev/> Spring Batch in Action <http://www.manning.com/templier/> Blog: http://garygregory.wordpress.com Home: http://garygregory.com/ Tweet! http://twitter.com/GaryGregory
