Good idea. Another user commented something similar in the pull request, and I
believe Rob's suggestion was in the same direction.
Here's a PR that fixes clirr and deprecates a few things for 2.0:
https://github.com/apache/commons-text/pull/102
Thanks!
Bruno
On Wednesday, 20 February 201
Same for me. Just provided a solution to unblock 1.7, but happy to go with a
2.0 if we others agree too.
I haven't followed much around the Java modules. But this is a good opportunity
to fix anything required for the new Java versions.
CheersBruno
On Thursday, 21 February 2019, 10:59:11 am
Sounds reasonable. But I suppose the question we should ask ourselves is: do we
want a 1.7 or a 2.0? I’d be happy with either.
-Rob
> On Feb 20, 2019, at 4:56 PM, Bruno P. Kinoshita wrote:
>
>
> We have a few things ported from Lang that are deprecated and could be
> removed.
>
>
> But I
We have a few things ported from Lang that are deprecated and could be removed.
But I have reverted my change in this pull request:
https://github.com/apache/commons-text/pull/102
It introduces back the constant and the method removed, and also uses the old
code for the edit distance. But
Are we really ready for a 2.0? How much deprecated stuff do we carry?
I plan on taking a closer look at the jarod distance issue tonight or
tomorrow.
Gary
On Wed, Feb 20, 2019, 13:33 Pascal Schumacher I'm fine with either solution, but my preference would be to remove all
> deprecated stuff and
I'm fine with either solution, but my preference would be to remove all
deprecated stuff and release version 2.0.
Am 20.02.2019 um 08:42 schrieb Bruno P. Kinoshita:
Hi all,
Just finished merging a pull request to TEXT-104, where the JaroWinkler
distance was updated. The class was actually comp
> On Feb 20, 2019, at 5:42 AM, Benedikt Ritter wrote:
>
> Am Mi., 20. Feb. 2019 um 08:58 Uhr schrieb Bruno P. Kinoshita <
> ki...@apache.org>:
>
>> Hi all,
>> Just finished merging a pull request to TEXT-104, where the JaroWinkler
>> distance was updated. The class was actually computing a te
Am Mi., 20. Feb. 2019 um 08:58 Uhr schrieb Bruno P. Kinoshita <
ki...@apache.org>:
> Hi all,
> Just finished merging a pull request to TEXT-104, where the JaroWinkler
> distance was updated. The class was actually computing a text similarity
> score, not an edit distance. The user that contributed
Hi all,
Just finished merging a pull request to TEXT-104, where the JaroWinkler
distance was updated. The class was actually computing a text similarity score,
not an edit distance. The user that contributed did a great job moving the
logic into a separate class, then updating the method to retu
