Re: [pool] 1.5-RC1 available for review

2009-05-30 Thread sebb
On 30/05/2009, Phil Steitz wrote: > sebb wrote: > > > On 30/05/2009, Phil Steitz wrote: > > > > > > > sebb wrote: > > > > > > > > > > > > > On 29/05/2009, Phil Steitz wrote: > > > > > > > > > > > > > > > > > > > > > The files are here: > > > > > > > > > > > > > > > > > > > > > > http://people.ap

Re: [pool] 1.5-RC1 available for review

2009-05-30 Thread Phil Steitz
Luc Maisonobe wrote: Phil Steitz a écrit : sebb wrote: On 29/05/2009, Phil Steitz wrote: The files are here: http://people.apache.org/~psteitz/commons-pool-1.5-RC1/ findbugs filter and license-header.txt are missing from source archives. This is int

Re: [pool] 1.5-RC1 available for review

2009-05-30 Thread Luc Maisonobe
Phil Steitz a écrit : > sebb wrote: >> On 29/05/2009, Phil Steitz wrote: >> >>> The files are here: >>> http://people.apache.org/~psteitz/commons-pool-1.5-RC1/ >>> >> >> findbugs filter and license-header.txt are missing from source archives. >> > This is intended. The associated repor

Re: [pool] 1.5-RC1 available for review

2009-05-29 Thread Phil Steitz
sebb wrote: On 30/05/2009, Phil Steitz wrote: sebb wrote: On 29/05/2009, Phil Steitz wrote: The files are here: http://people.apache.org/~psteitz/commons-pool-1.5-RC1/ findbugs filter and license-header.txt are missing from source archives.

Re: [pool] 1.5-RC1 available for review

2009-05-29 Thread sebb
On 30/05/2009, Phil Steitz wrote: > sebb wrote: > > > On 29/05/2009, Phil Steitz wrote: > > > > > > > The files are here: > > > > http://people.apache.org/~psteitz/commons-pool-1.5-RC1/ > > > > > > > > > > findbugs filter and license-header.txt are missing from source archives. > > > > > This is

Re: [pool] 1.5-RC1 available for review

2009-05-29 Thread Phil Steitz
sebb wrote: On 29/05/2009, Phil Steitz wrote: The files are here: http://people.apache.org/~psteitz/commons-pool-1.5-RC1/ findbugs filter and license-header.txt are missing from source archives. This is intended. The associated reports are not enabled in the release pom, so ther

Re: [pool] 1.5-RC1 available for review

2009-05-29 Thread sebb
On 29/05/2009, sebb wrote: > On 29/05/2009, Phil Steitz wrote: > > The files are here: > > http://people.apache.org/~psteitz/commons-pool-1.5-RC1/ > > > findbugs filter and license-header.txt are missing from source archives. > > RELEASE-NOTES.txt is missing from the SVN tag. > > NOTICE.txt

Re: [pool] 1.5-RC1 available for review

2009-05-29 Thread sebb
On 29/05/2009, Emmanuel Bourg wrote: > sebb a écrit : > > > > DOAP file does not have an AL header (not a blocker, I'll fix trunk) > > > > Does it matter since it's a simple descriptor that is not distributed? DOAPs aren't included in the source archive - i.e. they are not part of the release -

Re: [pool] 1.5-RC1 available for review

2009-05-29 Thread Mark Thomas
Woot! Thanks for your help on this. I'm away for the next few days but will take a look early next week. Mark > --- Original Message --- > From: Phil Steitz > To: Commons Developers List > Sent: 29/05/09, 03:36:21 > Subject: [pool] 1.5-RC1 available for review >

Re: [pool] 1.5-RC1 available for review

2009-05-29 Thread Emmanuel Bourg
sebb a écrit : DOAP file does not have an AL header (not a blocker, I'll fix trunk) Does it matter since it's a simple descriptor that is not distributed? There is no point claiming copyright on such a file. Emmanuel Bourg ---

Re: [pool] 1.5-RC1 available for review

2009-05-29 Thread sebb
On 29/05/2009, Phil Steitz wrote: > The files are here: > http://people.apache.org/~psteitz/commons-pool-1.5-RC1/ findbugs filter and license-header.txt are missing from source archives. RELEASE-NOTES.txt is missing from the SVN tag. NOTICE.txt has 2008. I'm not sure why, but the $Id: SVN tag

Re: [pool] 1.5-RC1 available for review

2009-05-29 Thread Phil Steitz
Emmanuel Bourg wrote: My observations: - ErodingPerKeyKeyedObjectPool is not covered by the tests - The changes for the 1.2 release do not appear on the site. This is due to tags in changes.xml - in changes.xml, there are HTML elements but their content do not appear on the page generated (fo

Re: [pool] 1.5-RC1 available for review

2009-05-29 Thread Emmanuel Bourg
My observations: - ErodingPerKeyKeyedObjectPool is not covered by the tests - The changes for the 1.2 release do not appear on the site. This is due to tags in changes.xml - in changes.xml, there are HTML elements but their content do not appear on the page generated (for POOL-86 for example).

[pool] 1.5-RC1 available for review

2009-05-28 Thread Phil Steitz
The files are here: http://people.apache.org/~psteitz/commons-pool-1.5-RC1/ The tag is here: http://svn.apache.org/repos/asf/commons/proper/pool/tags/POOL_1_5_RC1/ Have at it! Thanks! Phil - To unsubscribe, e-mail: dev-unsubs