Re: [ognl] Codestyle

2011-10-10 Thread Christian Grobmeier
>> Of course, but automated changes are not guaranteed error-free. I never had an error with Eclipse (use that since 2002 or so). >> And it's easy to overlook some other change that was accidentally >> committed at the same time. As with every change. Actually with this argument we should stop d

Re: [ognl] Codestyle

2011-10-09 Thread Gary Gregory
On Oct 9, 2011, at 20:53, sebb wrote: > On 10 October 2011 01:22, Gary Gregory wrote: >> On Sun, Oct 9, 2011 at 7:57 PM, sebb wrote: >> >>> On 9 October 2011 14:30, Gary Gregory wrote: On Sun, Oct 9, 2011 at 7:53 AM, Christian Grobmeier >>> wrote: >> >> >> >> >> >

Re: [ognl] Codestyle

2011-10-09 Thread sebb
On 10 October 2011 01:22, Gary Gregory wrote: > On Sun, Oct 9, 2011 at 7:57 PM, sebb wrote: > >> On 9 October 2011 14:30, Gary Gregory wrote: >> > On Sun, Oct 9, 2011 at 7:53 AM, Christian Grobmeier >> wrote: >> >>> >> >>> >> >>> >> >>> >> >>> >> Hi all, >> >> Checkstyle shows me

Re: [ognl] Codestyle

2011-10-09 Thread Gary Gregory
On Sun, Oct 9, 2011 at 7:57 PM, sebb wrote: > On 9 October 2011 14:30, Gary Gregory wrote: > > On Sun, Oct 9, 2011 at 7:53 AM, Christian Grobmeier > wrote: > >>> > >>> > >>> > >>> > >>> > Hi all, > > Checkstyle shows me more or less that we should go conform the Sun > standa

Re: [ognl] Codestyle

2011-10-09 Thread sebb
On 9 October 2011 14:30, Gary Gregory wrote: > On Sun, Oct 9, 2011 at 7:53 AM, Christian Grobmeier > wrote: >>> >>> >>> >>> >>> Hi all, Checkstyle shows me more or less that we should go conform the Sun standards. I would love this, but want to make sure we have agreed on >>>

Re: [ognl] Codestyle

2011-10-09 Thread Gary Gregory
On Sun, Oct 9, 2011 at 7:53 AM, Christian Grobmeier wrote: >> >> >> >> >> >>> Hi all, >>> >>> Checkstyle shows me more or less that we should go conform the Sun >>> standards. I would love this, but want to make sure we have agreed on >>> it. Because it would need a good bunch of bracket-moving I

Re: [ognl] Codestyle

2011-10-08 Thread Christian Grobmeier
> when we started the OGNL in incubator, we lazily agreed on having the > Maven style[1], I personally don't see the need to change it now that > we are worging towards the release. OK good to know. Thanks Christian > Simo > > [1] http://maven.apache.org/developers/conventions/code.html > > http:

Re: [ognl] Codestyle

2011-10-08 Thread Simone Tripodi
Gute morgen Christian! when we started the OGNL in incubator, we lazily agreed on having the Maven style[1], I personally don't see the need to change it now that we are worging towards the release. Simo [1] http://maven.apache.org/developers/conventions/code.html http://people.apache.org/~simone

[ognl] Codestyle

2011-10-08 Thread Christian Grobmeier
Hi all, Checkstyle shows me more or less that we should go conform the Sun standards. I would love this, but want to make sure we have agreed on it. Because it would need a good bunch of bracket-moving Cheers Christian - To unsu