On 10 October 2011 01:22, Gary Gregory <garydgreg...@gmail.com> wrote: > On Sun, Oct 9, 2011 at 7:57 PM, sebb <seb...@gmail.com> wrote: > >> On 9 October 2011 14:30, Gary Gregory <garydgreg...@gmail.com> wrote: >> > On Sun, Oct 9, 2011 at 7:53 AM, Christian Grobmeier <grobme...@gmail.com> >> wrote: >> >>> >> >>> >> >>> >> >>> >> >>> >> >>>> Hi all, >> >>>> >> >>>> Checkstyle shows me more or less that we should go conform the Sun >> >>>> standards. I would love this, but want to make sure we have agreed on >> >>>> it. Because it would need a good bunch of bracket-moving >> > >> > I'm +1 on that. The change can be done automatically with most IDEs. >> > This should not be any "work". >> >> Except for the people who review commits ... >> > > Commit comments are good for this: "Automatic formatting by > Eclipse/NetBeans/YourIDE following convention foo"
Of course, but automated changes are not guaranteed error-free. And it's easy to overlook some other change that was accidentally committed at the same time. If the code is currently self consistent, why change it? --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
