RE: [math] Checkstyle

2013-03-19 Thread Becksfort, Jared
Thanks, Thomas! From: Thomas Neidhart [thomas.neidh...@gmail.com] Sent: Tuesday, March 19, 2013 3:30 PM To: Commons Developers List Subject: Re: [math] Checkstyle.. On 03/19/2013 09:22 PM, Luc Maisonobe wrote: > Hi Thomas, > > Le 19/03/2

Re: [math] Checkstyle

2013-03-19 Thread Thomas Neidhart
On 03/19/2013 09:22 PM, Luc Maisonobe wrote: > Hi Thomas, > > Le 19/03/2013 20:49, Thomas Neidhart a écrit : >> On 03/19/2013 08:43 PM, Thomas Neidhart wrote: >>> On 03/19/2013 08:18 PM, Luc Maisonobe wrote: Hi Jared, Le 19/03/2013 17:14, Becksfort, Jared a écrit : > Hello,

Re: [math] Checkstyle

2013-03-19 Thread Luc Maisonobe
Hi Thomas, Le 19/03/2013 20:49, Thomas Neidhart a écrit : > On 03/19/2013 08:43 PM, Thomas Neidhart wrote: >> On 03/19/2013 08:18 PM, Luc Maisonobe wrote: >>> Hi Jared, >>> >>> Le 19/03/2013 17:14, Becksfort, Jared a écrit : Hello, I am using the Apache Common XML file to format my

Re: [math] Checkstyle

2013-03-19 Thread Thomas Neidhart
On 03/19/2013 08:43 PM, Thomas Neidhart wrote: > On 03/19/2013 08:18 PM, Luc Maisonobe wrote: >> Hi Jared, >> >> Le 19/03/2013 17:14, Becksfort, Jared a écrit : >>> Hello, >>> >>> I am using the Apache Common XML file to format my code submissions >>> in Eclipse. Gilles says my last submission has

Re: [math] Checkstyle

2013-03-19 Thread Thomas Neidhart
On 03/19/2013 08:18 PM, Luc Maisonobe wrote: > Hi Jared, > > Le 19/03/2013 17:14, Becksfort, Jared a écrit : >> Hello, >> >> I am using the Apache Common XML file to format my code submissions >> in Eclipse. Gilles says my last submission has some CheckStyle >> warnings, so I installed the CheckS

Re: [math] Checkstyle

2013-03-19 Thread Luc Maisonobe
Hi Jared, Le 19/03/2013 17:14, Becksfort, Jared a écrit : > Hello, > > I am using the Apache Common XML file to format my code submissions > in Eclipse. Gilles says my last submission has some CheckStyle > warnings, so I installed the CheckStyle plugin. It gives tons of > warnings, including so

[math] Checkstyle

2013-03-19 Thread Becksfort, Jared
Hello, I am using the Apache Common XML file to format my code submissions in Eclipse. Gilles says my last submission has some CheckStyle warnings, so I installed the CheckStyle plugin. It gives tons of warnings, including some that go against the posted style guidelines, such as "All public

Re: [math] Checkstyle too stringent?

2012-03-19 Thread sebb
2012/3/19 Sébastien Brisard : > 2012/3/18 sebb : >> 2012/3/18 Sébastien Brisard : >>> Hi, >>> >>> 2012/3/18 sebb : 2012/3/18 Sébastien Brisard : > Hi, > I'm trying to clean up the SymmLQ class (see MATH-761 [1]). > The problem is the heart of the algorithm is very long (it would >>

Re: [math] Checkstyle too stringent?

2012-03-18 Thread Sébastien Brisard
Le 19 mars 2012 07:11, Sébastien Brisard a écrit : > 2012/3/18 sebb : >> 2012/3/18 Sébastien Brisard : >>> Hi, >>> >>> 2012/3/18 sebb : 2012/3/18 Sébastien Brisard : > Hi, > I'm trying to clean up the SymmLQ class (see MATH-761 [1]). > The problem is the heart of the algorithm is

Re: [math] Checkstyle too stringent?

2012-03-18 Thread Sébastien Brisard
2012/3/18 sebb : > 2012/3/18 Sébastien Brisard : >> Hi, >> >> 2012/3/18 sebb : >>> 2012/3/18 Sébastien Brisard : Hi, I'm trying to clean up the SymmLQ class (see MATH-761 [1]). The problem is the heart of the algorithm is very long (it would probably amount to more thatn 600 lin

Re: [math] Checkstyle too stringent?

2012-03-18 Thread sebb
2012/3/18 Sébastien Brisard : > Hi, > > 2012/3/18 sebb : >> 2012/3/18 Sébastien Brisard : >>> Hi, >>> I'm trying to clean up the SymmLQ class (see MATH-761 [1]). >>> The problem is the heart of the algorithm is very long (it would >>> probably amount to more thatn 600 lines). When I first implement

Re: [math] Checkstyle too stringent?

2012-03-18 Thread Sébastien Brisard
Hi, 2012/3/18 sebb : > 2012/3/18 Sébastien Brisard : >> Hi, >> I'm trying to clean up the SymmLQ class (see MATH-761 [1]). >> The problem is the heart of the algorithm is very long (it would >> probably amount to more thatn 600 lines). When I first implemented it, >> I figured that I could split t

Re: [math] Checkstyle too stringent?

2012-03-18 Thread sebb
2012/3/18 Sébastien Brisard : > Hi, > I'm trying to clean up the SymmLQ class (see MATH-761 [1]). > The problem is the heart of the algorithm is very long (it would > probably amount to more thatn 600 lines). When I first implemented it, > I figured that I could split this algorithm in several meth

[math] Checkstyle too stringent?

2012-03-18 Thread Sébastien Brisard
Hi, I'm trying to clean up the SymmLQ class (see MATH-761 [1]). The problem is the heart of the algorithm is very long (it would probably amount to more thatn 600 lines). When I first implemented it, I figured that I could split this algorithm in several methods: init(), update(), updateNorms(), re

Re: [math] Checkstyle, findbugs, javadoc errors

2010-09-08 Thread Luc Maisonobe
Le 08/09/2010 11:11, Gilles Sadowski a écrit : >>> Quite a few errors have crept into the code, especially in trunk. Lets >>> all please review checkstyle, findbugs and javadoc warnings before >>> committing changes. That will make it much easier to prepare releases. >>> We can talk about loosening

Re: [math] Checkstyle, findbugs, javadoc errors

2010-09-08 Thread Gilles Sadowski
> > Quite a few errors have crept into the code, especially in trunk. Lets > > all please review checkstyle, findbugs and javadoc warnings before > > committing changes. That will make it much easier to prepare releases. > > We can talk about loosening / eliminating checks if we want to; but we > >

Re: [math] Checkstyle, findbugs, javadoc errors

2010-09-08 Thread Luc Maisonobe
Le 08/09/2010 03:44, Phil Steitz a écrit : > Quite a few errors have crept into the code, especially in trunk. Lets > all please review checkstyle, findbugs and javadoc warnings before > committing changes. That will make it much easier to prepare releases. > We can talk about loosening / eliminati

[math] Checkstyle, findbugs, javadoc errors

2010-09-07 Thread Phil Steitz
Quite a few errors have crept into the code, especially in trunk. Lets all please review checkstyle, findbugs and javadoc warnings before committing changes. That will make it much easier to prepare releases. We can talk about loosening / eliminating checks if we want to; but we should adhere t