I'll make the attempt--I have Joda Time's (ASL'd) code
locally already, so I'll use those as a guide if
Stephen has no objections. :)
-Matt
--- Niall Pemberton <[EMAIL PROTECTED]> wrote:
> Sounds like a good plan, but someone else needs to
> do it - I don't
> know that code and was just trying
Sounds like a good plan, but someone else needs to do it - I don't
know that code and was just trying to get the Lang tests to pass in my
locale (en_GB).
Niall
On Nov 14, 2007 10:18 AM, Stephen Colebourne
<[EMAIL PROTECTED]> wrote:
> From my work on Joda-Time, I would advise not writing tests in
Sounds good.
22 instances of Locale.US in Lang among 8 different tests.
Hen
On Nov 14, 2007 8:06 AM, sebb <[EMAIL PROTECTED]> wrote:
> +1
>
> One of JMeter unit tests failed when it was run under Locale.DE where
> the decimal point is a comma...
>
>
> On 14/11/2007, Stephen Colebourne <[EMAIL PR
+1
One of JMeter unit tests failed when it was run under Locale.DE where
the decimal point is a comma...
On 14/11/2007, Stephen Colebourne <[EMAIL PROTECTED]> wrote:
> From my work on Joda-Time, I would advise not writing tests in Locale.US
> exclusively. The US locale can have special status as
>From my work on Joda-Time, I would advise not writing tests in Locale.US
>exclusively. The US locale can have special status as the 'default', and you
>don't want your tests to get caught up in that.
Stephen
- Original Message
From: Niall Pemberton <[EMAIL PROTECTED]>
My guess from j
--- Niall Pemberton <[EMAIL PROTECTED]> wrote:
> On Nov 14, 2007 12:06 AM, Matt Benson
> <[EMAIL PROTECTED]> wrote:
> >
> >
> > --- Niall Pemberton <[EMAIL PROTECTED]>
> wrote:
> >
> > > On Nov 13, 2007 9:53 PM, Matt Benson
> > > <[EMAIL PROTECTED]> wrote:
> > > > What this says to me is that
> >
On Nov 14, 2007 12:06 AM, Matt Benson <[EMAIL PROTECTED]> wrote:
>
>
> --- Niall Pemberton <[EMAIL PROTECTED]> wrote:
>
> > On Nov 13, 2007 9:53 PM, Matt Benson
> > <[EMAIL PROTECTED]> wrote:
> > > What this says to me is that
> > > DateFormat.getTimeInstance(int, Locale) is buggy
> > in
> > > that
--- Niall Pemberton <[EMAIL PROTECTED]> wrote:
> On Nov 13, 2007 9:53 PM, Matt Benson
> <[EMAIL PROTECTED]> wrote:
> > What this says to me is that
> > DateFormat.getTimeInstance(int, Locale) is buggy
> in
> > that the full/long time formatting pattern is at
> least
> > partially dependent upon t
Makes better sense to localize the impact of changing the Locale if
possible, as you say. I'm going to look more closely at that.
On Nov 13, 2007 3:39 PM, Niall Pemberton <[EMAIL PROTECTED]> wrote:
> On Nov 13, 2007 9:53 PM, Matt Benson <[EMAIL PROTECTED]> wrote:
> > What this says to me is that
>
On Nov 13, 2007 9:53 PM, Matt Benson <[EMAIL PROTECTED]> wrote:
> What this says to me is that
> DateFormat.getTimeInstance(int, Locale) is buggy in
> that the full/long time formatting pattern is at least
> partially dependent upon the default Locale even when
> the Locale is specified explicitly
What this says to me is that
DateFormat.getTimeInstance(int, Locale) is buggy in
that the full/long time formatting pattern is at least
partially dependent upon the default Locale even when
the Locale is specified explicitly by the method
signature. MF is explicit enough about its
implementation d
What I know now, and what surprised me, was that passing user.language
and user.region (or user.country) did not actually change the default
Locale from junit's point of view, though it did change at least the
default date formatting. Though now that I think of it, maybe doing it
that way doesn't a
--- Matt Benson <[EMAIL PROTECTED]> wrote:
> Does anyone care to corroborate my opinion, then,
> that
> java.text.MessageFormat's (String, Locale)
> constructor
> must yield a buggy object instance, then?
Double "then"s notwithstanding?
>
> -Matt
>
>
> --- Ben Speakmon <[EMAIL PROTECTED]> wr
Does anyone care to corroborate my opinion, then, that
java.text.MessageFormat's (String, Locale) constructor
must yield a buggy object instance, then?
-Matt
--- Ben Speakmon <[EMAIL PROTECTED]> wrote:
> Well that settles that :) Apparently you can't set
> the locale from the
> command line, ju
Well that settles that :) Apparently you can't set the locale from the
command line, just the language and region. weird.
I'll check in that change.
On Nov 13, 2007 1:10 PM, Niall Pemberton <[EMAIL PROTECTED]> wrote:
> Well I threw the following line into the setup() method of
> AbstractMessageFo
Well I threw the following line into the setup() method of
AbstractMessageFormatTest and the errors go away.
java.util.Locale.setDefault(java.util.Locale.US);
Niall
On Nov 13, 2007 8:17 PM, Matt Benson <[EMAIL PROTECTED]> wrote:
> Rather, I created the tests to explicitly use
> Locale.US
Rather, I created the tests to explicitly use
Locale.US so that there were no assumptions wrt
default Locale; I will certainly be double-checking
these. :|
-Matt
--- Niall Pemberton <[EMAIL PROTECTED]> wrote:
> My guess from just looking at the test output is
> that theres an
> assumption in th
Tried overriding the locale to en_GB and ko_KR just for kicks. Still
no fail for me. Hmm. I'll try a couple of other things.
On Nov 13, 2007 11:44 AM, Niall Pemberton <[EMAIL PROTECTED]> wrote:
> My guess from just looking at the test output is that theres an
> assumption in the test that the defa
My guess from just looking at the test output is that theres an
assumption in the test that the default Locale is US. If that is the
case then these tests should set the default locale to Locale.US
before executing.
Niall
On Nov 13, 2007 7:38 PM, Ben Speakmon <[EMAIL PROTECTED]> wrote:
> Odd. WFM
Odd. WFM on my ubuntu with Java 1.4 and 5.
On Nov 13, 2007 11:31 AM, Niall Pemberton <[EMAIL PROTECTED]> wrote:
> I just tried running "maven test" for Commons Lang and the
> TextTestSuite had a bunch of failures. I don't really have time to
> look into this at the moment.
>
> Niall
>
> Testcase:
I just tried running "maven test" for Commons Lang and the
TextTestSuite had a bunch of failures. I don't really have time to
look into this at the moment.
Niall
Testcase: testLongTime(org.apache.commons.lang.text.MessageFormatTest): FAILED
expected:<...00:15:20 GMT; Time 1: 12:30:35 GMT; Time 2:
21 matches
Mail list logo
