I'll make the attempt--I have Joda Time's (ASL'd) code
locally already, so I'll use those as a guide if
Stephen has no objections. :)
-Matt
--- Niall Pemberton <[EMAIL PROTECTED]> wrote:
> Sounds like a good plan, but someone else needs to
> do it - I don't
> know that code and was just trying to get the Lang
> tests to pass in my
> locale (en_GB).
>
> Niall
>
> On Nov 14, 2007 10:18 AM, Stephen Colebourne
> <[EMAIL PROTECTED]> wrote:
> > From my work on Joda-Time, I would advise not
> writing tests in Locale.US exclusively. The US
> locale can have special status as the 'default', and
> you don't want your tests to get caught up in that.
> > Stephen
> >
> >
> >
> > ----- Original Message ----
> > From: Niall Pemberton <[EMAIL PROTECTED]>
> >
> > My guess from just looking at the test output is
> that theres an
> > assumption in the test that the default Locale is
> US. If that is the
> > case then these tests should set the default
> locale to Locale.US
> > before executing.
> >
> > Niall
> >
> > On Nov 13, 2007 7:38 PM, Ben Speakmon
> <[EMAIL PROTECTED]> wrote:
> > > Odd. WFM on my ubuntu with Java 1.4 and 5.
> > >
> > >
> > > On Nov 13, 2007 11:31 AM, Niall Pemberton
> <[EMAIL PROTECTED]>
> > wrote:
> > > > I just tried running "maven test" for Commons
> Lang and the
> > > > TextTestSuite had a bunch of failures. I don't
> really have time to
> > > > look into this at the moment.
> > > >
> > > > Niall
> > > >
> > > > Testcase:
> >
>
testLongTime(org.apache.commons.lang.text.MessageFormatTest):
> FAILED
> > > > expected:<...00:15:20 GMT; Time 1: 12:30:35
> GMT; Time 2:
> > 18:45:50...>
> > > > but was:<...12:15:20 AM GMT; Time 1: 12:30:35
> PM GMT; Time 2:
> > 6:45:50
> > > > PM...>
> > > > junit.framework.ComparisonFailure:
> expected:<...00:15:20 GMT; Time
> > 1:
> > > > 12:30:35 GMT; Time 2: 18:45:50...> but
> was:<...12:15:20 AM GMT;
> > Time
> > > > 1: 12:30:35 PM GMT; Time 2: 6:45:50 PM...>
> > > > at
> >
>
org.apache.commons.lang.text.AbstractMessageFormatTest.doAssertions(AbstractMessageFormatTest.java:64)
> > > > at
> >
>
org.apache.commons.lang.text.AbstractMessageFormatTest.doAssertions(AbstractMessageFormatTest.java:58)
> > > > at
> >
>
org.apache.commons.lang.text.AbstractMessageFormatTest.testLongTime(AbstractMessageFormatTest.java:222)
> > > > at
> sun.reflect.NativeMethodAccessorImpl.invoke0(Native
> > Method)
> > > > at
> sun.reflect.NativeMethodAccessorImpl.invoke(Unknown
> > Source)
> > > > at
>
sun.reflect.DelegatingMethodAccessorImpl.invoke(Unknown
> > Source)
> > > >
> > > >
> > > > Testcase:
> >
>
testFullTime(org.apache.commons.lang.text.MessageFormatTest):
> FAILED
> > > > expected:<...00:15:20 o'clock GMT; Time 1:
> 12:30:35 o'clock GMT;
> > Time
> > > > 2: 18:45:50 o'clock...> but was:<...12:15:20
> AM GMT; Time 1:
> > 12:30:35
> > > > PM GMT; Time 2: 6:45:50 PM...>
> > > > junit.framework.ComparisonFailure:
> expected:<...00:15:20 o'clock
> > GMT;
> > > > Time 1: 12:30:35 o'clock GMT; Time 2: 18:45:50
> o'clock...> but
> > > > was:<...12:15:20 AM GMT; Time 1: 12:30:35 PM
> GMT; Time 2: 6:45:50
> > > > PM...>
> > > > at
> >
>
org.apache.commons.lang.text.AbstractMessageFormatTest.doAssertions(AbstractMessageFormatTest.java:64)
> > > > at
> >
>
org.apache.commons.lang.text.AbstractMessageFormatTest.testFullTime(AbstractMessageFormatTest.java:238)
> > > > at
> sun.reflect.NativeMethodAccessorImpl.invoke0(Native
> > Method)
> > > > at
> sun.reflect.NativeMethodAccessorImpl.invoke(Unknown
> > Source)
> > > > at
>
sun.reflect.DelegatingMethodAccessorImpl.invoke(Unknown
> > Source)
> > > >
> > > >
> > > > Testcase:
> >
>
testLongTime(org.apache.commons.lang.text.ExtendedMessageFormatBaselineTest):
> FAILED
> > > > expected:<...00:15:20 GMT; Time 1: 12:30:35
> GMT; Time 2:
> > 18:45:50...>
> > > > but was:<...12:15:20 AM GMT; Time 1: 12:30:35
> PM GMT; Time 2:
> > 6:45:50
> > > > PM...>
> > > > junit.framework.ComparisonFailure:
> expected:<...00:15:20 GMT; Time
> > 1:
> > > > 12:30:35 GMT; Time 2: 18:45:50...> but
> was:<...12:15:20 AM GMT;
> > Time
> > > > 1: 12:30:35 PM GMT; Time 2: 6:45:50 PM...>
> > > > at
> >
>
org.apache.commons.lang.text.AbstractMessageFormatTest.doAssertions(AbstractMessageFormatTest.java:64)
> > > > at
> >
>
org.apache.commons.lang.text.AbstractMessageFormatTest.doAssertions(AbstractMessageFormatTest.java:58)
> > > > at
> >
>
org.apache.commons.lang.text.AbstractMessageFormatTest.testLongTime(AbstractMessageFormatTest.java:222)
> > > > at
> sun.reflect.NativeMethodAccessorImpl.invoke0(Native
> > Method)
> > > > at
> sun.reflect.NativeMethodAccessorImpl.invoke(Unknown
> > Source)
> > > > at
>
sun.reflect.DelegatingMethodAccessorImpl.invoke(Unknown
> > Source)
> > > >
> > > >
> > > > Testcase:
> >
>
testFullTime(org.apache.commons.lang.text.ExtendedMessageFormatBaselineTest):
> FAILED
> > > > expected:<...00:15:20 o'clock GMT; Time 1:
> 12:30:35 o'clock GMT;
> > Time
> > > > 2: 18:45:50 o'clock...> but was:<...12:15:20
> AM GMT; Time 1:
> > 12:30:35
> > > > PM GMT; Time 2: 6:45:50 PM...>
> > > > junit.framework.ComparisonFailure:
> expected:<...00:15:20 o'clock
> > GMT;
> > > > Time 1: 12:30:35 o'clock GMT; Time 2: 18:45:50
> o'clock...> but
> > > > was:<...12:15:20 AM GMT; Time 1: 12:30:35 PM
> GMT; Time 2: 6:45:50
> > > > PM...>
> > > > at
> >
>
org.apache.commons.lang.text.AbstractMessageFormatTest.doAssertions(AbstractMessageFormatTest.java:64)
> > > > at
> >
>
org.apache.commons.lang.text.AbstractMessageFormatTest.testFullTime(AbstractMessageFormatTest.java:238)
> > > > at
> sun.reflect.NativeMethodAccessorImpl.invoke0(Native
> > Method)
> > > > at
> sun.reflect.NativeMethodAccessorImpl.invoke(Unknown
> > Source)
> > > > at
>
sun.reflect.DelegatingMethodAccessorImpl.invoke(Unknown
> > Source)
> > > >
> > > >
> > > > Testcase:
> >
>
testLongTime(org.apache.commons.lang.text.MessageFormatExtensionTest):
> FAILED
> > > > expected:<...00:15:20 GMT; Time 1: 12:30:35
> GMT; Time 2:
> > 18:45:50...>
> > > > but was:<...12:15:20 AM GMT; Time 1: 12:30:35
> PM GMT; Time 2:
> > 6:45:50
> > > > PM...>
> > > > junit.framework.ComparisonFailure:
> expected:<...00:15:20 GMT; Time
> > 1:
> > > > 12:30:35 GMT; Time 2: 18:45:50...> but
> was:<...12:15:20 AM GMT;
> > Time
> > > > 1: 12:30:35 PM GMT; Time 2: 6:45:50 PM...>
> > > > at
> >
>
org.apache.commons.lang.text.AbstractMessageFormatTest.doAssertions(AbstractMessageFormatTest.java:64)
> > > > at
> >
>
org.apache.commons.lang.text.AbstractMessageFormatTest.doAssertions(AbstractMessageFormatTest.java:58)
> > > > at
> >
>
org.apache.commons.lang.text.AbstractMessageFormatTest.testLongTime(AbstractMessageFormatTest.java:222)
> > > > at
> sun.reflect.NativeMethodAccessorImpl.invoke0(Native
> > Method)
> > > > at
> sun.reflect.NativeMethodAccessorImpl.invoke(Unknown
> > Source)
> > > > at
>
sun.reflect.DelegatingMethodAccessorImpl.invoke(Unknown
> > Source)
> > > >
> > > >
> > > > Testcase:
> >
>
testFullTime(org.apache.commons.lang.text.MessageFormatExtensionTest):
> FAILED
> > > > expected:<...00:15:20 o'clock GMT; Time 1:
> 12:30:35 o'clock GMT;
> > Time
> > > > 2: 18:45:50 o'clock...> but was:<...12:15:20
> AM GMT; Time 1:
> > 12:30:35
> > > > PM GMT; Time 2: 6:45:50 PM...>
> > > > junit.framework.ComparisonFailure:
> expected:<...00:15:20 o'clock
> > GMT;
> > > > Time 1: 12:30:35 o'clock GMT; Time 2: 18:45:50
> o'clock...> but
> > > > was:<...12:15:20 AM GMT; Time 1: 12:30:35 PM
> GMT; Time 2: 6:45:50
> > > > PM...>
> > > > at
> >
>
org.apache.commons.lang.text.AbstractMessageFormatTest.doAssertions(AbstractMessageFormatTest.java:64)
> > > > at
> >
>
org.apache.commons.lang.text.AbstractMessageFormatTest.testFullTime(AbstractMessageFormatTest.java:238)
> > > > at
> sun.reflect.NativeMethodAccessorImpl.invoke0(Native
> > Method)
> > > > at
> sun.reflect.NativeMethodAccessorImpl.invoke(Unknown
> > Source)
> > > > at
>
sun.reflect.DelegatingMethodAccessorImpl.invoke(Unknown
> > Source)
> > > >
> > > >
> >
>
---------------------------------------------------------------------
> > > > To unsubscribe, e-mail:
> [EMAIL PROTECTED]
> > > > For additional commands, e-mail:
> [EMAIL PROTECTED]
> > > >
> > > >
> > >
> > >
>
---------------------------------------------------------------------
> > > To unsubscribe, e-mail:
> [EMAIL PROTECTED]
> > > For additional commands, e-mail:
> [EMAIL PROTECTED]
> > >
> > >
> >
> >
>
---------------------------------------------------------------------
> > To unsubscribe, e-mail:
> [EMAIL PROTECTED]
> > For additional commands, e-mail:
> [EMAIL PROTECTED]
> >
> >
> >
> >
> >
> >
>
---------------------------------------------------------------------
> > To unsubscribe, e-mail:
> [EMAIL PROTECTED]
> > For additional commands, e-mail:
> [EMAIL PROTECTED]
> >
> >
>
>
---------------------------------------------------------------------
> To unsubscribe, e-mail:
> [EMAIL PROTECTED]
> For additional commands, e-mail:
> [EMAIL PROTECTED]
>
>
____________________________________________________________________________________
Be a better pen pal.
Text or chat with friends inside Yahoo! Mail. See how.
http://overview.mail.yahoo.com/
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
