Re: [lang] Some first steps to implementing LANG-637

2012-10-16 Thread Gary Gregory
On Tue, Oct 16, 2012 at 5:29 AM, Duncan Jones wrote: > On 1 October 2012 14:07, Duncan Jones wrote: > > I've now uploaded a complete solution for LANG-637 (see > > commons-lang3-LANG-637-complete.patch in JIRA) and I would very much > > appreciate feedback on the design and implementation. I've

Re: [lang] Some first steps to implementing LANG-637

2012-10-16 Thread Duncan Jones
On 1 October 2012 14:07, Duncan Jones wrote: > I've now uploaded a complete solution for LANG-637 (see > commons-lang3-LANG-637-complete.patch in JIRA) and I would very much > appreciate feedback on the design and implementation. I've already > factored in comments from James C and Matt B. > > I l

Re: [lang] Some first steps to implementing LANG-637

2012-10-01 Thread Duncan Jones
> On Sep 23, 2012, at 2:43 PM, Duncan Jones wrote: > >> Hi everyone, >> >> I've begun work on implementing a DifferenceBuilder class as requested >> in LANG-637. I've attached some partial implementations of a builder >> and associated interface and test to the JIRA issue >> (https://issues.apache

Re: [lang] Some first steps to implementing LANG-637

2012-09-23 Thread James Carman
How about renaming it to DiffBuilder and the interface would be Diffable? The term "diff" is well understood and commonplace. The term "difference" sounds too "mathy" and would be confusing. I liked Matt's idea of having a Difference object (again renamed to Diff). Sent from my iPad On Se

[lang] Some first steps to implementing LANG-637

2012-09-23 Thread Duncan Jones
Hi everyone, I've begun work on implementing a DifferenceBuilder class as requested in LANG-637. I've attached some partial implementations of a builder and associated interface and test to the JIRA issue (https://issues.apache.org/jira/browse/LANG-637). Before I spend too much time adding upteem