On 1 October 2012 14:07, Duncan Jones <dun...@wortharead.com> wrote: > I've now uploaded a complete solution for LANG-637 (see > commons-lang3-LANG-637-complete.patch in JIRA) and I would very much > appreciate feedback on the design and implementation. I've already > factored in comments from James C and Matt B. > > I leant heavily on the existing reflection work in EqualsBuilder when > adding the same functionality to my DiffBuilder class. If any part of > my code particularly requires review, it is that area. Not just in the > implementation details, but in some of the design decisions > (particularly whether it is correct to throw a CastClassException when > the types are not suited for comparison).
Just wondering if no feedback is good feedback? I've got plenty of time to add some improvements if anyone has any pointers. I'd love to see this make its way into the 3.2 release. Thanks, Duncan --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
