Re: [csv] type name consistency

2013-09-14 Thread Benedikt Ritter
2013/9/14 Emmanuel Bourg > Le 14/09/2013 11:27, sebb a écrit : > > > There is one other inconsistency that might be worth addressing: all > > the classes are final apart from CSVFormat. > > Should it be final? If not, the reason needs documenting as it is > > different from the rest of the code.

Re: [csv] type name consistency

2013-09-14 Thread Emmanuel Bourg
Le 14/09/2013 11:27, sebb a écrit : > There is one other inconsistency that might be worth addressing: all > the classes are final apart from CSVFormat. > Should it be final? If not, the reason needs documenting as it is > different from the rest of the code. +1 for making CSVFormat final. Emman

Re: [csv] type name consistency

2013-09-14 Thread sebb
On 14 September 2013 09:20, Emmanuel Bourg wrote: > Le 13/09/2013 13:22, Benedikt Ritter a écrit : > >> I'll change this if nobody objects. > > I'm still not convinced by the renaming of Quote as a matter of > consistency. Does it mean that any new public class added to the package > in the future

Re: [csv] type name consistency

2013-09-14 Thread Emmanuel Bourg
Le 13/09/2013 13:22, Benedikt Ritter a écrit : > I'll change this if nobody objects. I'm still not convinced by the renaming of Quote as a matter of consistency. Does it mean that any new public class added to the package in the future will have to be prefixed by "CSV" as well? That seems a bit w

Re: [csv] type name consistency

2013-09-13 Thread Benedikt Ritter
We never finished the discussion about Quote. I agree with Gary that it's weird to have Quote as the only class that doesn't have the "CSV" prefix. I'll change this if nobody objects. Benedikt 2013/8/7 Gary Gregory > On Wed, Aug 7, 2013 at 10:39 AM, sebb wrote: > > > On 7 August 2013 14:15,

Re: [csv] type name consistency

2013-08-07 Thread Gary Gregory
On Wed, Aug 7, 2013 at 10:39 AM, sebb wrote: > On 7 August 2013 14:15, Gary Gregory wrote: > > On Wed, Aug 7, 2013 at 2:45 AM, Benedikt Ritter > wrote: > > > >> 2013/8/7 Gary Gregory > >> > >> > I think we can be done unless other opinions come in... > >> > > >> > >> What about Quote? Do we wa

Re: [csv] type name consistency

2013-08-07 Thread sebb
On 7 August 2013 14:15, Gary Gregory wrote: > On Wed, Aug 7, 2013 at 2:45 AM, Benedikt Ritter wrote: > >> 2013/8/7 Gary Gregory >> >> > I think we can be done unless other opinions come in... >> > >> >> What about Quote? Do we want to move it to CSVFormat? Makes sense because >> it is really par

Re: [csv] type name consistency

2013-08-07 Thread Gary Gregory
On Wed, Aug 7, 2013 at 2:45 AM, Benedikt Ritter wrote: > 2013/8/7 Gary Gregory > > > I think we can be done unless other opinions come in... > > > > What about Quote? Do we want to move it to CSVFormat? Makes sense because > it is really part of a CSVFormat. OTOH CSVFormat.Quote.ALL is more verb

Re: [csv] type name consistency

2013-08-07 Thread James Carman
I like Csv as opposed to CSV also. On Tuesday, August 6, 2013, Gary Gregory wrote: > The class names in [csv] are (pp) means package private, others are public > > org.apache.commons.csv.Constants (pp) > org.apache.commons.csv.CSVFormat > org.apache.commons.csv.CSVLexer > org.apache.commons.csv.C

Re: [csv] type name consistency

2013-08-06 Thread Benedikt Ritter
2013/8/7 Gary Gregory > I think we can be done unless other opinions come in... > What about Quote? Do we want to move it to CSVFormat? Makes sense because it is really part of a CSVFormat. OTOH CSVFormat.Quote.ALL is more verbose then simply Quote.ALL > > G > > > On Tue, Aug 6, 2013 at 6:57 P

Re: [csv] type name consistency

2013-08-06 Thread Benedikt Ritter
2013/8/7 Emmanuel Bourg > Le 07/08/2013 01:31, sebb a écrit : > > I quite like the idea of dropping the CSV prefix - the package name is > > csv so the CSV prefix is redundant. > > > > But if no-one else is keen, it's not a big deal. > > I don't think this is a good idea, the class names would be

Re: [csv] type name consistency

2013-08-06 Thread Emmanuel Bourg
Le 07/08/2013 01:31, sebb a écrit : > I quite like the idea of dropping the CSV prefix - the package name is > csv so the CSV prefix is redundant. > > But if no-one else is keen, it's not a big deal. I don't think this is a good idea, the class names would become way too generic. This will clash

Re: [csv] type name consistency

2013-08-06 Thread Gary Gregory
On Tue, Aug 6, 2013 at 7:31 PM, sebb wrote: > I quite like the idea of dropping the CSV prefix +1 Gary > - the package name is > csv so the CSV prefix is redundant. > But if no-one else is keen, it's not a big deal. > > On 7 August 2013 00:19, Gary Gregory wrote: > > I think we can be don

Re: [csv] type name consistency

2013-08-06 Thread sebb
I quite like the idea of dropping the CSV prefix - the package name is csv so the CSV prefix is redundant. But if no-one else is keen, it's not a big deal. On 7 August 2013 00:19, Gary Gregory wrote: > I think we can be done unless other opinions come in... > > G > > > On Tue, Aug 6, 2013 at 6:5

Re: [csv] type name consistency

2013-08-06 Thread Gary Gregory
I think we can be done unless other opinions come in... G On Tue, Aug 6, 2013 at 6:57 PM, sebb wrote: > On 6 August 2013 17:47, Gary Gregory wrote: > > On Tue, Aug 6, 2013 at 11:27 AM, Benedikt Ritter > wrote: > > > >> 2013/8/6 sebb > >> > >> > On 6 August 2013 15:48, Gary Gregory wrote: >

Re: [csv] type name consistency

2013-08-06 Thread sebb
On 6 August 2013 17:47, Gary Gregory wrote: > On Tue, Aug 6, 2013 at 11:27 AM, Benedikt Ritter wrote: > >> 2013/8/6 sebb >> >> > On 6 August 2013 15:48, Gary Gregory wrote: >> > > The class names in [csv] are (pp) means package private, others are >> > public >> > > >> > > org.apache.commons.cs

Re: [csv] type name consistency

2013-08-06 Thread Gary Gregory
On Tue, Aug 6, 2013 at 11:27 AM, Benedikt Ritter wrote: > 2013/8/6 sebb > > > On 6 August 2013 15:48, Gary Gregory wrote: > > > The class names in [csv] are (pp) means package private, others are > > public > > > > > > org.apache.commons.csv.Constants (pp) > > > org.apache.commons.csv.CSVFormat

Re: [csv] type name consistency

2013-08-06 Thread Benedikt Ritter
2013/8/6 sebb > On 6 August 2013 15:48, Gary Gregory wrote: > > The class names in [csv] are (pp) means package private, others are > public > > > > org.apache.commons.csv.Constants (pp) > > org.apache.commons.csv.CSVFormat > > org.apache.commons.csv.CSVLexer > > That is also (pp) > > > org.apac

Re: [csv] type name consistency

2013-08-06 Thread sebb
On 6 August 2013 15:48, Gary Gregory wrote: > The class names in [csv] are (pp) means package private, others are public > > org.apache.commons.csv.Constants (pp) > org.apache.commons.csv.CSVFormat > org.apache.commons.csv.CSVLexer That is also (pp) > org.apache.commons.csv.CSVParser > org.apach

Re: [csv] type name consistency

2013-08-06 Thread Emmanuel Bourg
Le 06/08/2013 16:48, Gary Gregory a écrit : > So all of the _public_ types except Quote are prefixed with "CSV". > > - Should all types be prefixed with "CSV"? > - Should Quote be renamed to CSVQuote? I'm fine with 'Quote' as it stands out as an enum. Alternatively it could be turned into an inn

[csv] type name consistency

2013-08-06 Thread Gary Gregory
The class names in [csv] are (pp) means package private, others are public org.apache.commons.csv.Constants (pp) org.apache.commons.csv.CSVFormat org.apache.commons.csv.CSVLexer org.apache.commons.csv.CSVParser org.apache.commons.csv.CSVPrinter org.apache.commons.csv.CSVRecord org.apache.commons.c