Re: [VOTE] Release of DbUtils 1.3 RC2

2009-11-07 Thread James Carman
No broken windows, man. :) On Sat, Nov 7, 2009 at 3:27 PM, Dan Fabulich wrote: > James Carman wrote: > >> If you don't fix the exposure of internals, it might mess things up >> later if you want to change the implementation.  I'd say those should >> be fixed. > > It's a little late for that... t

Re: [VOTE] Release of DbUtils 1.3 RC2

2009-11-07 Thread Dan Fabulich
James Carman wrote: If you don't fix the exposure of internals, it might mess things up later if you want to change the implementation. I'd say those should be fixed. It's a little late for that... this bug was in version 1.2. But I fixed it anyway as DBUTILS-63 in revision 833753. I'll rol

Re: [VOTE] Release of DbUtils 1.3 RC2

2009-11-07 Thread James Carman
If you don't fix the exposure of internals, it might mess things up later if you want to change the implementation. I'd say those should be fixed. On Sat, Nov 7, 2009 at 7:41 AM, Luc Maisonobe wrote: > Jörg Schaible a écrit : >> Dan Fabulich wrote: >> >>> This release includes support for Java5

Re: [VOTE] Release of DbUtils 1.3 RC2

2009-11-07 Thread Luc Maisonobe
Jörg Schaible a écrit : > Dan Fabulich wrote: > >> This release includes support for Java5 generics and varargs. +0 as there are quite a few checkstyle errors and findbugs errors. These errors are not blocking, but could be easily fixed. The checkstyle errors are all missing javadoc. The findbugs