If you don't fix the exposure of internals, it might mess things up later if you want to change the implementation. I'd say those should be fixed.
On Sat, Nov 7, 2009 at 7:41 AM, Luc Maisonobe <luc.maison...@free.fr> wrote: > Jörg Schaible a écrit : >> Dan Fabulich wrote: >> >>> This release includes support for Java5 generics and varargs. > > +0 as there are quite a few checkstyle errors and findbugs errors. These > errors are not blocking, but could be easily fixed. The checkstyle > errors are all missing javadoc. The findbugs errors are mostly > performance issues, one bad practice and two exposure of internal > representations. > > Luc > > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org > For additional commands, e-mail: dev-h...@commons.apache.org > > --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
