Re: [VOTE] Release of CLI 1.2 RC3

2009-03-02 Thread Jörg Schaible
Hi Henri, Henri Yandell wrote at Samstag, 28. Februar 2009 21:15: > I've fixed the first one - or should have (as I'm not setup to test). > Not a blocker on release though imo. Agreed. > The second does not look like it'll have come about due to new code - > it was an attempt to increase code c

Re: [VOTE] Release of CLI 1.2 RC3

2009-02-28 Thread Oliver Heger
Henri Yandell schrieb: Something to fix - but I don't think this is a blocker on release. The only difference I can see is the extra newline at the end of one case and not the other, which is cosmetic as far as a user is concerned. I created an issue [1] and attached a patch that fixes the prob

Re: [VOTE] Release of CLI 1.2 RC3

2009-02-28 Thread Henri Yandell
Something to fix - but I don't think this is a blocker on release. The only difference I can see is the extra newline at the end of one case and not the other, which is cosmetic as far as a user is concerned. On Fri, Feb 27, 2009 at 12:10 PM, Oliver Heger wrote: > I tried to build from the source

Re: [VOTE] Release of CLI 1.2 RC3

2009-02-28 Thread Henri Yandell
I've fixed the first one - or should have (as I'm not setup to test). Not a blocker on release though imo. The second does not look like it'll have come about due to new code - it was an attempt to increase code coverage so the bug is extremely likely to already exist in 1.0, 1.1 etc. Not a blocke

Re: [VOTE] Release of CLI 1.2 RC3

2009-02-28 Thread Jörg Schaible
Hi Henry, Henri Yandell wrote: > Are these new errors Jörg, or do they happen with 1.1? Hardly, both tests did not exist yet in 1.1 ;-) OptionGroupTest.toString fails, because the option group is based on a HashMap which is printed in arbitrary order. Since the options are mutually exclusive, t

Re: [VOTE] Release of CLI 1.2 RC3

2009-02-27 Thread Henri Yandell
Random guess - the PrintWriter API is putting platform specific stuff in for \n, so the StringWriter is not the same while on Windows. On Fri, Feb 27, 2009 at 12:10 PM, Oliver Heger wrote: > I tried to build from the sources on Windows Vista with JDK 1.6 and got the > following test errors: > > F

Re: [VOTE] Release of CLI 1.2 RC3

2009-02-27 Thread Henri Yandell
Are these new errors Jörg, or do they happen with 1.1? On Fri, Feb 27, 2009 at 6:17 PM, Jörg Schaible wrote: > Hi Henri, > > with RC3 I have the same test failures as with RC2: > http://markmail.org/message/e6awtbsw4ypur2ru > > - Jörg > > > Henri Yandell wrote: > >> Gary's regression bug is fixed

Re: [VOTE] Release of CLI 1.2 RC3

2009-02-27 Thread Jörg Schaible
Hi Henri, with RC3 I have the same test failures as with RC2: http://markmail.org/message/e6awtbsw4ypur2ru - Jörg Henri Yandell wrote: > Gary's regression bug is fixed. So voting again. > > > Tag: > > https://svn.apache.org/repos/asf/commons/proper/cli/tags/cli-1.2-RC3 > > Site remains unc

Re: [VOTE] Release of CLI 1.2 RC3

2009-02-27 Thread Oliver Heger
I tried to build from the sources on Windows Vista with JDK 1.6 and got the following test errors: Failed tests: testLongLineChunking(org.apache.commons.cli.bug.BugCLI162Test) testLongLineChunkingIndentIgnored(org.apache.commons.cli.bug.BugCLI162Test) Tests run: 186, Failures: 2, Errors: 0, Ski

Re: [VOTE] Release of CLI 1.2 RC3

2009-02-27 Thread Russel Winder
Henri As previously, I built a commons-cli-1.2.jar from the branch rather than the tag, so I am not really testing the RC-3 per se -- but they should be identical :-) Groovy and Gant both pass all their tests fine as far as I can see. If I get a vote, I vote for release. On Fri, 2009-02-27 at 0

[VOTE] Release of CLI 1.2 RC3

2009-02-27 Thread Henri Yandell
Gary's regression bug is fixed. So voting again. Tag: https://svn.apache.org/repos/asf/commons/proper/cli/tags/cli-1.2-RC3 Site remains unchanged: http://people.apache.org/~bayard/cli-1.2-rc1 Binaries: http://people.apache.org/builds/commons/cli/1.2/RC3/staged/commons-cli/commons-cli/1.2/ [