Henri Yandell schrieb:
Something to fix - but I don't think this is a blocker on release. The
only difference I can see is the extra newline at the end of one case
and not the other, which is cosmetic as far as a user is concerned.
I created an issue [1] and attached a patch that fixes the problem by
using the OS-specific line terminator in the tests.
I think, this should be added for the release because it would be a
shame if one cannot build the source distribution under windows.
Oliver
[1] https://issues.apache.org/jira/browse/CLI-175
On Fri, Feb 27, 2009 at 12:10 PM, Oliver Heger
<oliver.he...@oliver-heger.de> wrote:
I tried to build from the sources on Windows Vista with JDK 1.6 and got the
following test errors:
Failed tests:
testLongLineChunking(org.apache.commons.cli.bug.BugCLI162Test)
testLongLineChunkingIndentIgnored(org.apache.commons.cli.bug.BugCLI162Test)
Tests run: 186, Failures: 2, Errors: 0, Skipped: 0
Below are the surefire reports I get.
Oliver
-------------------------------------------------------------------------------
Test set: org.apache.commons.cli.bug.BugCLI162Test
-------------------------------------------------------------------------------
Tests run: 4, Failures: 2, Errors: 0, Skipped: 0, Time elapsed: 0.031 sec
<<< FAILURE!
testLongLineChunking(org.apache.commons.cli.bug.BugCLI162Test) Time
elapsed: 0.015 sec <<< FAILURE!
junit.framework.ComparisonFailure: Long arguments did not split as expected
expected:<...
org.apache.commons.cli.bug.B
ugCLI162Test
Header
-x,--extralongarg This
description
has
ReallyLongVal
uesThatAreLon
gerThanTheWid
thOfTheColumn
s and also
other
ReallyLongVal
uesThatAreHug
erAndBiggerTh
anTheWidthOfT
heColumnsBob,
yes.
Footer...> but was:<...
org.apache.commons.cli.bug.B
ugCLI162Test
Header
-x,--extralongarg This
description
has
ReallyLongVal
uesThatAreLon
gerThanTheWid
thOfTheColumn
s and also
other
ReallyLongVal
uesThatAreHug
erAndBiggerTh
anTheWidthOfT
heColumnsBob,
yes.
Footer
...>
at junit.framework.Assert.assertEquals(Assert.java:81)
at
org.apache.commons.cli.bug.BugCLI162Test.testLongLineChunking(BugCLI162Test.java:261)
testLongLineChunkingIndentIgnored(org.apache.commons.cli.bug.BugCLI162Test)
Time elapsed: 0 sec <<< FAILURE!
junit.framework.ComparisonFailure: Long arguments did not split as expected
expected:<...
org.apache.comm
ons.cli.bug.Bug
CLI162Test
Header
-x,--extralongarg
This description is
Long.
Footer...> but was:<...
org.apache.comm
ons.cli.bug.Bug
CLI162Test
Header
-x,--extralongarg
This description is
Long.
Footer
...>
at junit.framework.Assert.assertEquals(Assert.java:81)
at
org.apache.commons.cli.bug.BugCLI162Test.testLongLineChunkingIndentIgnored(BugCLI162Test.java:280)
Henri Yandell schrieb:
Gary's regression bug is fixed. So voting again.
Tag:
https://svn.apache.org/repos/asf/commons/proper/cli/tags/cli-1.2-RC3
Site remains unchanged:
http://people.apache.org/~bayard/cli-1.2-rc1
Binaries:
http://people.apache.org/builds/commons/cli/1.2/RC3/staged/commons-cli/commons-cli/1.2/
[ ] +1 release it
[ ] +0 go ahead I don't care
[ ] -1 no, do not release it because
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org
