On 31 January 2015 at 11:41, Stefan Bodewig wrote:
> On 2015-01-31, sebb wrote:
>
>> On 31 January 2015 at 09:03, Stefan Bodewig wrote:
>>> On 2015-01-31, sebb wrote:
>
Given that the protected fields were in a class marked as internal, it
seems arguable that users should not have refer
On 2015-01-31, sebb wrote:
> On 31 January 2015 at 09:03, Stefan Bodewig wrote:
>> On 2015-01-31, sebb wrote:
>>> Given that the protected fields were in a class marked as internal, it
>>> seems arguable that users should not have referred to any of the items
>>> in it.
>>> Therefore we could po
On 31 January 2015 at 09:03, Stefan Bodewig wrote:
> On 2015-01-31, sebb wrote:
>
>> Given that the protected fields were in a class marked as internal, it
>> seems arguable that users should not have referred to any of the items
>> in it.
>> Therefore we could potentially make all the mutable pro
On 2015-01-31, sebb wrote:
> Given that the protected fields were in a class marked as internal, it
> seems arguable that users should not have referred to any of the items
> in it.
> Therefore we could potentially make all the mutable protected fields
> private (and add protected getters).
Even
On 31 January 2015 at 00:10, sebb wrote:
> On 30 January 2015 at 15:41, sebb wrote:
>> I've just had a look at the new class ZCompressorInputStream.
>
> Sorry, I meant LZWInputStream
Which I just realised is mainly a copy of the internal version. Pity
the SVN history does not show this.
Given t
On 30 January 2015 at 15:41, sebb wrote:
> I've just had a look at the new class ZCompressorInputStream.
Sorry, I meant LZWInputStream
> This has lots of mutable protected fields.
>
> For example,
>
> protected int clearCode = -1;
> protected int codeSize = 9;
>
> clearCode has a protect
ns.apache.org
>Sent: Friday, January 30, 2015 10:27 AM
>Subject: [VOTE] Release Compress 1.10 based on RC2
>
>
>OK, next attempt.
>
>Compress 1.10 RC2 is available for review here:
>https://dist.apache.org/repos/dist/dev/commons/compress/
>(svn revision
I've just had a look at the new class ZCompressorInputStream.
This has lots of mutable protected fields.
For example,
protected int clearCode = -1;
protected int codeSize = 9;
clearCode has a protected setter, but no getter.
What's the point of that?
As far as I can tell, these are fie
OK, next attempt.
Compress 1.10 RC2 is available for review here:
https://dist.apache.org/repos/dist/dev/commons/compress/
(svn revision 7884)
Maven artifacts are here:
https://repository.apache.org/content/repositories/orgapachecommons-1081/org/apache/commons/commons-compress/1.10/
