On 31 January 2015 at 00:10, sebb <seb...@gmail.com> wrote: > On 30 January 2015 at 15:41, sebb <seb...@gmail.com> wrote: >> I've just had a look at the new class ZCompressorInputStream. > > Sorry, I meant LZWInputStream
Which I just realised is mainly a copy of the internal version. Pity the SVN history does not show this. Given that the protected fields were in a class marked as internal, it seems arguable that users should not have referred to any of the items in it. Therefore we could potentially make all the mutable protected fields private (and add protected getters). If we don't do that now, it won't be possible to do it later without breaking the non-internal API. If it is considered unsafe to make the fields private, at the very least I think we should deprecate them and add getters instead. So I will vote -1 for this RC. >> This has lots of mutable protected fields. >> >> For example, >> >> protected int clearCode = -1; >> protected int codeSize = 9; >> >> clearCode has a protected setter, but no getter. >> What's the point of that? >> >> As far as I can tell, these are fields new to 1.10 (I could be wrong), >> if so, I think they should be made private and accessed through >> getters/setters. >> >> Classes that publish mutable fields are almost impossible to test >> properly and cannot be made thread-safe. >> >> >> On 30 January 2015 at 12:27, Stefan Bodewig <bode...@apache.org> wrote: >>> OK, next attempt. >>> >>> Compress 1.10 RC2 is available for review here: >>> https://dist.apache.org/repos/dist/dev/commons/compress/ >>> (svn revision 7884) >>> >>> Maven artifacts are here: >>> >>> https://repository.apache.org/content/repositories/orgapachecommons-1081/org/apache/commons/commons-compress/1.10/ >>> >>> Details of changes since 1.9 are in the release notes: >>> >>> https://dist.apache.org/repos/dist/dev/commons/compress/RELEASE-NOTES.txt >>> http://people.apache.org/~bodewig/compress-1.10-RC2/changes-report.html >>> >>> The tag is here: >>> >>> http://svn.apache.org/repos/asf/commons/proper/compress/tags/COMPRESS-1.10-RC2/ >>> (svn revision 1655959) >>> >>> Site: >>> http://people.apache.org/~bodewig/compress-1.10-RC2/ >>> (this is close but not identical to the site I'm going to deploy >>> once the vote has passed. I'll adjust the release notes and publish >>> the Javadocs of 1.10.) >>> >>> Clirr Report (compared to 1.9): >>> http://people.apache.org/~bodewig/compress-1.10-RC2/clirr-report.html >>> >>> RAT Report: >>> http://people.apache.org/~bodewig/compress-1.10-RC2/rat-report.html >>> >>> KEYS: >>> https://www.apache.org/dist/commons/KEYS >>> >>> Please review the release candidate and vote. >>> This vote will close no sooner that 72 hours from now, i.e. after >>> 1230 GMT 02-February 2015 >>> >>> [ ] +1 Release these artifacts >>> [ ] +0 OK, but... >>> [ ] -0 OK, but really should fix... >>> [ ] -1 I oppose this release because... >>> >>> Stefan >>> >>> --------------------------------------------------------------------- >>> To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org >>> For additional commands, e-mail: dev-h...@commons.apache.org >>> --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
