Re: [VOTE] Release Apache Commons BCEL 6.6.1 based on RC2

2022-11-02 Thread Gary Gregory
Good spot, luckily the semantics are the same (the key will be present > on the 2nd invocation); I'll fix it post-release. > > > > Gary > > > > > > > > Mark > > > > > > -Original Message- > > > From: Gary D. Gregory [mailto:ggreg.

RE: [VOTE] Release Apache Commons BCEL 6.6.1 based on RC2

2022-11-02 Thread Gary D. Gregory
Gregory [mailto:ggreg...@apache.org] > > Sent: Tuesday, November 1, 2022 10:17 AM > > To: dev@commons.apache.org > > Subject: Re: [VOTE] Release Apache Commons BCEL 6.6.1 based on RC2 > > > > ping :-) > > > > On 2022/10/29 16:35:28 Gary Gregory wrote: >

RE: [VOTE] Release Apache Commons BCEL 6.6.1 based on RC2

2022-11-02 Thread Gary D. Gregory
present on the 2nd invocation); I'll fix it post-release. Gary > > Mark > > -Original Message- > From: Gary D. Gregory [mailto:ggreg...@apache.org] > Sent: Tuesday, November 1, 2022 10:17 AM > To: dev@commons.apache.org > Subject: Re: [VOTE] Release Apache Commo

RE: [VOTE] Release Apache Commons BCEL 6.6.1 based on RC2

2022-11-02 Thread Mark Roberts
AM To: dev@commons.apache.org Subject: Re: [VOTE] Release Apache Commons BCEL 6.6.1 based on RC2 ping :-) On 2022/10/29 16:35:28 Gary Gregory wrote: > We have fixed a regression bug since Apache Commons BCEL 6.6.0 was > released, so I would like to release Apache Commons BCEL 6.6.1. > > Apa

Re: [VOTE] Release Apache Commons BCEL 6.6.1 based on RC2

2022-11-02 Thread Alex Herbert
On Wed, 2 Nov 2022 at 14:36, Gary D. Gregory wrote: > > JApiCmp > > > > New method: org.apache.bcel.verifier.PassVerifier.getMessageList() has > > no @Since tag and no documented @return tag. > > > > A recent change to remove all the initialisation in the inner class > > org.apache.bcel.generic.In

Re: [VOTE] Release Apache Commons BCEL 6.6.1 based on RC2

2022-11-02 Thread Gary D. Gregory
I updated git master for consistency to use the URL that does not redirect. On 2022/11/02 14:42:05 "Gary D. Gregory" wrote: > Note that https://commons.apache.org/bcel redirects to > https://commons.apache.org/proper/commons-bcel > > On 2022/11/02 14:15:44 Alex Herbert wrote: > > Validated signa

Re: [VOTE] Release Apache Commons BCEL 6.6.1 based on RC2

2022-11-02 Thread Gary D. Gregory
Note that https://commons.apache.org/bcel redirects to https://commons.apache.org/proper/commons-bcel On 2022/11/02 14:15:44 Alex Herbert wrote: > Validated signatures using > > svn co https://dist.apache.org/repos/dist/dev/commons/bcel/6.6.1-RC2 > cd 6.6.1-RC2/ > chmod +x signature-validator.sh

Re: [VOTE] Release Apache Commons BCEL 6.6.1 based on RC2

2022-11-02 Thread Gary D. Gregory
Thank you for the review, my comments are inline below. On 2022/11/02 14:15:44 Alex Herbert wrote: > Validated signatures using > > svn co https://dist.apache.org/repos/dist/dev/commons/bcel/6.6.1-RC2 > cd 6.6.1-RC2/ > chmod +x signature-validator.sh > ./signature-validator.sh > https://repositor

Re: [VOTE] Release Apache Commons BCEL 6.6.1 based on RC2

2022-11-02 Thread Alex Herbert
Validated signatures using svn co https://dist.apache.org/repos/dist/dev/commons/bcel/6.6.1-RC2 cd 6.6.1-RC2/ chmod +x signature-validator.sh ./signature-validator.sh https://repository.apache.org/content/repositories/orgapachecommons-1605/org/apache/bcel/bcel/6.6.1/ Built from the source tar usi

Re: [VOTE] Release Apache Commons BCEL 6.6.1 based on RC2

2022-11-02 Thread Gary D. Gregory
pong? On 2022/11/01 17:16:57 "Gary D. Gregory" wrote: > ping :-) > > On 2022/10/29 16:35:28 Gary Gregory wrote: > > We have fixed a regression bug since Apache Commons BCEL 6.6.0 was > > released, so I would like to release Apache Commons BCEL 6.6.1. > > > > Apache Commons BCEL 6.6.1 RC2 is avai

Re: [VOTE] Release Apache Commons BCEL 6.6.1 based on RC2

2022-11-01 Thread Gary D. Gregory
ping :-) On 2022/10/29 16:35:28 Gary Gregory wrote: > We have fixed a regression bug since Apache Commons BCEL 6.6.0 was > released, so I would like to release Apache Commons BCEL 6.6.1. > > Apache Commons BCEL 6.6.1 RC2 is available for review here: > https://dist.apache.org/repos/dist/dev/c

Re: [VOTE] Release Apache Commons BCEL 6.6.1 based on RC2

2022-10-31 Thread Bruno Kinoshita
[x] +1 Release these artifacts Build passing OK from tag, with `mvn clean test install site` on: Apache Maven 3.8.5 (3599d3414f046de2324203b78ddcf9b5e4388aa0) Maven home: /opt/apache-maven-3.8.5 Java version: 17.0.4, vendor: Private Build, runtime: /usr/lib/jvm/java-17-openjdk-amd64 Default lo

[VOTE] Release Apache Commons BCEL 6.6.1 based on RC2

2022-10-29 Thread Gary Gregory
We have fixed a regression bug since Apache Commons BCEL 6.6.0 was released, so I would like to release Apache Commons BCEL 6.6.1. Apache Commons BCEL 6.6.1 RC2 is available for review here: https://dist.apache.org/repos/dist/dev/commons/bcel/6.6.1-RC2 (svn revision 57656) The Git tag commons