Hello All,
I'm closing the VOTE, 72 hours are over
The VOTE was successful, it receives 3 binding +1 Rob Tompkins, Gary
Gregory, Gilles Sadowski
On Fri, 1 Feb 2019 at 20:49, Gilles Sadowski wrote:
>
> Hi.
>
> Le jeu. 31 janv. 2019 à 12:23, Maxim Solodovnik a
> écrit :
> >
> > This is a [VOTE]
Hi.
Le jeu. 31 janv. 2019 à 12:23, Maxim Solodovnik a écrit :
>
> This is a [VOTE] for releasing
> Apache Commons collections 4.3
>
> Tag name:
> collections-4.3-RC2 (signature can be checked from git using 'git tag
> -v')
>
> Previous RC2 VOTE was canceled due to long discussion regarding
>
+1
>From the RC tag:
RAT Check OK.
Building on Java 11 OK with: mvn -V clean package site
-Dcommons.jacoco.version=0.8.3
Apache Maven 3.6.0 (97c98ec64a1fdfee7767ce5ffb20918da4f719f3;
2018-10-24T14:41:47-04:00)
Maven home: C:\Java\apache-maven-3.6.0\bin\..
Java version: 11.0.2, vendor: Oracle Co
Doh…pardon the noise….reading through the emails just now.
+1 (binding)
signatures all match, rat, good, java8, java11 both work with tests (Assuming
you upversion jacoco for 11), and I believe that with japicmp, the clirr
failures are no longer valid.
-Rob
> On Jan 31, 2019, at 6:23 AM, Ma
> On Jan 31, 2019, at 6:22 AM, Maxim Solodovnik wrote:
>
> The VOTE in this thread has been canceled
Just copy and paste in the RC2 original [VOTE] email, and re-start it. I’ll +1
it.
>
> On Thu, 31 Jan 2019 at 16:11, sebb wrote:
>
>> +1, it has become very messy
>>
>> Cancel this vote
> On Jan 31, 2019, at 4:11 AM, sebb wrote:
>
> +1, it has become very messy
One way or another I am a +1 (binding).
I’ve tested the signatures, and the builds in java8 and java11. Both work. You
guys can decide how you want to proceed with the documentation of the [VOTE].
-Rob
>
> Cancel
This is a [VOTE] for releasing
Apache Commons collections 4.3
Tag name:
collections-4.3-RC2 (signature can be checked from git using 'git tag
-v')
Previous RC2 VOTE was canceled due to long discussion regarding
Clirr report [1]. To resolve this Japicmp report has been created [2] as
well
simp
The VOTE in this thread has been canceled
On Thu, 31 Jan 2019 at 16:11, sebb wrote:
> +1, it has become very messy
>
> Cancel this vote thread and start another
>
> On Thu, 31 Jan 2019 at 08:42, Gilles Sadowski
> wrote:
> >
> > Hello Maxim.
> >
> > Le jeu. 31 janv. 2019 à 05:42, Maxim Solodovni
+1, it has become very messy
Cancel this vote thread and start another
On Thu, 31 Jan 2019 at 08:42, Gilles Sadowski wrote:
>
> Hello Maxim.
>
> Le jeu. 31 janv. 2019 à 05:42, Maxim Solodovnik a
> écrit :
> >
> > This release need your VOTES :)))
>
> The contents on which to vote is buried wit
Hello Maxim.
Le jeu. 31 janv. 2019 à 05:42, Maxim Solodovnik a écrit :
>
> This release need your VOTES :)))
The contents on which to vote is buried within many levels of
indentation; could you please post a clean message, with links
to the RC files, BC test, and the conclusion of this long disc
This release need your VOTES :)))
On Sun, 27 Jan 2019 at 19:47, Maxim Solodovnik wrote:
> Hello All,
>
> Thanks to the Rob, I was able to create "compatibility report" using
> japicmp
> It looks green :)
>
> Would it be OK if I will replace clirr report in generated site with
> japicmp report?
>
I believe that the [VOTE] thread is still out there. As I’ve already done build
validation, I’m going to do signature validation now. I’ll dig the thread up
and add my vote.
-Rob
> On Jan 30, 2019, at 9:02 AM, Gilles Sadowski wrote:
>
> Le mer. 30 janv. 2019 à 14:56, Maxim Solodovnik
Le mer. 30 janv. 2019 à 14:56, Maxim Solodovnik a écrit :
>
> Latest version of test [2] shows all errors are false positive
Great; I missed that (sorry).
Then, there is no reason to change the major version number.
Is this still the [VOTE] thread?
Regards,
Gilles
>
> On Wed, 30 Jan 2019
The RC seems fine. The new test can be added post release.
Gary
On Wed, Jan 30, 2019, 08:23 Gilles Sadowski Hi.
>
> Le mer. 30 janv. 2019 à 13:16, Rob Tompkins a écrit :
> >
> >
> >
> > > On Jan 30, 2019, at 1:12 AM, Maxim Solodovnik
> wrote:
> > >
> > > Hello All,
> > >
> > > It seems my prev
Latest version of test [2] shows all errors are false positive
On Wed, 30 Jan 2019 at 20:23, Gilles Sadowski wrote:
> Hi.
>
> Le mer. 30 janv. 2019 à 13:16, Rob Tompkins a écrit :
> >
> >
> >
> > > On Jan 30, 2019, at 1:12 AM, Maxim Solodovnik
> wrote:
> > >
> > > Hello All,
> > >
> > > I
Hi.
Le mer. 30 janv. 2019 à 13:16, Rob Tompkins a écrit :
>
>
>
> > On Jan 30, 2019, at 1:12 AM, Maxim Solodovnik wrote:
> >
> > Hello All,
> >
> > It seems my previous post was missed somehow
> > so will re-post here:
> >
> > I have added japicmp report here: [1] is has none issues
> >
>
> What
> On Jan 30, 2019, at 1:12 AM, Maxim Solodovnik wrote:
>
> Hello All,
>
> It seems my previous post was missed somehow
> so will re-post here:
>
> I have added japicmp report here: [1] is has none issues
>
What do folks think about [1]? It looks much more promising than the clirr
report.
Hello All,
It seems my previous post was missed somehow
so will re-post here:
I have added japicmp report here: [1] is has none issues
Additionally I have updated gist [2] it also show there are no issues
In case this is not enough I propose to cancel RC2 and to release 5.0
[1]
https://dist.ap
The bottom line is that new interface method in Collections 4.3 MUST be
default methods to avoid blowing up code. This is possible since Collection
now requires Java 8.
Gary
On Mon, Jan 28, 2019 at 2:53 PM Rob Tompkins wrote:
>
>
> > On Jan 28, 2019, at 2:35 PM, sebb wrote:
> >
> > On Mon, 28
On Mon, Jan 28, 2019 at 2:21 PM Pascal Schumacher
wrote:
> Am 28.01.2019 um 20:01 schrieb Rob Tompkins:
> > Before I vote on the the thread, does adding a method to an interface
> cause BC to break?
>
> "Adding a method to an interface does not break compatibility with
> pre-existing binaries."
>
Hello All,
I have added japicmp report here:
https://dist.apache.org/repos/dist/dev/commons/collections/4.3-RC2/site/japicmp.html
I see no issues here :(
On Tue, 29 Jan 2019 at 03:03, Marcelo Vanzin
wrote:
> On Mon, Jan 28, 2019 at 11:36 AM sebb wrote:
> > > Haven't looked at the code, but if
On Mon, Jan 28, 2019 at 11:36 AM sebb wrote:
> > Haven't looked at the code, but if it's being compiled for java 8, and
> > the new methods have a default implementation, then it's fine. clirr
> > just complains because it's too old to know about default methods.
>
> I don't think so.
>
> I think
> On Jan 28, 2019, at 2:35 PM, sebb wrote:
>
> On Mon, 28 Jan 2019 at 19:22, Marcelo Vanzin
> wrote:
>>
>> Haven't looked at the code, but if it's being compiled for java 8, and
>> the new methods have a default implementation, then it's fine. clirr
>> just complains because it's too old to
On Mon, 28 Jan 2019 at 19:22, Marcelo Vanzin
wrote:
>
> Haven't looked at the code, but if it's being compiled for java 8, and
> the new methods have a default implementation, then it's fine. clirr
> just complains because it's too old to know about default methods.
I don't think so.
I think Cli
Ok good enough. Then I’ll finish up looking at the signatures in a bit. Will be
spotty today. I’m flying from Florida back to Virginia.
-Rob
> On Jan 28, 2019, at 2:22 PM, Marcelo Vanzin
> wrote:
>
> Haven't looked at the code, but if it's being compiled for java 8, and
> the new methods hav
Haven't looked at the code, but if it's being compiled for java 8, and
the new methods have a default implementation, then it's fine. clirr
just complains because it's too old to know about default methods.
On Mon, Jan 28, 2019 at 11:18 AM Rob Tompkins wrote:
>
> @Marcelo - Many thanks...Yes. Tha
Am 28.01.2019 um 20:01 schrieb Rob Tompkins:
Before I vote on the the thread, does adding a method to an interface cause BC
to break?
"Adding a method to an interface does not break compatibility with
pre-existing binaries."
Source:
https://docs.oracle.com/javase/specs/jls/se7/html/jls-13.
@Marcelo - Many thanks...Yes. That makes sense. Thanks. Seems like this release
should be a -1 then because we’re breaking BC without a major version change.
Right??
-Rob
> On Jan 28, 2019, at 2:07 PM, Marcelo Vanzin
> wrote:
>
> On Mon, Jan 28, 2019 at 11:01 AM Rob Tompkins wrote:
>> Befo
On Mon, Jan 28, 2019 at 11:01 AM Rob Tompkins wrote:
> Before I vote on the the thread, does adding a method to an interface cause
> BC to break? I would think not. All of the clirr errors are merely additions.
> Further the JAPICMP report confirms this.
Existing classes that implement the inte
Before I vote on the the thread, does adding a method to an interface cause BC
to break? I would think not. All of the clirr errors are merely additions.
Further the JAPICMP report confirms this.
I’m validating the remainder of the release now, and wanted to ask the above
question before adding
Hello All,
Thanks to the Rob, I was able to create "compatibility report" using japicmp
It looks green :)
Would it be OK if I will replace clirr report in generated site with
japicmp report?
Or I need to restart the VOTE?
On Sun, 20 Jan 2019 at 20:48, Gary Gregory wrote:
> We might as well sta
Thanks a million!
On Sun, 27 Jan 2019 at 00:07, Rob Tompkins wrote:
> Sure.
>
> I cloned down your tag, added these lines to the pom.xml:
>
> https://github.com/apache/commons-text/blob/master/pom.xml#L59-L63
>
> and
>
> https://github.com/apache/commons-text/blob/master/pom.xml#L132-L138
> (exc
Sure.
I cloned down your tag, added these lines to the pom.xml:
https://github.com/apache/commons-text/blob/master/pom.xml#L59-L63
and
https://github.com/apache/commons-text/blob/master/pom.xml#L132-L138 (except
just in the plugins part of the build section)
then you run
mvn japicmp:cmp
I c
Hello Rob,
can you please share brief how-to, so I can regenerate the report? :)
On Sat, 26 Jan 2019 at 02:04, Rob Tompkins wrote:
> Just an FYI, I hacked this together for the sake of reporting on solomax’s
> work:
>
> Cheers,
> -Rob
>
>
>
> > On Jan 20, 2019, at 8:48 AM, Gary Gregory
> wrote
Just an FYI, I hacked this together for the sake of reporting on solomax’s work:
Cheers,
-Rob
> On Jan 20, 2019, at 8:48 AM, Gary Gregory wrote:
>
> We might as well start with releasing fresh versions of our internal maven
> plugins, then commons-parent, then components... ;-) More work for
We might as well start with releasing fresh versions of our internal maven
plugins, then commons-parent, then components... ;-) More work for the RM!
:-)
Gary
On Sun, Jan 20, 2019 at 5:06 AM Gilles Sadowski
wrote:
> Le dim. 20 janv. 2019 à 04:56, Maxim Solodovnik a
> écrit :
> >
> > I can see
Le dim. 20 janv. 2019 à 04:56, Maxim Solodovnik a écrit :
>
> I can see there is activity with replacing clirr with japicmp, maybe it
> worth to hold this release until commons-parent v48 will be released?
You are the manager. :-)
Gilles
>
> On Sun, 20 Jan 2019 at 05:52, Gilles Sadowski wrote:
I can see there is activity with replacing clirr with japicmp, maybe it
worth to hold this release until commons-parent v48 will be released?
On Sun, 20 Jan 2019 at 05:52, Gilles Sadowski wrote:
> Hi.
>
> Le sam. 19 janv. 2019 à 11:36, Maxim Solodovnik a
> écrit :
> >
> > I'm afraid I need help
Hi.
Le sam. 19 janv. 2019 à 11:36, Maxim Solodovnik a écrit :
>
> I'm afraid I need help with this
> since I don't understand why clirr reports these errors
Nobody knows around here; but your test demonstrates that one of the
errors is a false positive.
So I suggest that, for good measure, you a
t; > > release.
> > > > > > >> > > > > > >
> > > > > > >> > > > > > >
> > > > > > >> > > > > > > > Alternatively, we c
; > > >> > > > > > > > Opinions?
> > > > > >> > > > > > > >
> > > > > >> > > > > > > > Gilles
> > > > > >> > > > > >
t; > >> > > > > > > > > these
> > > > >> > > > > > > > > errors.
> > > > >> > > > > > > > >
> > > > >> > > > > > > > > For this re
t; to
> > > >> > > > > > > > > have
> > > >> > > > > > > > > revapi replacing clirr.
> > > >> > > > > > > > >
> > > >> > > > > &g
gt;
> > >> > > > > > > >
> > >> > > > > > >
> > >> > > > >
> > >> > >
> > >>
> https://github.com/apache/commons-collections/commit/482762a13f739631f94d03642b0a55a9b7214c44
> > >>
9 at 11:53 AM Amey Jadiye <
> >> > > ameyjad...@gmail.com>
> >> > > > > > > > > wrote:
> >> > > > > > > > >
> >> > > > > > > > >> I spared little time on finding issue howe
t/482762a13f739631f94d03642b0a55a9b7214c44
> >> > > > > > > > >
> >> > > > > > > > > Regards,
> >> > > > > > > > > Amey
> >> > > > > > > > >
> >> > > > > > > > >
> >> > > > > > > > > On Thu, Jan 3, 2019 at 11:53 AM Amey Jadiye &l
> > > > > > > > >> any
>> > > > > > > > >> issues. also I saw that few other apache commons modules
>> > > having
>> > > > > same
>> > > > > > > > >> issue
&g
> > >>
> > > > > > > > >> Regards,
> > > > > > > > >> Amey
> > > > > > > > >>
> > > > > > > > >> On Wed, 2 Jan 2019, 12:31 pm Maxim Solodovnik &l
ked clirr report one more time
> > > > > > > >>> This time I took 1 error and perform investigation:
> > > > > > > >>>
> > > > > > > >>> "Method 'public java.util.Colle
; > > > > >>>
> > > > > > >>> In fact I don't understand why this error was reported
> > > > > > >>> BidiMap extends java.util.Map
> > > > > > >>> Map has method "public ja
> > >>> Map has method "public java.util.Collection values()" in all
> > > > > >>> versions:
> > > > > >>> https://docs.oracle.com/javase/6/docs/api/java/util/Map.html
> > > > > >>> https://docs.oracle.com/javase/7/docs/api/java/util/Map.html
> > > > &
l
> > > > >>>
> > > > >>> Maybe its clirr issue?
> > > > >>> Would appreciate any help with this investigation
> > > > >>>
> > > > >>> On Mon, 31 Dec 2018 at 16:53, Gilles <
> gil...@harfang.homelinux.org>
> > > > >
are caused by previous
> > > >>> > > release
> > > >>> > > 4.3 doesn't introduce any new errors ...
> > > >>> > >
> > > >>> > > [1] https://markmail.org/message/l7ftxlvdk4yqxijt
> > > >>>
; > 4.3 doesn't introduce any new errors ...
> > >>> > >
> > >>> > > [1] https://markmail.org/message/l7ftxlvdk4yqxijt
> > >>> >
> > >>> > I had seen the post but it says:
> > >>> > ---
> > >>
ave been mentioned in the release notes
> >>> > and/or the [VOTE] email, in order to avoid further questioning.
> >>> >
> >>> > Is the cause the change of supported JDK?
> >>> >
> >>> > Regards,
> >>>
nges comparing to
> >>> 4.2
> >>> > ---
> >>> >
> >>> > But IMHO it was not a conclusion: If the cause of the errors was
> >>> > identified, it could have been mentioned in the release notes
> >>> > and/or the [VOTE] email, in order to avoid further questioning.
>
changes comparing to
> >>> 4.2
> >>> > ---
> >>> >
> >>> > But IMHO it was not a conclusion: If the cause of the errors was
> >>> > identified, it could have been mentioned in the release notes
> >>> >
; > Is there anything wrong with the RC?
> >> >
> >> >> On Thu, 27 Dec 2018 at 05:20, Bruno P. Kinoshita
> >> wrote:
> >> >>
> >> >> FWIW I had a similar experience, and realized I was doing
`git
> >> fetch --all`, but it di
; > >> -Rob
>> > >>
>> > >> > On Dec 30, 2018, at 12:25 AM, Maxim Solodovnik
>> > >> wrote:
>> > >> >
>> > >> > No votes after 3 days :(
>> > >> > Is there anything wro
I am slowly coming back to FOSS setting up a new laptop and house... may
someone summarize where we stand on this vote?
Gary
On Wed, Dec 26, 2018 at 8:42 AM Maxim Solodovnik
wrote:
> This is a [VOTE] for releasing
> Apache Commons collections 4.3
>
> Tag name:
> collections-4.3-RC2 (signatu
t; > >> wrote:
> > >> >>
> > >> >> FWIW I had a similar experience, and realized I was doing `git
> > >> fetch --all`, but it didn't bring the tags. `git fetch --tags` did the
> > >> trick. After that I could `git check
tonight or in the morning.
> >> >>
> >> >> -Rob
> >> >>
> >> >> > On Dec 30, 2018, at 12:25 AM, Maxim Solodovnik
> >> >> wrote:
> >> >> >
> >> >> > No votes after 3 days :(
> >> >> > Is there anything wrong with the RC?
>
>> >> FWIW I had a similar experience, and realized I was doing
`git
>> fetch --all`, but it didn't bring the tags. `git fetch --tags`
did the
>> trick. After that I could `git checkout $tag-name`
>> >>
>> >> Cheers
>> >> B
FWIW I had a similar experience, and realized I was doing `git
>> fetch --all`, but it didn't bring the tags. `git fetch --tags`
did the
>> trick. After that I could `git checkout $tag-name`
>> >>
>> >> Cheers
>> >> Bruno
>> >>
>>
zed I was doing `git
> >> fetch --all`, but it didn't bring the tags. `git fetch --tags` did the
> >> trick. After that I could `git checkout $tag-name`
> >> >>
> >> >> Cheers
> >> >> Bruno
> >> >>
> >> >>
> >
>>
>>
>>
>>
>> From: Gilles
>> To: dev@commons.apache.org
>> Sent: Thursday, 27 December 2018 9:26 AM
>> Subject: Re: [VOTE][RC2] Commons collections 4.3
>>
>>
>>
>>> On Wed, 26 Dec 2018
t; >>
> >> ________
> >> From: Gilles
> >> To: dev@commons.apache.org
> >> Sent: Thursday, 27 December 2018 9:26 AM
> >> Subject: Re: [VOTE][RC2] Commons collections 4.3
> >>
> >>
> >>
&g
>> From: Gilles
>> To: dev@commons.apache.org
>> Sent: Thursday, 27 December 2018 9:26 AM
>> Subject: Re: [VOTE][RC2] Commons collections 4.3
>>
>>
>>
>>> On Wed, 26 Dec 2018 21:21:34 +0100, Gilles wrote:
>>> Hi.
>
26 AM
Subject: Re: [VOTE][RC2] Commons collections 4.3
On Wed, 26 Dec 2018 21:21:34 +0100, Gilles wrote:
> Hi.
>
> On Wed, 26 Dec 2018 20:41:59 +0700, Maxim Solodovnik wrote:
>> This is a [VOTE] for releasing
>> Apache Commons collections 4.3
>>
>> Tag name:
>
From: Maxim Solodovnik
To: Commons Developers List
Sent: Thursday, 27 December 2018 2:42 AM
Subject: [VOTE][RC2] Commons collections 4.3
This is a [VOTE] for releasing
Apache Commons collections 4.3
Tag name:
collections-4.3-RC2 (signature can be
unday, 30 December 2018 6:26 PM
Subject: Re: [VOTE][RC2] Commons collections 4.3
No votes after 3 days :(
Is there anything wrong with the RC?
On Thu, 27 Dec 2018 at 05:20, Bruno P. Kinoshita wrote:
>
> FWIW I had a similar experience, and realized I was doing `git fetch --all`,
>
> could `git checkout $tag-name`
>
> Cheers
> Bruno
>
>
>
>
>
> From: Gilles
> To: dev@commons.apache.org
> Sent: Thursday, 27 December 2018 9:26 AM
> Subject: Re: [VOTE][RC2] Commons collections 4.3
>
>
>
> On Wed,
y, 27 December 2018 9:26 AM
Subject: Re: [VOTE][RC2] Commons collections 4.3
On Wed, 26 Dec 2018 21:21:34 +0100, Gilles wrote:
> Hi.
>
> On Wed, 26 Dec 2018 20:41:59 +0700, Maxim Solodovnik wrote:
>> This is a [VOTE] for releasing
>> Apache Commons collections 4.3
>>
On Wed, 26 Dec 2018 21:21:34 +0100, Gilles wrote:
Hi.
On Wed, 26 Dec 2018 20:41:59 +0700, Maxim Solodovnik wrote:
This is a [VOTE] for releasing
Apache Commons collections 4.3
Tag name:
collections-4.3-RC2 (signature can be checked from git using
'git
tag -v')
$ git tag -v collections-
Hi.
On Wed, 26 Dec 2018 20:41:59 +0700, Maxim Solodovnik wrote:
This is a [VOTE] for releasing
Apache Commons collections 4.3
Tag name:
collections-4.3-RC2 (signature can be checked from git using 'git
tag -v')
$ git tag -v collections-4.3-RC2
error: tag 'collections-4.3-RC2' not found.
This is a [VOTE] for releasing
Apache Commons collections 4.3
Tag name:
collections-4.3-RC2 (signature can be checked from git using 'git tag -v')
RC1 was cancelled due to some release steps were not done
Tag URL:
https://gitbox.apache.org/repos/asf?p=commons-collections.git;a=commit;h=7
76 matches
Mail list logo