Hello,
Perso not blocker for me, the most important is to have easy setup for
ide and checkstyle files configured and not loose to much time with
that.
IMHO it's just a "taste" question (in my country some prefers Bordeaux
and others Bourgogne :-) ).
/Olivier
2011/5/16 Simone Tripodi :
> Hi Maur
Hi Maurizio!
indeed, sometimes such style makes me smile because brings back old memories :)
Well, I was too young at '90 to program - anyway I was a SuperMario
champion - but my professors at University used that style :P
Jokes a part, I thought that code style was a trivial topic, but at
this po
Phil probably hit the nail on the head: contributors might have
problem to incorporate patches, the main risk is that every patch
contain a lot of noise and it's not good for the sake of reviewing.
I have no problem with most of the conventions (which are the default
settings of IntelliJ IIRC).
The
Hi guys,
thanks for the feedbacks!!! I understand your concerns, the main
reason behind such proposal is that OGNL already adopted a style that
matches, in the bigger part of the cases, to Maven style, so I thought
it would have been nice having a unique code style.
Simo
http://people.apache.org/~
On 5/15/11 2:44 PM, Konstantin Kolinko wrote:
> 2011/5/14 Simone Tripodi :
>> Hi all guys,
>> OGNL code is formatted using a mixture of various styles, I hope
>> everybody agrees on adopting one unique style.
>> I propose to adopt the Maven Style[1] that is already widely adopted
>> and supported b
On 15 May 2011 22:44, Konstantin Kolinko wrote:
> 2011/5/14 Simone Tripodi :
>> Hi all guys,
>> OGNL code is formatted using a mixture of various styles, I hope
>> everybody agrees on adopting one unique style.
>> I propose to adopt the Maven Style[1] that is already widely adopted
>> and supporte
2011/5/14 Simone Tripodi :
> Hi all guys,
> OGNL code is formatted using a mixture of various styles, I hope
> everybody agrees on adopting one unique style.
> I propose to adopt the Maven Style[1] that is already widely adopted
> and supported by IDEs.
> Thoughts? Objections? If agree I would quic
I see, that's great, thanks!!! :)
I'm in the middle of the process of migrating the tests to junit4, so
if you have spare time to dedicate to OGNL feel free to re-enable the
checkstyle config!
Thanks a lot!!!
Simo
http://people.apache.org/~simonetripodi/
http://www.99soft.org/
On Sat, May 14, 2
they are bundled with the checkstyle plugin (see [1] )
So nothing to do except pom configuration :-)
/Olivier
[1]
http://svn.apache.org/repos/asf/maven/plugins/trunk/maven-checkstyle-plugin/src/main/resources/config/
2011/5/14 Simone Tripodi :
> Merci Olivier!!
> I didn't find where config/mav
Merci Olivier!!
I didn't find where config/maven_checks.xml is! Can you help me please?
Feel free to commit yourself! And thanks!!!
Simo
http://people.apache.org/~simonetripodi/
http://www.99soft.org/
On Sat, May 14, 2011 at 3:50 PM, Olivier Lamy wrote:
> Check the pom here
> http://svn.apach
Check the pom here http://svn.apache.org/repos/asf/maven/pom/trunk/maven/pom.xml
De rien ! :-)
2011/5/14 Simone Tripodi :
> Great! can you point me please to an already existing configuration? I
> guess in Maven core I should find something, no?
> Merci en avant!
> Simo
>
> http://people.apache.o
Great! can you point me please to an already existing configuration? I
guess in Maven core I should find something, no?
Merci en avant!
Simo
http://people.apache.org/~simonetripodi/
http://www.99soft.org/
On Sat, May 14, 2011 at 12:29 PM, Olivier Lamy wrote:
> +1
> Checkstyle configuration wil
+1
Checkstyle configuration will need update
--
Olivier
Le 14 mai 2011 12:10, "Simone Tripodi" a écrit :
> Hi all guys,
> OGNL code is formatted using a mixture of various styles, I hope
> everybody agrees on adopting one unique style.
> I propose to adopt the Maven Style[1] that is already wid
Hi all guys,
OGNL code is formatted using a mixture of various styles, I hope
everybody agrees on adopting one unique style.
I propose to adopt the Maven Style[1] that is already widely adopted
and supported by IDEs.
Thoughts? Objections? If agree I would quickly proceed, just let me know!
SImo
[1
14 matches
Mail list logo
