Re: [LANG] Handling of empty string in StringUtils

2014-01-17 Thread Benedikt Ritter
2014/1/15 Benedikt Ritter > > > > 2014/1/13 Paul Benedict > >> Splitting with an empty string doesn't make any sense to me. Nothing >> should >> match that -- even an empty string. It's a lack of a token. >> > > Okay, and that's the reason why currently > > StringUtils.split("", ".") = [ ] > but

Re: [LANG] Handling of empty string in StringUtils

2014-01-15 Thread Benedikt Ritter
2014/1/13 Paul Benedict > Splitting with an empty string doesn't make any sense to me. Nothing should > match that -- even an empty string. It's a lack of a token. > Okay, and that's the reason why currently StringUtils.split("", ".") = [ ] but StringUtils.split("x", ".") = ["x"] I guess I und

Re: [LANG] Handling of empty string in StringUtils

2014-01-15 Thread Benedikt Ritter
2014/1/15 Gary Gregory > On Wed, Jan 15, 2014 at 1:19 AM, Benedikt Ritter > wrote: > > > I'd like to change the behavior then, if nobody objects. I'll write some > > prose for the release notes of 3.3 (which I plan to roll out early > > February) > > > > Cool. > > Do you plan on reviewing all of

Re: [LANG] Handling of empty string in StringUtils

2014-01-15 Thread Gary Gregory
On Wed, Jan 15, 2014 at 1:19 AM, Benedikt Ritter wrote: > I'd like to change the behavior then, if nobody objects. I'll write some > prose for the release notes of 3.3 (which I plan to roll out early > February) > Cool. Do you plan on reviewing all of [lang], StringUtils, or the subset of Strin

Re: [LANG] Handling of empty string in StringUtils

2014-01-14 Thread Benedikt Ritter
I'd like to change the behavior then, if nobody objects. I'll write some prose for the release notes of 3.3 (which I plan to roll out early February) Benedikt 2014/1/14 sebb > On 14 January 2014 11:53, Duncan Jones wrote: > > On 14 January 2014 11:17, Benedikt Ritter wrote: > >> 2014/1/13 Ga

Re: [LANG] Handling of empty string in StringUtils

2014-01-14 Thread sebb
On 14 January 2014 11:53, Duncan Jones wrote: > On 14 January 2014 11:17, Benedikt Ritter wrote: >> 2014/1/13 Gary Gregory >> >>> On Mon, Jan 13, 2014 at 12:45 PM, sebb wrote: >>> >>> > What does the Javadoc say? >>> > >>> >>> The Javadoc describes the current behavior, which is whacky IMO. Thi

Re: [LANG] Handling of empty string in StringUtils

2014-01-14 Thread Gary Gregory
I'm all for fixing bugs! ;) Gary Original message From: Benedikt Ritter Date:01/14/2014 06:17 (GMT-05:00) To: Commons Developers List Subject: Re: [LANG] Handling of empty string in StringUtils 2014/1/13 Gary Gregory > On Mon, Jan 13, 2014 at 12:45 PM, seb

Re: [LANG] Handling of empty string in StringUtils

2014-01-14 Thread Duncan Jones
On 14 January 2014 11:17, Benedikt Ritter wrote: > 2014/1/13 Gary Gregory > >> On Mon, Jan 13, 2014 at 12:45 PM, sebb wrote: >> >> > What does the Javadoc say? >> > >> >> The Javadoc describes the current behavior, which is whacky IMO. This could >> be a case where the docs documents the code, e

Re: [LANG] Handling of empty string in StringUtils

2014-01-14 Thread Benedikt Ritter
2014/1/13 Gary Gregory > On Mon, Jan 13, 2014 at 12:45 PM, sebb wrote: > > > What does the Javadoc say? > > > > The Javadoc describes the current behavior, which is whacky IMO. This could > be a case where the docs documents the code, even though it does not make > sense. > > It sounds dangerous

Re: [LANG] Handling of empty string in StringUtils

2014-01-13 Thread Gary Gregory
On Mon, Jan 13, 2014 at 12:45 PM, sebb wrote: > What does the Javadoc say? > The Javadoc describes the current behavior, which is whacky IMO. This could be a case where the docs documents the code, even though it does not make sense. It sounds dangerous to change it in a minor release. Gary

Re: [LANG] Handling of empty string in StringUtils

2014-01-13 Thread Paul Benedict
Splitting with an empty string doesn't make any sense to me. Nothing should match that -- even an empty string. It's a lack of a token. On Mon, Jan 13, 2014 at 11:00 AM, Benedikt Ritter wrote: > ping, any thought on this? > > > 2014/1/11 Benedikt Ritter > > > Hi, > > > > while looking through t

Re: [LANG] Handling of empty string in StringUtils

2014-01-13 Thread sebb
What does the Javadoc say? On 13 January 2014 17:00, Benedikt Ritter wrote: > ping, any thought on this? > > > 2014/1/11 Benedikt Ritter > >> Hi, >> >> while looking through the open issues for lang, I came across LANG-823: >> StringUtils.split should handle empty strings the same as other conte

Re: [LANG] Handling of empty string in StringUtils

2014-01-13 Thread Benedikt Ritter
ping, any thought on this? 2014/1/11 Benedikt Ritter > Hi, > > while looking through the open issues for lang, I came across LANG-823: > StringUtils.split should handle empty strings the same as other content > [1]. The request makes sense to me - the empty string should be handled > like any o

[LANG] Handling of empty string in StringUtils

2014-01-11 Thread Benedikt Ritter
Hi, while looking through the open issues for lang, I came across LANG-823: StringUtils.split should handle empty strings the same as other content [1]. The request makes sense to me - the empty string should be handled like any other content. Then I looked into StringUtils to see how other metho