Re: [LANG] Add ThreadUtils

2015-05-04 Thread Benedikt Ritter
Hello Hendrik, 2015-05-04 0:28 GMT+02:00 Hendrik Dev : > Hi Benedikt, > > i have opened a new pull request > https://github.com/apache/commons-lang/pull/78 which is based against > the master branch, contains only a single commit and fixes the issues > you named. > Hope thats ok ... > Thank you.

Re: [LANG] Add ThreadUtils

2015-05-03 Thread Hendrik Dev
Hi Benedikt, i have opened a new pull request https://github.com/apache/commons-lang/pull/78 which is based against the master branch, contains only a single commit and fixes the issues you named. Hope thats ok ... Thanks Hendrik On Sun, Apr 26, 2015 at 11:40 AM, Benedikt Ritter wrote: > Hello

Re: [LANG] Add ThreadUtils

2015-04-26 Thread Benedikt Ritter
Hello Hendrik, 2015-04-22 21:14 GMT+02:00 Hendrik Dev : > based on what i understand from this discussion i did some changes, > pls see > https://github.com/salyh/commons-lang/commit/12edd41ec7563368b03fa540af5c9a127bbfd89d > for the diff and > > https://github.com/salyh/commons-lang/blob/12edd41

Re: [LANG] Add ThreadUtils

2015-04-22 Thread Hendrik Dev
based on what i understand from this discussion i did some changes, pls see https://github.com/salyh/commons-lang/commit/12edd41ec7563368b03fa540af5c9a127bbfd89d for the diff and https://github.com/salyh/commons-lang/blob/12edd41ec7563368b03fa540af5c9a127bbfd89d/src/main/java/org/apache/commons/la

Re: [LANG] Add ThreadUtils

2015-04-14 Thread Peter Ansell
On 13 April 2015 at 19:21, Benedikt Ritter wrote: > 2015-04-13 2:27 GMT+02:00 Matt Benson : > >> +1 to what Peter said: it's a functional interface so it is >> lambda-compatible anyway. >> > > Well, yes it would be a functional interface, but it would lack all the > default methods defined in java

Re: [LANG] Add ThreadUtils

2015-04-13 Thread Benedikt Ritter
2015-04-13 2:27 GMT+02:00 Matt Benson : > +1 to what Peter said: it's a functional interface so it is > lambda-compatible anyway. > Well, yes it would be a functional interface, but it would lack all the default methods defined in java.util.function.Predicate if we don't extend it later. > > Ma

Re: [LANG] Add ThreadUtils

2015-04-12 Thread Matt Benson
+1 to what Peter said: it's a functional interface so it is lambda-compatible anyway. Matt On Apr 12, 2015 6:49 PM, "Peter Ansell" wrote: > On 12 April 2015 at 21:14, Benedikt Ritter wrote: > > Hi, > > > > there is currently a discussion on github about the addition of a low > level utility cla

Re: [LANG] Add ThreadUtils

2015-04-12 Thread Peter Ansell
On 12 April 2015 at 21:14, Benedikt Ritter wrote: > Hi, > > there is currently a discussion on github about the addition of a low level > utility class which helps to retrieve Threads [1]. The latest proposal is to > implement a predicate based approach for filtering threads [2]. My opinion > i

Re: [LANG] Add ThreadUtils

2015-04-12 Thread Peter Ansell
On 12 April 2015 at 21:26, Benedikt Ritter wrote: > > > Send from my mobile device > >> Am 12.04.2015 um 13:19 schrieb Kristian Rosenvold : >> >> If think later (in 2025 :-) you just make interface ThreadPredicate >> extend java.util.function.Predicate. > > Well, isn't that exactly what I suggeste

Re: [LANG] Add ThreadUtils

2015-04-12 Thread Oliver Heger
Am 12.04.2015 um 13:14 schrieb Benedikt Ritter: > Hi, > > there is currently a discussion on github about the addition of a low level > utility class which helps to retrieve Threads [1]. The latest proposal is to > implement a predicate based approach for filtering threads [2]. My opinion > i

Re: [LANG] Add ThreadUtils

2015-04-12 Thread Benedikt Ritter
Send from my mobile device > Am 12.04.2015 um 13:19 schrieb Kristian Rosenvold : > > If think later (in 2025 :-) you just make interface ThreadPredicate > extend java.util.function.Predicate. Well, isn't that exactly what I suggested? :o) > > Kristian > > > 2015-04-12 13:14 GMT+02:00 Bened

Re: [LANG] Add ThreadUtils

2015-04-12 Thread Kristian Rosenvold
If think later (in 2025 :-) you just make interface ThreadPredicate extend java.util.function.Predicate. Kristian 2015-04-12 13:14 GMT+02:00 Benedikt Ritter : > Hi, > > there is currently a discussion on github about the addition of a low level > utility class which helps to retrieve Threads [1

[LANG] Add ThreadUtils

2015-04-12 Thread Benedikt Ritter
Hi, there is currently a discussion on github about the addition of a low level utility class which helps to retrieve Threads [1]. The latest proposal is to implement a predicate based approach for filtering threads [2]. My opinion is, that we should not add such an API at all, because we would