This should likely be one PR, see comments in the PR. In general, when you
submit a fix in a PR, it should contain changes to both main and test. The
test changed or added to the test folder should fail without the changes to
main.
Gary
On Wed, Apr 19, 2023, 01:30 Miguel Muñoz wrote:
> Today I
Today I resubmitted both changes as Pull Requests.
— Miguel Muñoz
On Tue, Apr 18, 2023 at 3:44 AM Gary Gregory wrote:
> Thanks Miguel,
>
> Please provide changes as PRs on GiHub. This is the best way to go IMO
> because it runs code against all tests on all configured OSs and Java
> versions, a
Thanks Miguel,
Please provide changes as PRs on GiHub. This is the best way to go IMO
because it runs code against all tests on all configured OSs and Java
versions, and provides the least friction for managing changes.
TY!
Gary
On Tue, Apr 18, 2023, 04:20 Miguel Muñoz wrote:
> Developers,
>
>
>
> Or as a Github PR:
>
+1
On Tue, 18 Apr 2023 at 11:18, sebb wrote:
> Or as a Github PR:
>
> https://github.com/apache/commons-io/pulls
>
> These systems are easier for developers to track than emails, which
> can get overlooked.
>
> On Tue, 18 Apr 2023 at 09:54, Gilles Sadowski
> wrote:
> >
Or as a Github PR:
https://github.com/apache/commons-io/pulls
These systems are easier for developers to track than emails, which
can get overlooked.
On Tue, 18 Apr 2023 at 09:54, Gilles Sadowski wrote:
>
> Hi.
>
> Le mar. 18 avr. 2023 à 10:20, Miguel Muñoz a écrit :
> >
> > Developers,
> >
>
Hi.
Le mar. 18 avr. 2023 à 10:20, Miguel Muñoz a écrit :
>
> Developers,
>
> (I'm new to Apache,
Welcome.
> so I hope this is the right way to submit patches.)
The usual way would be to file a report on the bug-tracking system:
https://issues.apache.org/jira/projects/IO
and upload patches th
Developers,
(I'm new to Apache, so I hope this is the right way to submit patches.)
Here are two patches, which must be applied in order.
The first one fixes bugs in the file, and adds a method that will
facilitate testing.
The second one is a thorough unit test that handles issues on Windows
r
