This should likely be one PR, see comments in the PR. In general, when you submit a fix in a PR, it should contain changes to both main and test. The test changed or added to the test folder should fail without the changes to main.
Gary On Wed, Apr 19, 2023, 01:30 Miguel Muñoz <swingguy1...@gmail.com> wrote: > Today I resubmitted both changes as Pull Requests. > > — Miguel Muñoz > > On Tue, Apr 18, 2023 at 3:44 AM Gary Gregory <garydgreg...@gmail.com> > wrote: > > > Thanks Miguel, > > > > Please provide changes as PRs on GiHub. This is the best way to go IMO > > because it runs code against all tests on all configured OSs and Java > > versions, and provides the least friction for managing changes. > > > > TY! > > Gary > > > > On Tue, Apr 18, 2023, 04:20 Miguel Muñoz <swingguy1...@gmail.com> wrote: > > > > > Developers, > > > > > > (I'm new to Apache, so I hope this is the right way to submit patches.) > > > > > > Here are two patches, which must be applied in order. > > > > > > The first one fixes bugs in the file, and adds a method that will > > > facilitate testing. > > > > > > The second one is a thorough unit test that handles issues on Windows > > > relatively cleanly. The test creates temporary files and temporary > > symbolic > > > links for testing. It should run on all platforms, and should run > > correctly > > > on Windows without actually creating symbolic links. I don't have > access > > to > > > a Windows machine, but I tested the windows-only code on my Mac with a > > > simple temporary change to the test for which platform it's running on. > > > (Very little runs differently on Windows.) > > > > > > The patches must be applied in order. The first one changes the class > > > itself, and the second changes the unit test. > > > > > > — Miguel Muñoz > > > > > > > > > > > > --------------------------------------------------------------------- > > > To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org > > > For additional commands, e-mail: dev-h...@commons.apache.org > > >
