[GitHub] commons-validator pull request: URLs with domains with underscore ...

2015-01-23 Thread nykolaslima
Github user nykolaslima closed the pull request at: https://github.com/apache/commons-validator/pull/2 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the f

[GitHub] commons-validator pull request: URLs with domains with underscore ...

2014-11-12 Thread nykolaslima
GitHub user nykolaslima opened a pull request: https://github.com/apache/commons-validator/pull/2 URLs with domains with underscore should be valid. Emails as well. Nowadays, domain with underscore are considered invalid, but they should be valid. e.g. `my_domain.s3.ama