GitHub user nykolaslima opened a pull request:
https://github.com/apache/commons-validator/pull/2
URLs with domains with underscore should be valid. Emails as well.
Nowadays, domain with underscore are considered invalid, but they should be
valid.
e.g.
`my_domain.s3.amazonaws.com` is considered invalid, but it is a valid
domain.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/nykolaslima/commons-validator
domains-with-underscore
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/commons-validator/pull/2.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2
----
commit f19ceb5f817c4f7a2fc4b1c435e3255fc2cbf473
Author: Nykolas Lima <nykolas.l...@gmail.com>
Date: 2014-11-12T18:41:32Z
URLs with domains with underscore should be valid. Emails as well.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org
