Github user asfgit closed the pull request at:
https://github.com/apache/commons-text/pull/56
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user TheRealHaui commented on a diff in the pull request:
https://github.com/apache/commons-text/pull/56#discussion_r129109286
--- Diff:
src/test/java/org/apache/commons/text/ExtendedMessageFormatTest.java ---
@@ -416,6 +416,81 @@ public void testSetFormatsByArgumentIndex()
Github user TheRealHaui commented on a diff in the pull request:
https://github.com/apache/commons-text/pull/56#discussion_r129108740
--- Diff:
src/test/java/org/apache/commons/text/ExtendedMessageFormatTest.java ---
@@ -416,6 +416,81 @@ public void testSetFormatsByArgumentIndex()
Github user TheRealHaui commented on a diff in the pull request:
https://github.com/apache/commons-text/pull/56#discussion_r129106989
--- Diff:
src/test/java/org/apache/commons/text/ExtendedMessageFormatTest.java ---
@@ -416,6 +416,81 @@ public void testSetFormatsByArgumentIndex()
Github user PascalSchumacher commented on a diff in the pull request:
https://github.com/apache/commons-text/pull/56#discussion_r128594766
--- Diff:
src/test/java/org/apache/commons/text/ExtendedMessageFormatTest.java ---
@@ -416,6 +416,81 @@ public void testSetFormatsByArgumentInd
Github user PascalSchumacher commented on a diff in the pull request:
https://github.com/apache/commons-text/pull/56#discussion_r128595088
--- Diff:
src/test/java/org/apache/commons/text/ExtendedMessageFormatTest.java ---
@@ -416,6 +416,81 @@ public void testSetFormatsByArgumentInd
Github user PascalSchumacher commented on a diff in the pull request:
https://github.com/apache/commons-text/pull/56#discussion_r128595517
--- Diff:
src/test/java/org/apache/commons/text/ExtendedMessageFormatTest.java ---
@@ -416,6 +416,81 @@ public void testSetFormatsByArgumentInd
Github user jbduncan commented on a diff in the pull request:
https://github.com/apache/commons-text/pull/56#discussion_r127854299
--- Diff:
src/test/java/org/apache/commons/text/ExtendedMessageFormatTest.java ---
@@ -55,11 +55,11 @@ public void testExtendedFormats() {
Github user jbduncan commented on a diff in the pull request:
https://github.com/apache/commons-text/pull/56#discussion_r127854120
--- Diff: src/test/java/org/apache/commons/text/AlphabetConverterTest.java
---
@@ -201,4 +207,97 @@ private void test(final Character[] originalChars,
Github user jbduncan commented on a diff in the pull request:
https://github.com/apache/commons-text/pull/56#discussion_r127855372
--- Diff:
src/test/java/org/apache/commons/text/ExtendedMessageFormatTest.java ---
@@ -426,10 +517,13 @@ public void testSetFormatsByArgumentIndex() {
Github user jbduncan commented on a diff in the pull request:
https://github.com/apache/commons-text/pull/56#discussion_r127856024
--- Diff:
src/test/java/org/apache/commons/text/similarity/LevenshteinResultsTest.java ---
@@ -0,0 +1,92 @@
+/*
+ * Licensed to the Apache Soft
Github user jbduncan commented on a diff in the pull request:
https://github.com/apache/commons-text/pull/56#discussion_r127854963
--- Diff:
src/test/java/org/apache/commons/text/ExtendedMessageFormatTest.java ---
@@ -353,10 +355,11 @@ private void checkBuiltInFormat(final String p
Github user jbduncan commented on a diff in the pull request:
https://github.com/apache/commons-text/pull/56#discussion_r127854930
--- Diff:
src/test/java/org/apache/commons/text/ExtendedMessageFormatTest.java ---
@@ -338,10 +339,11 @@ private void checkBuiltInFormat(final String p
Github user jbduncan commented on a diff in the pull request:
https://github.com/apache/commons-text/pull/56#discussion_r127854888
--- Diff:
src/test/java/org/apache/commons/text/ExtendedMessageFormatTest.java ---
@@ -338,10 +339,11 @@ private void checkBuiltInFormat(final String p
Github user jbduncan commented on a diff in the pull request:
https://github.com/apache/commons-text/pull/56#discussion_r127855769
--- Diff: src/test/java/org/apache/commons/text/StrSubstitutorTest.java ---
@@ -17,21 +17,16 @@
package org.apache.commons.text;
-i
Github user jbduncan commented on a diff in the pull request:
https://github.com/apache/commons-text/pull/56#discussion_r127854991
--- Diff:
src/test/java/org/apache/commons/text/ExtendedMessageFormatTest.java ---
@@ -353,10 +355,11 @@ private void checkBuiltInFormat(final String p
Github user jbduncan commented on a diff in the pull request:
https://github.com/apache/commons-text/pull/56#discussion_r127855540
--- Diff:
src/test/java/org/apache/commons/text/ExtendedMessageFormatTest.java ---
@@ -476,8 +578,8 @@ public Format getFormat(final String name, final
Github user jbduncan commented on a diff in the pull request:
https://github.com/apache/commons-text/pull/56#discussion_r127854015
--- Diff: src/test/java/org/apache/commons/text/AlphabetConverterTest.java
---
@@ -201,4 +207,97 @@ private void test(final Character[] originalChars,
Github user jbduncan commented on a diff in the pull request:
https://github.com/apache/commons-text/pull/56#discussion_r127854827
--- Diff:
src/test/java/org/apache/commons/text/ExtendedMessageFormatTest.java ---
@@ -295,41 +295,42 @@ public void testEqualsHashcode() {
Github user jbduncan commented on a diff in the pull request:
https://github.com/apache/commons-text/pull/56#discussion_r127855604
--- Diff:
src/test/java/org/apache/commons/text/ExtendedMessageFormatTest.java ---
@@ -488,10 +590,10 @@ public Format getFormat(final String name, fin
Github user jbduncan commented on a diff in the pull request:
https://github.com/apache/commons-text/pull/56#discussion_r127855137
--- Diff:
src/test/java/org/apache/commons/text/ExtendedMessageFormatTest.java ---
@@ -373,14 +376,15 @@ private void checkBuiltInFormat(final String p
GitHub user TheRealHaui opened a pull request:
https://github.com/apache/commons-text/pull/56
add-some-Unit Tests
I have created new Unit Tests which cover previously untested lines of code
which I want to contribute.
You can merge this pull request into a Git repository by running
22 matches
Mail list logo
