Github user jbduncan commented on a diff in the pull request:
https://github.com/apache/commons-text/pull/56#discussion_r127854120
--- Diff: src/test/java/org/apache/commons/text/AlphabetConverterTest.java
---
@@ -201,4 +207,97 @@ private void test(final Character[] originalChars,
final Character[] encodingCha
Assert.assertEquals("Encoded '" + s + "' into '" + encoded +
"', but decoded into '" + decoded + "'", s, decoded);
}
}
+
+ @Test
+ public void testCreateConverterFromCharsWithNullAndNull() {
+
+ Character[] characterArray = new Character[2];
+ characterArray[0] = Character.valueOf('$');
+ characterArray[1] = characterArray[0];
+
+ try {
+ AlphabetConverter.createConverterFromChars(characterArray,
null, null);
+ fail("Expecting exception: IllegalArgumentException");
+ } catch (IllegalArgumentException e) {
+ assertEquals(AlphabetConverter.class.getName(),
e.getStackTrace()[0].getClassName());
+ }
+
--- End diff --
Blank lines at the end of methods, like this one, seem inconsistent with
the rest of the code base.
Please consider removing them from _all_ methods which you've created and
touched.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org
