[GitHub] commons-imaging pull request #35: IMAGING-154 Removed Debug class

Github user asfgit closed the pull request at: https://github.com/apache/commons-imaging/pull/35 --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org

[GitHub] commons-imaging pull request #35: IMAGING-154 Removed Debug class

Github user kinow commented on a diff in the pull request: https://github.com/apache/commons-imaging/pull/35#discussion_r210549560 --- Diff: src/main/java/org/apache/commons/imaging/formats/bmp/BmpImageParser.java --- @@ -327,7 +331,7 @@ private BmpImageContents readImageContents(f

[GitHub] commons-imaging pull request #35: IMAGING-154 Removed Debug class

Github user kinow commented on a diff in the pull request: https://github.com/apache/commons-imaging/pull/35#discussion_r210546814 --- Diff: src/main/java/org/apache/commons/imaging/formats/bmp/BmpImageParser.java --- @@ -327,7 +331,7 @@ private BmpImageContents readImageContents(f

[GitHub] commons-imaging pull request #35: IMAGING-154 Removed Debug class

Github user kinow commented on a diff in the pull request: https://github.com/apache/commons-imaging/pull/35#discussion_r210524716 --- Diff: src/main/java/org/apache/commons/imaging/icc/IccTag.java --- @@ -73,11 +76,12 @@ private IccTagDataType getIccTagDataType(final int quad) {

[GitHub] commons-imaging pull request #35: IMAGING-154 Removed Debug class

Github user kinow commented on a diff in the pull request: https://github.com/apache/commons-imaging/pull/35#discussion_r210523866 --- Diff: src/main/java/org/apache/commons/imaging/formats/psd/PsdHeaderInfo.java --- @@ -45,9 +50,14 @@ public PsdHeaderInfo(final int version, final

[GitHub] commons-imaging pull request #35: IMAGING-154 Removed Debug class

Github user kinow commented on a diff in the pull request: https://github.com/apache/commons-imaging/pull/35#discussion_r210521304 --- Diff: src/main/java/org/apache/commons/imaging/formats/bmp/BmpImageParser.java --- @@ -327,7 +331,7 @@ private BmpImageContents readImageContents(f

[GitHub] commons-imaging pull request #35: IMAGING-154 Removed Debug class

Github user kinow commented on a diff in the pull request: https://github.com/apache/commons-imaging/pull/35#discussion_r210519489 --- Diff: src/main/java/org/apache/commons/imaging/formats/png/chunks/PngChunkText.java --- @@ -42,9 +47,9 @@ public PngChunkText(final int length, fi

[GitHub] commons-imaging pull request #35: IMAGING-154 Removed Debug class

Github user sebbASF commented on a diff in the pull request: https://github.com/apache/commons-imaging/pull/35#discussion_r210327438 --- Diff: src/main/java/org/apache/commons/imaging/formats/bmp/BmpImageParser.java --- @@ -327,7 +331,7 @@ private BmpImageContents readImageContents

[GitHub] commons-imaging pull request #35: IMAGING-154 Removed Debug class

Github user garydgregory commented on a diff in the pull request: https://github.com/apache/commons-imaging/pull/35#discussion_r210287763 --- Diff: src/test/java/org/apache/commons/imaging/formats/jpeg/exif/WriteExifMetadataExampleTest.java --- @@ -27,7 +27,7 @@ import org.ap

[GitHub] commons-imaging pull request #35: IMAGING-154 Removed Debug class

Github user garydgregory commented on a diff in the pull request: https://github.com/apache/commons-imaging/pull/35#discussion_r210287591 --- Diff: src/main/java/org/apache/commons/imaging/icc/IccTag.java --- @@ -73,11 +76,12 @@ private IccTagDataType getIccTagDataType(final int qu

[GitHub] commons-imaging pull request #35: IMAGING-154 Removed Debug class

Github user garydgregory commented on a diff in the pull request: https://github.com/apache/commons-imaging/pull/35#discussion_r210287298 --- Diff: src/main/java/org/apache/commons/imaging/formats/tiff/TiffField.java --- @@ -355,9 +360,14 @@ private String getValueDescription(final

[GitHub] commons-imaging pull request #35: IMAGING-154 Removed Debug class

Github user garydgregory commented on a diff in the pull request: https://github.com/apache/commons-imaging/pull/35#discussion_r210287176 --- Diff: src/main/java/org/apache/commons/imaging/formats/psd/PsdImageContents.java --- @@ -40,9 +45,14 @@ public PsdImageContents(final PsdHea

[GitHub] commons-imaging pull request #35: IMAGING-154 Removed Debug class

Github user garydgregory commented on a diff in the pull request: https://github.com/apache/commons-imaging/pull/35#discussion_r210287038 --- Diff: src/main/java/org/apache/commons/imaging/formats/psd/PsdHeaderInfo.java --- @@ -45,9 +50,14 @@ public PsdHeaderInfo(final int version,

[GitHub] commons-imaging pull request #35: IMAGING-154 Removed Debug class

Github user garydgregory commented on a diff in the pull request: https://github.com/apache/commons-imaging/pull/35#discussion_r210286764 --- Diff: src/main/java/org/apache/commons/imaging/formats/png/chunks/PngChunkText.java --- @@ -42,9 +47,9 @@ public PngChunkText(final int len

[GitHub] commons-imaging pull request #35: IMAGING-154 Removed Debug class

Github user garydgregory commented on a diff in the pull request: https://github.com/apache/commons-imaging/pull/35#discussion_r210286324 --- Diff: src/main/java/org/apache/commons/imaging/formats/bmp/BmpImageParser.java --- @@ -327,7 +331,7 @@ private BmpImageContents readImageCon

[GitHub] commons-imaging pull request #35: IMAGING-154 Removed Debug class

GitHub user kinow opened a pull request: https://github.com/apache/commons-imaging/pull/35 IMAGING-154 Removed Debug class Removed the `Debug` and `ImageDump` classes. Also removed methods with the `verbose` parameter, as well as any `System.out.println`'s. Tried to keep the change