Github user garydgregory commented on a diff in the pull request:
https://github.com/apache/commons-imaging/pull/35#discussion_r210286324
--- Diff:
src/main/java/org/apache/commons/imaging/formats/bmp/BmpImageParser.java ---
@@ -327,7 +331,7 @@ private BmpImageContents readImageContents(final
InputStream is,
switch (bhi.compression) {
case BI_RGB:
if (verbose) {
--- End diff --
Seeing "if verbose" and then "log at the info level" is slightly confusing
here. If we want to keep the 'verbose' setting then maybe the code should
rename this to 'logInfo', or, should we provide a setting that contains the log
level to use when 'verbose' is enabled?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org
